Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line

[sudhir kumar <smalikphy@gmail.com>]

On Thu, Jul 16, 2009 at 8:12 AM, Yolkfull Chow<yzhou@redhat.com> wrote:
> On 07/15/2009 09:36 PM, Dor Laor wrote:
>> On 07/15/2009 12:12 PM, Yolkfull Chow wrote:
>>> Would submit this patch which is from our internal kvm-autotest
>>> patches submitted by Jason.
>>> So that we could go on test case about parameters verification(UUID,
>>> DMI data etc).
>>>
>>> Signed-off-by: Yolkfull Chow<yzhou@redhat.com>
>>> ---
>>>   client/tests/kvm/kvm_vm.py |    4 ++++
>>>   1 files changed, 4 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py
>>> index 503f636..68cc235 100644
>>> --- a/client/tests/kvm/kvm_vm.py
>>> +++ b/client/tests/kvm/kvm_vm.py
>>> @@ -287,6 +287,10 @@ class VM:
>>>           elif params.get("display") == "nographic":
>>>               qemu_cmd += " -nographic"
>>>
>>> +        uuid = os.popen("cat
>>> /proc/sys/kernel/random/uuid").readline().strip()
>>> +        if uuid:
>>> +            qemu_cmd += " -uuid %s" % uuid
>>
>> If you'll change the uuid on every run, the guest will notice that.
>> Some guest (M$) might not love it.
>> Why not use a static uuid or even just test uuid in a specific test
>> without having it in all tests?
> Hi Dor, since we cannot use a static uuid for running stress_boot test,
> but just assign UUID in a specific test is a good idea. We could use an
> option like assign_uuid = yes for that specific test?

This will be far better and more flexible.
>>
>> btw: why you're at it, please add uuid to the block devices too.
>> + the -smbios option.
> Do you mean assign serial number for block devices?
>
> Thanks for suggestions. :)
>>
>> Thanks,
>> dor
>>
>>> +
>>>           return qemu_cmd
>>>
>>>
>>
>
>
> --
> Yolkfull
> Regards,
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>



-- 
Sudhir Kumar