From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudhir kumar Subject: Re: [Autotest] [PATCH] Assign an UUID for each VM in kvm command line Date: Thu, 16 Jul 2009 09:41:34 +0530 Message-ID: References: <1247649149-28353-1-git-send-email-yzhou@redhat.com> <4A5DDB66.9080400@redhat.com> <4A5E9397.4050100@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: dlaor@redhat.com, autotest@test.kernel.org, jasowang@redhat.com, kvm@vger.kernel.org To: Yolkfull Chow Return-path: Received: from wf-out-1314.google.com ([209.85.200.172]:63116 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbZGPELf convert rfc822-to-8bit (ORCPT ); Thu, 16 Jul 2009 00:11:35 -0400 Received: by wf-out-1314.google.com with SMTP id 26so1387001wfd.4 for ; Wed, 15 Jul 2009 21:11:34 -0700 (PDT) In-Reply-To: <4A5E9397.4050100@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jul 16, 2009 at 8:12 AM, Yolkfull Chow wrote: > On 07/15/2009 09:36 PM, Dor Laor wrote: >> On 07/15/2009 12:12 PM, Yolkfull Chow wrote: >>> Would submit this patch which is from our internal kvm-autotest >>> patches submitted by Jason. >>> So that we could go on test case about parameters verification(UUID= , >>> DMI data etc). >>> >>> Signed-off-by: Yolkfull Chow >>> --- >>> =A0 client/tests/kvm/kvm_vm.py | =A0 =A04 ++++ >>> =A0 1 files changed, 4 insertions(+), 0 deletions(-) >>> >>> diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.p= y >>> index 503f636..68cc235 100644 >>> --- a/client/tests/kvm/kvm_vm.py >>> +++ b/client/tests/kvm/kvm_vm.py >>> @@ -287,6 +287,10 @@ class VM: >>> =A0 =A0 =A0 =A0 =A0 elif params.get("display") =3D=3D "nographic": >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 qemu_cmd +=3D " -nographic" >>> >>> + =A0 =A0 =A0 =A0uuid =3D os.popen("cat >>> /proc/sys/kernel/random/uuid").readline().strip() >>> + =A0 =A0 =A0 =A0if uuid: >>> + =A0 =A0 =A0 =A0 =A0 =A0qemu_cmd +=3D " -uuid %s" % uuid >> >> If you'll change the uuid on every run, the guest will notice that. >> Some guest (M$) might not love it. >> Why not use a static uuid or even just test uuid in a specific test >> without having it in all tests? > Hi Dor, since we cannot use a static uuid for running stress_boot tes= t, > but just assign UUID in a specific test is a good idea. We could use = an > option like assign_uuid =3D yes for that specific test? This will be far better and more flexible. >> >> btw: why you're at it, please add uuid to the block devices too. >> + the -smbios option. > Do you mean assign serial number for block devices? > > Thanks for suggestions. :) >> >> Thanks, >> dor >> >>> + >>> =A0 =A0 =A0 =A0 =A0 return qemu_cmd >>> >>> >> > > > -- > Yolkfull > Regards, > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > --=20 Sudhir Kumar