From mboxrd@z Thu Jan 1 00:00:00 1970 From: sudhir kumar Subject: Re: [Autotest] [KVM_AUTOTEST] add kvm hugepage variant Date: Wed, 22 Jul 2009 11:27:05 +0530 Message-ID: References: <4A55B759.5080302@redhat.com> <4A57118F.3030907@redhat.com> <1248094728.5318.18.camel@localhost.localdomain> <4A65E6FB.1090901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Lucas Meneghel Rodrigues , Autotest mailing list , Jason Wang , KVM list To: =?UTF-8?B?THVrw6HFoSBEb2t0b3I=?= Return-path: Received: from wf-out-1314.google.com ([209.85.200.172]:12174 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756222AbZGVF5F convert rfc822-to-8bit (ORCPT ); Wed, 22 Jul 2009 01:57:05 -0400 Received: by wf-out-1314.google.com with SMTP id 26so1069416wfd.4 for ; Tue, 21 Jul 2009 22:57:05 -0700 (PDT) In-Reply-To: <4A65E6FB.1090901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: The patch looks to be pretty clean to me. I was running a small hugetlbfs script doing the same, but its good now as the script is being incorporated in the test. On Tue, Jul 21, 2009 at 9:34 PM, Luk=C3=A1=C5=A1 Doktor wrote: > Well, thank you for notifications, I'll keep them in my mind. > > Also the problem with mempath vs. mem-path is solved. It was just a m= isspell > in one version of KVM. > > * fixed patch attached > > Dne 20.7.2009 14:58, Lucas Meneghel Rodrigues napsal(a): >> >> On Fri, 2009-07-10 at 12:01 +0200, Luk=C3=A1=C5=A1 Doktor wrote: >>> >>> After discussion I split the patches. >> >> Hi Luk=C3=A1=C5=A1, sorry for the delay answering your patch. Looks = good to me in >> general, I have some remarks to make: >> >> 1) When posting patches to the autotest kvm tests, please cross post= the >> autotest mailing list (autotest@test.kernel.org) and the KVM list. >> >> 2) About scripts to prepare the environment to perform tests - we've= had >> some discussion about including shell scripts on autotest. Bottom li= ne, >> autotest has a policy of not including non python code when possible >> [1]. So, would you mind re-creating your hugepage setup code in pyth= on >> and re-sending it? >> >> Thanks for your contribution, looking forward getting it integrated = to >> our tests. >> >> [1] Unless when it is not practical for testing purposes - writing t= ests >> in C is just fine, for example. >> >>> This patch adds kvm_hugepage variant. It prepares the host system a= nd >>> start vm with -mem-path option. It does not clean after itself, bec= ause >>> =C2=A0 it's impossible to unmount and free hugepages before all gue= sts are >>> destroyed. >>> >>> I need to ask you what to do with change of qemu parameter. Newest >>> versions are using -mempath insted of -mem-path. This is impossible= to >>> fix using current config file. I can see 2 solutions: >>> 1) direct change in kvm_vm.py (parse output and try another param) >>> 2) detect qemu capabilities outside and create additional layer (be= tter >>> for future occurrence) >>> >>> Dne 9.7.2009 11:24, Luk=C3=A1=C5=A1 Doktor napsal(a): >>>> >>>> This patch adds kvm_hugepage variant. It prepares the host system = and >>>> start vm with -mem-path option. It does not clean after itself, be= cause >>>> it's impossible to unmount and free hugepages before all guests ar= e >>>> destroyed. >>>> >>>> There is also added autotest.libhugetlbfs test. >>>> >>>> I need to ask you what to do with change of qemu parameter. Newest >>>> versions are using -mempath insted of -mem-path. This is impossibl= e to >>>> fix using current config file. I can see 2 solutions: >>>> 1) direct change in kvm_vm.py (parse output and try another param) >>>> 2) detect qemu capabilities outside and create additional layer (b= etter >>>> for future occurrence) >>>> >>>> Tested by:ldoktor@redhat.com on RHEL5.4 with kvm-83-72.el5 >> > > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > --=20 Sudhir Kumar