public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: sudhir kumar <smalikphy@gmail.com>
To: Autotest mailing list <autotest@test.kernel.org>
Cc: kvm-devel <kvm@vger.kernel.org>,
	Lucas Meneghel Rodrigues <mrodrigu@redhat.com>,
	Michael Goldish <mgoldish@redhat.com>,
	smalikphy@gmail.com
Subject: [AUTOTEST] print login command and change some timeout values
Date: Fri, 24 Jul 2009 16:58:37 +0530	[thread overview]
Message-ID: <a50cf5ab0907240428i6e138d82u87b3e514ce8f253c@mail.gmail.com> (raw)

This patch does two small things.
1. Prints the guest login command to debug messages.
2. Changes the guest login timeout to 240 seconds. I see the timeout for
*.wait_for() functions in boot test is 240 seconds, while in reboot is 120
seconds which causes the test to fail. We might have missed it by mistake.
240 seconds is a reasonable timeout duration. This patch fixes that.

Signed-off-by: Sudhir Kumar <skumar@linux.vnet.ibm.com>

Index: autotest/client/tests/kvm/kvm_utils.py
===================================================================
--- autotest.orig/client/tests/kvm/kvm_utils.py
+++ autotest/client/tests/kvm/kvm_utils.py
@@ -637,6 +637,7 @@ def remote_login(command, password, prom
     password_prompt_count = 0

     logging.debug("Trying to login...")
+    logging.debug("Guest login Command: %s" % command)

     while True:
         (match, text) = sub.read_until_last_line_matches(
Index: autotest/client/tests/kvm/kvm_tests.py
===================================================================
--- autotest.orig/client/tests/kvm/kvm_tests.py
+++ autotest/client/tests/kvm/kvm_tests.py
@@ -48,7 +48,7 @@ def run_boot(test, params, env):

         logging.info("Guest is down; waiting for it to go up again...")

-        session = kvm_utils.wait_for(vm.ssh_login, 120, 0, 2)
+        session = kvm_utils.wait_for(vm.ssh_login, 240, 0, 2)
         if not session:
             raise error.TestFail("Could not log into guest after reboot")

@@ -88,7 +88,7 @@ def run_shutdown(test, params, env):

     logging.info("Shutdown command sent; waiting for guest to go down...")

-    if not kvm_utils.wait_for(vm.is_dead, 120, 0, 1):
+    if not kvm_utils.wait_for(vm.is_dead, 240, 0, 1):
         raise error.TestFail("Guest refuses to go down")

     logging.info("Guest is down")
@@ -445,7 +445,7 @@ def run_yum_update(test, params, env):

     logging.info("Logging into guest...")

-    session = kvm_utils.wait_for(vm.ssh_login, 120, 0, 2)
+    session = kvm_utils.wait_for(vm.ssh_login, 240, 0, 2)
     if not session:
         message = "Could not log into guest"
         logging.error(message)



-- 
Sudhir Kumar

             reply	other threads:[~2009-07-24 11:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24 11:28 sudhir kumar [this message]
2009-07-24 11:29 ` [AUTOTEST] print login command and change some timeout values sudhir kumar
     [not found] <181931540.953991248437806958.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-07-24 12:24 ` Michael Goldish
2009-07-24 15:00   ` sudhir kumar
     [not found] <1629700637.973841248451192277.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com>
2009-07-24 16:03 ` Michael Goldish
2009-07-24 17:48   ` Lucas Meneghel Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a50cf5ab0907240428i6e138d82u87b3e514ce8f253c@mail.gmail.com \
    --to=smalikphy@gmail.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=mgoldish@redhat.com \
    --cc=mrodrigu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox