From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48AD22063E4 for ; Tue, 4 Feb 2025 07:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738655099; cv=none; b=m7oxbX0cEhDlCP6w6ZDy+tWuie7NAPpSH+Mu4DIJyQDrWbQ7NKM+tWH8+iEghachXJmLDpSSX2dYYkbLD80hNGfXORp6NeQdxss7F6sozTqnaZ2PtvTKL/6J8tXAuI4+X/8uuzmQ0Uys1ACltent6t+WeICWqz3F4/Vl2s4bEWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738655099; c=relaxed/simple; bh=a14rw0LIy/PyBG4bDSExLlTaMzdC9tbCktY6lF1hLIA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XV/GSCsPELGPKmFFGPFBOuaevnVQO0bvSorr9tp1s904B+pmUujLvmP4OtAoztDaT1KBT0AlbOGOuOJGqlGDRCbTt4t92e3lyJ8ZVq5ijTJskFv3KCeqVxlfh9/t2BBaAEW29TQ00G030/nRkM4K2XBEnBX0cg5BIt894QTwhVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I6swGSxH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I6swGSxH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738655095; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T2QtEPy+qAYhHF6Zresos1Bfs4czVUmivuu05zxY4QM=; b=I6swGSxHrd6sDZppCVIiw3PQBb/Gp63YOfgH0dU1t+4VNOOvgznomAUsLNAnzif5E47OKw z3PGNVSL95mxdJuwQJclc+zK0REAF9+HOdwnpwmIsC4dFn6rx57164CYfk0ZGyJUC/VN7m SmotPXRFJxXqRY87kuPGRZOEeLfrWOc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-oH3PSjCAO2WVMwIYZguAxw-1; Tue, 04 Feb 2025 02:44:54 -0500 X-MC-Unique: oH3PSjCAO2WVMwIYZguAxw-1 X-Mimecast-MFC-AGG-ID: oH3PSjCAO2WVMwIYZguAxw Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3862b364578so2909879f8f.1 for ; Mon, 03 Feb 2025 23:44:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738655093; x=1739259893; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T2QtEPy+qAYhHF6Zresos1Bfs4czVUmivuu05zxY4QM=; b=D4gdk2ry8XTbkrPUaGhB99HVuDZhUm2ENSRA+m64enU6YLpczbNH+Vczwhn4kIgz10 2JJTmM3IZ42rPn1dnPbwjwsnzO06525OBYL2vN8uHxYB68xf4S3euHqL/QpCJolYSIie gflx/K/7+jJEp0Co67D5+t7qrJSH/TC46g0v1inyQiPUzl227U6p+SPblR0BelmTvBfc oAV2B+HwQcSe93tNeO/Vaiedbg1s/OoZhCXr3w3ON0Jv+sHEJSvs4m9v1G0E+NNqQrgh UYiEgilmYPpk2YNx6jFbuM3FLMso/RkfOjQ3KddSFpCamA740c7Io0BwgNuCjwv9N1Gh zIGA== X-Gm-Message-State: AOJu0Yyh6FDCwHq1Z9AF5y/oPw7RPTnI4dYWrlmOptn6H/iT6yo3dWfk KIlqNxmJhKX20p3o5yFiDywEFtb3d5GMJtWWGI2jAscQ+o/DUkljgufI3XRJSCxMvw0bDmAw7ro RM5CfKgqBEEV+Msx8VRTyNwGG6ICxNpiBn3R5sinuc1H9HNnyEg== X-Gm-Gg: ASbGncspqFYze2p730iApIZkkG0L1e0G5a6yz8/zSPEK7N1PQTMFolhaQQT9Zv9ZeuB saIWk9n55pDS/iNXDl3O+HOlqHi8nRd/BeGMeuN/LRqmYP1bPQHbY5+/ml8pAazpRAEKxnPuQ1H 9gahZ8r4lnL42D3wULks14vHxsP5oZAktpkEYu//oj3TM60RH2W0/dAqTUDg9MBQZ8lMQDtg6ed cmRcUho1JJos7CJ84+GqvH6DkOES75wxCuxi0gqgKhTqBhU5XuxSwZFUfWSnhHT8gRcffF1j+wY uMjP0jzbiDHkcLahudIPTh2XsDnbt4yYskh3FnnPzPWqTo79o29Q X-Received: by 2002:a05:6000:1fa6:b0:385:df17:2148 with SMTP id ffacd0b85a97d-38da53da590mr1660240f8f.20.1738655093278; Mon, 03 Feb 2025 23:44:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IECJI3XsUYM4TaIUzBOg44CtHjQ1FHzzLGnEbKrdjBkjypV2jsCCvk+eKb0HnE9hjdbm4Ni7w== X-Received: by 2002:a05:6000:1fa6:b0:385:df17:2148 with SMTP id ffacd0b85a97d-38da53da590mr1660222f8f.20.1738655092955; Mon, 03 Feb 2025 23:44:52 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c1b5492sm15063176f8f.73.2025.02.03.23.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Feb 2025 23:44:52 -0800 (PST) Message-ID: Date: Tue, 4 Feb 2025 08:44:50 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: eric.auger@redhat.com Subject: Re: [kvm-unit-tests PATCH] arm: pmu: Actually use counter 0 in test_event_counter_config() Content-Language: en-US To: Oliver Upton , kvmarm@lists.linux.dev Cc: kvm@vger.kernel.org, Andrew Jones , Alexandru Elisei References: <20250203181026.159721-1-oliver.upton@linux.dev> From: Eric Auger In-Reply-To: <20250203181026.159721-1-oliver.upton@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Oliver, On 2/3/25 7:10 PM, Oliver Upton wrote: > test_event_counter_config() checks that there is at least one event > counter but mistakenly uses counter 1 for part of the test. > > Most implementations have more than a single event counter which is > probably why this went unnoticed. However, due to limitations of the > underlying hardware, KVM's PMUv3 emulation on Apple silicon can only > provide 1 event counter. > > Consistenly use counter 0 throughout the test, matching the precondition > and allowing the test to pass on Apple parts. > > Cc: Eric Auger > Fixes: 4ce2a804 ("arm: pmu: Basic event counter Tests") > Signed-off-by: Oliver Upton > --- > arm/pmu.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arm/pmu.c b/arm/pmu.c > index 9ff7a301..2dc0822b 100644 > --- a/arm/pmu.c > +++ b/arm/pmu.c > @@ -396,13 +396,13 @@ static void test_event_counter_config(void) > * Test setting through PMESELR/PMXEVTYPER and PMEVTYPERn read, > * select counter 0 > */ > - write_sysreg(1, PMSELR_EL0); > + write_sysreg(0, PMSELR_EL0); > /* program this counter to count unsupported event */ > write_sysreg(0xEA, PMXEVTYPER_EL0); > write_sysreg(0xdeadbeef, PMXEVCNTR_EL0); > - report((read_regn_el0(pmevtyper, 1) & 0xFFF) == 0xEA, > + report((read_regn_el0(pmevtyper, 0) & 0xFFF) == 0xEA, > "PMESELR/PMXEVTYPER/PMEVTYPERn"); > - report((read_regn_el0(pmevcntr, 1) == 0xdeadbeef), > + report((read_regn_el0(pmevcntr, 0) == 0xdeadbeef), > "PMESELR/PMXEVCNTR/PMEVCNTRn"); Reviewed-by: Eric Auger Thank you for noticing and fixing that Eric > > /* try to configure an unsupported event within the range [0x0, 0x3F] */ > > base-commit: 1f08a91a41402b0e032ecce8ed1b5952cbfca0ea