From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre Morel Subject: Re: [PATCH] vfio/iommu_type1: report the IOMMU aperture info Date: Thu, 30 Nov 2017 15:17:36 +0100 Message-ID: References: <1512041678-4563-1-git-send-email-pmorel@linux.vnet.ibm.com> <5c434d35-70eb-2d2b-4efa-b9a072e973a6@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: cohuck@redhat.com, borntraeger@de.ibm.com, zyimin@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Auger Eric , alex.williamson@redhat.com Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43344 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdK3ORp (ORCPT ); Thu, 30 Nov 2017 09:17:45 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vAUEGBTU131896 for ; Thu, 30 Nov 2017 09:17:44 -0500 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ejjr7uaxd-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 30 Nov 2017 09:17:44 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 30 Nov 2017 14:17:41 -0000 In-Reply-To: <5c434d35-70eb-2d2b-4efa-b9a072e973a6@redhat.com> Content-Language: en-US Sender: kvm-owner@vger.kernel.org List-ID: On 30/11/2017 14:22, Auger Eric wrote: > Hi Pierre, > On 30/11/17 12:34, Pierre Morel wrote: >> When userland VFIO defines a new IOMMU for a guest it may >> want to specify to the guest the physical limits of >> the underlying host IOMMU to avoid access to forbidden >> memory ranges. >> >> Currently, the vfio_iommu_type1 driver does not report this >> information to userland. >> >> Let's extend the vfio_iommu_type1_info structure reported >> by the ioctl VFIO_IOMMU_GET_INFO command to report the >> IOMMU limits as new uint64_t entries aperture_start and >> aperture_end. >> >> Let's also extend the flags bit map to add a flag specifying >> if this extension of the info structure is reported or not. >> >> Signed-off-by: Pierre Morel >> --- >> drivers/vfio/vfio_iommu_type1.c | 42 +++++++++++++++++++++++++++++++++++++++++ >> include/uapi/linux/vfio.h | 3 +++ >> 2 files changed, 45 insertions(+) >> >> diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c >> index 8549cb1..7da5fe0 100644 >> --- a/drivers/vfio/vfio_iommu_type1.c >> +++ b/drivers/vfio/vfio_iommu_type1.c >> @@ -1526,6 +1526,40 @@ static int vfio_domains_have_iommu_cache(struct vfio_iommu *iommu) >> return ret; >> } >> >> +/** >> + * vfio_get_aperture - report minimal aperture of a vfio_iommu >> + * @iommu: the current vfio_iommu >> + * @start: a pointer to the aperture start >> + * @end : a pointer to the aperture end >> + * >> + * This function iterate on the domains using the given vfio_iommu >> + * and restrict the aperture to the minimal aperture common >> + * to all domains sharing this vfio_iommu. >> + */ >> +static void vfio_get_aperture(struct vfio_iommu *iommu, uint64_t *start, >> + uint64_t *end) >> +{ >> + struct iommu_domain_geometry geometry; >> + struct vfio_domain *domain; >> + >> + *start = 0; >> + *end = U64_MAX; >> + >> + mutex_lock(&iommu->lock); >> + /* loop on all domains using this vfio_iommu */ >> + list_for_each_entry(domain, &iommu->domain_list, next) { >> + iommu_domain_get_attr(domain->domain, DOMAIN_ATTR_GEOMETRY, >> + &geometry); >> + if (geometry.force_aperture) { >> + if (geometry.aperture_start > *start) >> + *start = geometry.aperture_start; >> + if (geometry.aperture_end < *end) >> + *end = geometry.aperture_end; >> + } >> + } >> + mutex_unlock(&iommu->lock); >> +} >> + >> static long vfio_iommu_type1_ioctl(void *iommu_data, >> unsigned int cmd, unsigned long arg) >> { >> @@ -1560,6 +1594,14 @@ static long vfio_iommu_type1_ioctl(void *iommu_data, >> >> info.iova_pgsizes = vfio_pgsize_bitmap(iommu); >> >> + minsz = min_t(size_t, info.argsz, sizeof(info)); >> + if (minsz >= offsetofend(struct vfio_iommu_type1_info, >> + aperture_end)) { >> + info.flags |= VFIO_IOMMU_INFO_APERTURE; >> + vfio_get_aperture(iommu, &info.aperture_start, >> + &info.aperture_end); >> + } >> + >> return copy_to_user((void __user *)arg, &info, minsz) ? >> -EFAULT : 0; >> >> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h >> index 0fb25fb..780d909 100644 >> --- a/include/uapi/linux/vfio.h >> +++ b/include/uapi/linux/vfio.h >> @@ -519,6 +519,9 @@ struct vfio_iommu_type1_info { >> __u32 flags; >> #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info */ >> __u64 iova_pgsizes; /* Bitmap of supported page sizes */ >> +#define VFIO_IOMMU_INFO_APERTURE (1 << 1) /* supported aperture info */ >> + __u64 aperture_start; /* start of DMA aperture */ >> + __u64 aperture_end; /* end of DMA aperture */ >> }; >> >> #define VFIO_IOMMU_GET_INFO _IO(VFIO_TYPE, VFIO_BASE + 12) >> > > In the past I was told by Alex that using the capability chain > extensions to add some new capabilities was a better approach: > > https://lkml.org/lkml/2016/4/6/751 > > I did that kind of exercise in > [PATCH v9 7/7] vfio/type1: return MSI geometry through > VFIO_IOMMU_GET_INFO capability chains > > https://lists.linuxfoundation.org/pipermail/iommu/2016-May/016892.html > > The patch was not used eventually but maybe that can help. > > Thanks > > Eric > indeed interesting, I will go this way. Thanks and also thanks for the pointers. Pierre -- Pierre Morel Linux/KVM/QEMU in Böblingen - Germany