From: "Huang, Kai" <kai.huang@intel.com>
To: "seanjc@google.com" <seanjc@google.com>,
"tony.lindgren@linux.intel.com" <tony.lindgren@linux.intel.com>
Cc: "Li, Xiaoyao" <xiaoyao.li@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH 1/1] KVM: TDX: Fix uninitialized error code for __tdx_bringup()
Date: Tue, 9 Sep 2025 22:19:09 +0000 [thread overview]
Message-ID: <a881591de9e739e04c55477bf832e60a2dcf171f.camel@intel.com> (raw)
In-Reply-To: <aMAvYIN7-6iqQNBt@google.com>
On Tue, 2025-09-09 at 06:45 -0700, Sean Christopherson wrote:
> On Tue, Sep 09, 2025, Tony Lindgren wrote:
> > On Tue, Sep 09, 2025 at 10:55:18AM +0000, Huang, Kai wrote:
> > > How about we just initialize r to -EINVAL once before tdx_get_sysinfo() so
> > > that all 'r = -EINVAL;' can be removed? I think in this way the code
> > > would be simpler (see below diff [*])?
> > >
> > > The "Fixes" tag would be hard to identify,
>
> No, Fixes always points at the commit(s) that introduced buggy behavior. While
> one might argue that commit 61bb28279623 was set up to fail by earlier commits,
> that commit is unequivocally the one and only Fixes commit.
Good to know. Thanks Sean!
prev parent reply other threads:[~2025-09-09 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 10:16 [PATCH 1/1] KVM: TDX: Fix uninitialized error code for __tdx_bringup() Tony Lindgren
2025-09-09 10:55 ` Huang, Kai
2025-09-09 11:05 ` Tony Lindgren
2025-09-09 13:45 ` Sean Christopherson
2025-09-09 22:19 ` Huang, Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a881591de9e739e04c55477bf832e60a2dcf171f.camel@intel.com \
--to=kai.huang@intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=isaku.yamahata@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tony.lindgren@linux.intel.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox