From: weibu@redadmin.org
To: Jonathan Corbet <corbet@lwn.net>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: wmi: lenovo-wmi-gamezone: fix typo in frequency
Date: Wed, 17 Sep 2025 08:39:29 +0900 [thread overview]
Message-ID: <a88c47e98139a6264670879407fb09a3@redadmin.org> (raw)
In-Reply-To: <877bxyfkw7.fsf@trenco.lwn.net>
Hi Jon,
You’re right — that block is a verbatim MOF listing decoded by bmfdec,
and the misspelling comes from the vendor-provided Description string.
So this isn’t an editing error in the docs.
I’ll drop this patch. If it helps future readers, I can send a follow-up
that adds a short note saying the MOF listing is verbatim and typos are
preserved.
Thanks for the careful review!
Akiyoshi
2025-09-17 00:59 に Jonathan Corbet さんは書きました:
> Akiyoshi Kurita <weibu@redadmin.org> writes:
>
>> Fix a spelling mistake in lenovo-wmi-gamezone.rst
>> ("freqency" -> "frequency").
>>
>> No functional change.
>>
>> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
>> ---
>> Documentation/wmi/devices/lenovo-wmi-gamezone.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>> b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>> index 997263e51a7d..167548929ac2 100644
>> --- a/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>> +++ b/Documentation/wmi/devices/lenovo-wmi-gamezone.rst
>> @@ -153,7 +153,7 @@ data using the `bmfdec
>> <https://github.com/pali/bmfdec>`_ utility:
>> [WmiDataId(1), read, Description("P-State ID.")] uint32 PStateID;
>> [WmiDataId(2), read, Description("CLOCK ID.")] uint32 ClockID;
>> [WmiDataId(3), read, Description("Default value.")] uint32
>> defaultvalue;
>> - [WmiDataId(4), read, Description("OC Offset freqency.")] uint32
>> OCOffsetFreq;
>> + [WmiDataId(4), read, Description("OC Offset frequency")] uint32
>> OCOffsetFreq;
>> [WmiDataId(5), read, Description("OC Min offset value.")] uint32
>> OCMinOffset;
>
> I don't have the device in question and can't test this ... but the
> text
> in question has the appearance of being literal output from the bmfdec
> utility. Do we know that this is some sort of editing error rather
> than
> an accurate reflection of what the tool prints?
>
> Thanks,
>
> jon
prev parent reply other threads:[~2025-09-16 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-13 17:38 [PATCH] docs: wmi: lenovo-wmi-gamezone: fix typo in frequency Akiyoshi Kurita
2025-09-16 15:59 ` Jonathan Corbet
2025-09-16 23:39 ` weibu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a88c47e98139a6264670879407fb09a3@redadmin.org \
--to=weibu@redadmin.org \
--cc=corbet@lwn.net \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox