From: Dan Magenheimer <dan.magenheimer@oracle.com>
To: Konrad Wilk <konrad.wilk@oracle.com>, Avi Kivity <avi@redhat.com>
Cc: Akshay Karle <akshay.a.karle@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
ashu tripathi <er.ashutripathi@gmail.com>,
nishant gulhane <nishant.s.gulhane@gmail.com>,
amarmore2006 <amarmore2006@gmail.com>,
Shreyas Mahure <shreyas.mahure@gmail.com>,
mahesh mohan <mahesh6490@gmail.com>
Subject: RE: [RFC 0/2] kvm: Transcendent Memory (tmem) on KVM
Date: Thu, 15 Mar 2012 12:16:04 -0700 (PDT) [thread overview]
Message-ID: <a943f71d-219a-4c9a-aa2a-4be83132df14@default> (raw)
In-Reply-To: <20120315180233.GF452@phenom.dumpdata.com>
> From: Konrad Rzeszutek Wilk
> Subject: Re: [RFC 0/2] kvm: Transcendent Memory (tmem) on KVM
>
> On Thu, Mar 15, 2012 at 08:01:52PM +0200, Avi Kivity wrote:
> > On 03/15/2012 07:49 PM, Dan Magenheimer wrote:
> > >
> > > The "WasActive" patch (https://lkml.org/lkml/2012/1/25/300)
> > > is intended to avoid the streaming situation you are creating here.
> > > It increases the "quality" of cached pages placed into zcache
> > > and should probably also be used on the guest-side stubs (and/or maybe
> > > the host-side zcache... I don't know KVM well enough to determine
> > > if that would work).
> > >
> > > As Dave Hansen pointed out, the WasActive patch is not yet correct
> > > and, as akpm points out, pageflag bits are scarce on 32-bit systems,
> > > so it remains to be seen if the WasActive patch can be upstreamed.
> > > Or maybe there is a different way to achieve the same goal.
> > > But I wanted to let you know that the streaming issue is understood
> > > and needs to be resolved for some cleancache backends just as it was
> > > resolved in the core mm code.
> >
> > Nice. This takes care of the tail-end of the streaming (the more
> > important one - since it always involves a cold copy). What about the
> > other side? Won't the read code invoke cleancache_get_page() for every
> > page? (this one is just a null hypercall, so it's cheaper, but still
> > expensive).
>
> That is something we should fix - I think it was mentioned in the frontswap
> email thread the need for batching and it certainly seems required as those
> hypercalls aren't that cheap.
And exactly how expensive ARE hypercalls these days? On the first VT/SVN
systems they were tens of thousands of cycles... now they are closer
to sub-thousand are they not? (I remember seeing a graph of hypercall
overhead dropping across generations of CPUs... anybody have a pointer to
a public graph of this?)
One of my favorite papers these days is "When Poll is Better than Interrupt"
(http://static.usenix.org/events/fast12/tech/full_papers/Yang.pdf) which
argues that wasting some CPU cycles doing a busy-wait is often more
efficient than slogging through the Block I/O subsystem to set up
and respond to an interrupt, if the device is fast enough. I wonder if the
same might be true comparing hypercall overhead for tmem vs the path for
KVM to get a page from the host via its normal path?
Ignoring that for now, if excessive hypercalls is a problem, a better
solution than batching may be to modify the Maharashtra approach to
be more like RAMster: Put zcache in the guest-side and treat the
host like a "remote" system.
But let's wait for the Maharashta team to do some measurements first
before we make any assumptions or change any designs...
prev parent reply other threads:[~2012-03-15 19:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 16:29 [RFC 0/2] kvm: Transcendent Memory (tmem) on KVM Akshay Karle
2012-03-15 16:42 ` Konrad Rzeszutek Wilk
2012-03-15 16:48 ` Konrad Rzeszutek Wilk
2012-03-15 16:58 ` Avi Kivity
2012-03-15 17:49 ` Dan Magenheimer
2012-03-15 18:01 ` Avi Kivity
2012-03-15 18:02 ` Konrad Rzeszutek Wilk
2012-03-15 18:10 ` Avi Kivity
2012-03-15 19:36 ` Dan Magenheimer
2012-03-15 19:46 ` Konrad Rzeszutek Wilk
2012-03-15 19:16 ` Dan Magenheimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a943f71d-219a-4c9a-aa2a-4be83132df14@default \
--to=dan.magenheimer@oracle.com \
--cc=akshay.a.karle@gmail.com \
--cc=amarmore2006@gmail.com \
--cc=avi@redhat.com \
--cc=er.ashutripathi@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh6490@gmail.com \
--cc=nishant.s.gulhane@gmail.com \
--cc=shreyas.mahure@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox