From: Sean Christopherson <seanjc@google.com>
To: lirongqing <lirongqing@baidu.com>
Cc: pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, kvm@vger.kernel.org,
xuwenjie <xuwenjie04@baidu.com>
Subject: Re: [PATCH] KVM: SVM: move kfree() out of critical zone protected by spin_lock_irqsave
Date: Tue, 22 Apr 2025 06:57:37 -0700 [thread overview]
Message-ID: <aAegUc5HVOjivAjL@google.com> (raw)
In-Reply-To: <20250422120811.3477-1-lirongqing@baidu.com>
On Tue, Apr 22, 2025, lirongqing wrote:
> From: Li RongQing <lirongqing@baidu.com>
>
> Although kfree is a non-sleep function, it is possible to enter a long
> chain of calls probabilistically, so it looks better to move kfree out
> of the critical zone.
Even better, drop the the dynamic allocation entirely :-)
Any testing you can provide on this series would be much appreciated:
https://lore.kernel.org/all/20250404193923.1413163-10-seanjc@google.com
prev parent reply other threads:[~2025-04-22 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 12:08 [PATCH] KVM: SVM: move kfree() out of critical zone protected by spin_lock_irqsave lirongqing
2025-04-22 13:57 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAegUc5HVOjivAjL@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xuwenjie04@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox