From: Sean Christopherson <seanjc@google.com>
To: Manali Shukla <manali.shukla@amd.com>
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
pbonzini@redhat.com, nikunj@amd.com, thomas.lendacky@amd.com,
bp@alien8.de
Subject: Re: [PATCH v4 1/5] KVM: x86: Preparatory patch to move linear_rip out of kvm_pio_request
Date: Wed, 23 Apr 2025 08:22:41 -0700 [thread overview]
Message-ID: <aAkFwT-vX4rqC8N4@google.com> (raw)
In-Reply-To: <20250324130248.126036-2-manali.shukla@amd.com>
On Mon, Mar 24, 2025, Manali Shukla wrote:
> Add a refactoring prep patch to move linear_rip out of kvm_pio_request
> and place it next to complete_userspace_io. There's nothing port I/O
> specific about linear_rip field, it just so happens to that port I/O is the
> only case where KVM's ABI is to let userspace stuff state (to emulate
> RESET) without first completing the I/O instruction.
The shortlog+changelog needs to state what the change is, not what the human that
wrote the code is doing. And the changelog needs to state the motivation. Yes,
the behavior of linear_rip isn't PIO specific, but the field is obviously specific
to PIO, and has been for years, i.e. there's a very good reason why the field is
in kvm_pio_request.
KVM: x86: Make kvm_pio_request.linear_rip a common field for user exits
Move and rename kvm_pio_request.linear_rip to kvm_vcpu_arch.cui_linear_rip
so that the field can be used by other userspace exit completion flows
that need to take action if and only if userspace has not modified RIP.
next prev parent reply other threads:[~2025-04-23 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 13:02 [PATCH v4 0/5] Add support for the Bus Lock Threshold Manali Shukla
2025-03-24 13:02 ` [PATCH v4 1/5] KVM: x86: Preparatory patch to move linear_rip out of kvm_pio_request Manali Shukla
2025-04-23 15:22 ` Sean Christopherson [this message]
2025-03-24 13:02 ` [PATCH v4 2/5] x86/cpufeatures: Add CPUID feature bit for the Bus Lock Threshold Manali Shukla
2025-03-24 21:56 ` Borislav Petkov
2025-04-09 6:00 ` Manali Shukla
2025-04-09 9:21 ` Borislav Petkov
2025-04-10 23:25 ` Sean Christopherson
2025-04-23 5:58 ` Manali Shukla
2025-03-24 13:02 ` [PATCH v4 3/5] KVM: SVM: Enable Bus lock threshold exit Manali Shukla
2025-04-16 6:00 ` Xiaoyao Li
2025-04-23 6:15 ` Manali Shukla
2025-04-23 15:29 ` Sean Christopherson
2025-04-30 11:15 ` Manali Shukla
2025-03-24 13:02 ` [PATCH v4 4/5] KVM: SVM: Add support for KVM_CAP_X86_BUS_LOCK_EXIT on SVM CPUs Manali Shukla
2025-04-16 6:14 ` Xiaoyao Li
2025-04-23 11:26 ` Manali Shukla
2025-04-23 15:30 ` Sean Christopherson
2025-04-30 11:18 ` Manali Shukla
2025-04-23 15:44 ` Sean Christopherson
2025-04-30 11:30 ` Manali Shukla
2025-03-24 13:02 ` [PATCH v4 5/5] KVM: selftests: Add bus lock exit test Manali Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAkFwT-vX4rqC8N4@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).