From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D61C13E02D for ; Fri, 9 May 2025 02:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746757798; cv=none; b=NL3KAUAYEh4GkgAr8NmdtdV36JncT5RSBQRO6HGXrWvZwhl0dqwFsbKo7Ilb4Akgonu+dHTLEWEqaRqkulB1eJtb1KLZg7HXZivT1HSTFeWoU3CzjCLuAOkH8ftejA40Pz/y4ihQNwdIeUQhdfdCHdOjm7RNjWaggtCh/qs/bqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746757798; c=relaxed/simple; bh=7Tb77gPHUH0LPQdGOdm6IjNB2V0ob4F/eCHrWe81rIU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jB57XliM+hsJb9rad3ki0LtCmGZUPDs04Q+ZSuES8jsRFFvCN7dEKLEeliaAgKKMM921Wg7h3gh1snoDYZwhwenM44F7pL3nqxydie4kwUTkwTM02N0ItNt6ujDwxUusmXrK0B8vv8vuigiS1RBbQ9JYen7LaKVyCj1TtbJnDm0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PZp2OnF/; arc=none smtp.client-ip=192.198.163.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PZp2OnF/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746757797; x=1778293797; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=7Tb77gPHUH0LPQdGOdm6IjNB2V0ob4F/eCHrWe81rIU=; b=PZp2OnF/mJDspnZsTrz2K5LQeK4cYvqs5DZ0wthb1p6gI3ZUy4lpKvTC ND/7gVwazTk6k/FbYh6To6juSOQ5LuK/E6qosRlStTptKLFvy2BvleQrb fFM4mvUqSnmrqCWa3LS1iLwWUriN7tt3DbwTfKOKxbL/cijacD0OKZpFU c+MLMfp2NIUDBk2b5k22BetuAu9W88pcS4WWoda+rTdLn389LD0NXdt1X zoInX5e70FrwhiQjHI/aYoEpQOmg1aQL02IVvVteU8tiJQOe6A2tuPa9W CFl+EWKvbKvf4ApeH+A3GTHASQ8nAYQZ6Y5FvbGkDwpEeswg/83cAJGFc w==; X-CSE-ConnectionGUID: 7XKkcDqLSa2aNtAah3ttdA== X-CSE-MsgGUID: K4Wf8DTLRZ2zWEWvASNbRQ== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="36196651" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="36196651" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2025 19:29:56 -0700 X-CSE-ConnectionGUID: O4kiPmhbQaGrST7uwiUwRg== X-CSE-MsgGUID: ovYRMySHRxKudYS2HsQStw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="136362015" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa010.jf.intel.com with ESMTP; 08 May 2025 19:29:50 -0700 Date: Fri, 9 May 2025 10:50:51 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Igor Mammedov , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?iso-8859-1?Q?Cl=E9ment?= Mathieu--Drif , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Huacai Chen , Jason Wang Subject: Re: [PATCH v4 05/27] hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out Message-ID: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-6-philmd@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250508133550.81391-6-philmd@linaro.org> On Thu, May 08, 2025 at 03:35:28PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:28 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 05/27] hw/nvram/fw_cfg: Factor > fw_cfg_init_mem_internal() out > X-Mailer: git-send-email 2.47.1 > > Factor fw_cfg_init_mem_internal() out of fw_cfg_init_mem_wide(). > In fw_cfg_init_mem_wide(), assert DMA arguments are provided. > Callers without DMA have to use the fw_cfg_init_mem() helper. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/nvram/fw_cfg.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) Fine for me, Reviewed-by: Zhao Liu