From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AADD201266 for ; Fri, 9 May 2025 09:09:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746781762; cv=none; b=ldi0c93YZrm3u4mfNLr8ceUet0j9t0Al9c3r1OGd7GEfIJaibo8SKmq09ko0vPQZqXqsDbtDzqry/98SgVNH2kp0kFNFUx28nvWkS8pk3M/RgZ8pYddt92w6qOGljl9mW4jof8tbnIAqpQrJJCRu87PAa6T24k5Ut7FAsisldU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746781762; c=relaxed/simple; bh=5oAxwranscwqB3GHDqmAi9ptxiiQwuBPM52/1nXSzK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pjI08PNn6csi8wkDbnAhSHZ8r3iaqrEFg1GP2BkfNKlXzhjOemZrYmsR4JLFTDrLwIIuA1vsbuuSs9+XujFVbYd8v4+7lGd0ayylazlIe5jupIAb0EcCRvkMrirXtT5mJ8Le7JEDRI59qzaMeL6b5BKDNQr7XfsE9yGA+FNwF7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DabOOvgf; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DabOOvgf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746781761; x=1778317761; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=5oAxwranscwqB3GHDqmAi9ptxiiQwuBPM52/1nXSzK0=; b=DabOOvgf0q3OELyZr77GX7rBNgRTtn6CmRoyGTHzvSgiA9t2rBJZAIK9 GbW+YmTfNf4bOgn2Nckpuq03+ykXu3jLJib7uzT2m3ZSpnE4f6heFgbp3 OUU1fiRyVhspkvZ5qPl5DtspBuiOpuJ1XQWnVQWhPHzuE/OJgc2xj0Vxx 6qFVbHNeoh/YJRkxSrlOt0O0b+ZlncmnunFbfTTJQGFviaxfL3bpXzcHd VHNonRnHb+0m7UBRt7NApoBKscsfGFm6mxndot7Rrb/BMlmnKgZHf+QiH Eu8VAW8WYorjd+wQatLiAu6d5w8kpfdYQWmaZRjKF/FXExOu6W68MOgTf Q==; X-CSE-ConnectionGUID: KFEdzcavQGSiQMNRoRW5SA== X-CSE-MsgGUID: wpQVOOqIRaWhkuUdl6lgLg== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="58820688" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="58820688" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 02:09:20 -0700 X-CSE-ConnectionGUID: 23mZ4JMRS06K1Y55uYr9rw== X-CSE-MsgGUID: SoaA/M/dRXKbfVT6oLvAug== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="137496563" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa008.jf.intel.com with ESMTP; 09 May 2025 02:09:13 -0700 Date: Fri, 9 May 2025 17:30:15 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Igor Mammedov , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?iso-8859-1?Q?Cl=E9ment?= Mathieu--Drif , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Huacai Chen , Jason Wang Subject: Re: [PATCH v4 13/27] target/i386/cpu: Remove CPUX86State::fill_mtrr_mask field Message-ID: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-14-philmd@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250508133550.81391-14-philmd@linaro.org> On Thu, May 08, 2025 at 03:35:36PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:36 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 13/27] target/i386/cpu: Remove > CPUX86State::fill_mtrr_mask field > X-Mailer: git-send-email 2.47.1 > > The CPUX86State::fill_mtrr_mask boolean was only disabled > for the pc-q35-2.6 and pc-i440fx-2.6 machines, which got > removed. Being now always %true, we can remove it and simplify > kvm_get_msrs(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/i386/cpu.h | 3 --- > target/i386/cpu.c | 1 - > target/i386/kvm/kvm.c | 10 +++------- > 3 files changed, 3 insertions(+), 11 deletions(-) No case found for external user use, so, Reviewed-by: Zhao Liu