From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28B2420E01B for ; Fri, 9 May 2025 09:20:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746782422; cv=none; b=J82MaS1EOhmw4KpyrFwS67VUdjk+utOM2QYXOYN5av04n6zBYhJfOf4EQ0MrdbNAeAzi/yEm0PjtFObnOmpO7mGF33MZqHkuq58JgTFpBZFPlil6C0+P7hpJwphWVRwL4CNCHwidhVfZzXGq/pt/NxXdxECXOnSPrAdpGY/BiOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746782422; c=relaxed/simple; bh=kODIGmR2DLKrgzRZSqcJHoCc3hZ1D9APKKMi5uxaGGw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eSCMUDedf2ZMU/dZDmwqD68BYbrJjKdSouOn8WW8whAiJx4k1DUR0uJZn5cWxY+GgA+GjnUITOkwm2lYTXPT7uUfAnU9bhd1qAWRslgVWfBK8wgSJtqkxC5W31DtNKsdGQjCqrB+6u+PUEFIk4osFwSxv4cjlgWyHN2Nir3vYoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=f8KrnQfP; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="f8KrnQfP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746782421; x=1778318421; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=kODIGmR2DLKrgzRZSqcJHoCc3hZ1D9APKKMi5uxaGGw=; b=f8KrnQfPu8Gg+QwBQJJgExY0/guvhKgvXPkhEYr58iYVuw9epX960oT0 7Q2/lz1AcqSRfXOVWmGuqJ/bRoZ3x7T/W+B5aCzf6kRxkQFeX3juN0R8T Z1nAPb7Fs2ZjKphQNQQUkDf7dVliR7MtzmEvaKjrz1LJrthLwpgsHVmwn iPEXnCRMz9udChCjAYBtmhTqo6cbn9DfmldI6nu/ZwnKXexIfW4G+x08P 10EcTBLTm1kaPjVDsouoDpBX4i+JH0lSfKx2zKhj0tT3jL7O4yIV11+2t UygMVfJmmuFHJVx2xaJ/dS8iktuBOgDkyvCFKncdLRSX3r/dxokgN6QQW Q==; X-CSE-ConnectionGUID: xWGH4IVYSMGO9OTx8DP+Ag== X-CSE-MsgGUID: NiqIIA4oTJ2MgM/tHxMmMA== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="59266544" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="59266544" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 02:20:20 -0700 X-CSE-ConnectionGUID: /P8mN7A2QES7gH0E8F4SHw== X-CSE-MsgGUID: AnR6l5RYSY6VCvLDhE6wgQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="141668588" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by orviesa005.jf.intel.com with ESMTP; 09 May 2025 02:20:13 -0700 Date: Fri, 9 May 2025 17:41:15 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Igor Mammedov , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?iso-8859-1?Q?Cl=E9ment?= Mathieu--Drif , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Huacai Chen , Jason Wang , Mark Cave-Ayland Subject: Re: [PATCH v4 23/27] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field Message-ID: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-24-philmd@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250508133550.81391-24-philmd@linaro.org> On Thu, May 08, 2025 at 03:35:46PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:46 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 23/27] hw/i386/intel_iommu: Remove > IntelIOMMUState::buggy_eim field > X-Mailer: git-send-email 2.47.1 > > The IntelIOMMUState::buggy_eim boolean was only set in > the hw_compat_2_7[] array, via the 'x-buggy-eim=true' > property. We removed all machines using that array, lets > remove that property, simplifying vtd_decide_config(). > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Mark Cave-Ayland > --- > include/hw/i386/intel_iommu.h | 1 - > hw/i386/intel_iommu.c | 5 ++--- > 2 files changed, 2 insertions(+), 4 deletions(-) This property has a good name :-) Reviewed-by: Zhao Liu