From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9310028E5E3 for ; Fri, 9 May 2025 10:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746785473; cv=none; b=efviuX09fxCiar9OgS+a5PNkHasOnsRhWarlV1oq/Llrf7dv8Y8DFHHucb7pZ2VyYP9+xyAVhZOu+8xbx0LXNIKwjAFEnbna1rAhs6c//gDQCuIpg0TtoObi3dhWTpT3r2WKm02GYG1ZruA5mSTo8CNcIG+dgfaVMr8DTbqgF74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746785473; c=relaxed/simple; bh=DYzgfmr2nHUFnRtfKx2VUV7W2FkMFo4CpLIHKoL2k0I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mHLDO5o6R786b6AbAPqkEpDuNGQOizF0DWAJ9EGQcUWenfFv93YDDGzrNMVDxXo8ZKyBRpsp2TqpBr0stvUYUQvyhHigPThFlghaCrYlSxEfGMzKhtlrMCEYKVKYyB1wd4ePDR9FGv1YGommxDr2RT8I1zbEsIZz7q6kiT1zJ1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HLQeEdYs; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HLQeEdYs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746785471; x=1778321471; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=DYzgfmr2nHUFnRtfKx2VUV7W2FkMFo4CpLIHKoL2k0I=; b=HLQeEdYseJ2qq3XsUXd+M6kSGEvOTEmXD4E6m1c+02SGPv6R7t+ciVFR UB1BK8lOSZvXRijYIkNpTalTCQy9seK0Jh00hi8oF6HYDUt9ZJnIUznrq kbPvjhUM+fpsQll+SD+bjLihAH95tbvTUWebMk9zitgcKbFoG121ynExK D6ET+n+aMFNWZYJWLWur3l0xLi2xCWKx96BGg9sKydK7c8ASlaogn4KGz 9XW0LhXu5gdBD0m0OZUcZbfNoSIC8qcOl2TLDQ3RotFsfoQGTOscjfk75 7NsuG0WSdhDuq+Q4akLCp6kF6Hm/dIrGcdoj2ebzHubupRppUaPzeemXT g==; X-CSE-ConnectionGUID: l1sGLwSJQaCMxsupBKJQlQ== X-CSE-MsgGUID: n/IlRBxGSYOlJbhljiMsdA== X-IronPort-AV: E=McAfee;i="6700,10204,11427"; a="66013416" X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="66013416" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2025 03:11:10 -0700 X-CSE-ConnectionGUID: HKEkuJfoTV22rXlvJht/zw== X-CSE-MsgGUID: 34wmXNVFQ0SpQaxijdq0mQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,274,1739865600"; d="scan'208";a="137577882" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by fmviesa009.fm.intel.com with ESMTP; 09 May 2025 03:11:02 -0700 Date: Fri, 9 May 2025 18:32:05 +0800 From: Zhao Liu To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , kvm@vger.kernel.org, Sergio Lopez , Gerd Hoffmann , Peter Maydell , Laurent Vivier , Jiaxun Yang , Yi Liu , "Michael S. Tsirkin" , Eduardo Habkost , Marcel Apfelbaum , Alistair Francis , Daniel Henrique Barboza , Marcelo Tosatti , qemu-riscv@nongnu.org, Weiwei Li , Amit Shah , Yanan Wang , Helge Deller , Palmer Dabbelt , Ani Sinha , Igor Mammedov , Fabiano Rosas , Paolo Bonzini , Liu Zhiwei , =?iso-8859-1?Q?Cl=E9ment?= Mathieu--Drif , qemu-arm@nongnu.org, =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Huacai Chen , Jason Wang , Mark Cave-Ayland Subject: Re: [PATCH v4 24/27] hw/intc/ioapic: Remove IOAPICCommonState::version field Message-ID: References: <20250508133550.81391-1-philmd@linaro.org> <20250508133550.81391-25-philmd@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250508133550.81391-25-philmd@linaro.org> On Thu, May 08, 2025 at 03:35:47PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:47 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 24/27] hw/intc/ioapic: Remove IOAPICCommonState::version > field > X-Mailer: git-send-email 2.47.1 > > The IOAPICCommonState::version integer was only set > in the hw_compat_2_7[] array, via the 'version=0x11' > property. We removed all machines using that array, > lets remove that property, simplify by only using the > default version (defined as IOAPIC_VER_DEF). > > For the record, this field was introduced in commit > 20fd4b7b6d9 ("x86: ioapic: add support for explicit EOI"): > > > Some old Linux kernels (upstream before v4.0), or any released RHEL > > kernels has problem in sending APIC EOI when IR is enabled. > > Meanwhile, many of them only support explicit EOI for IOAPIC, which > > is only introduced in IOAPIC version 0x20. This patch provide a way > > to boost QEMU IOAPIC to version 0x20, in order for QEMU to correctly > > receive EOI messages. > > > > Without boosting IOAPIC version to 0x20, kernels before commit > > d32932d ("x86/irq: Convert IOAPIC to use hierarchical irqdomain > > interfaces") will have trouble enabling both IR and level-triggered > > interrupt devices (like e1000). > > > > To upgrade IOAPIC to version 0x20, we need to specify: > > > > -global ioapic.version=0x20 > > > > To be compatible with old systems, 0x11 will still be the default > > IOAPIC version. Here 0x11 and 0x20 are the only versions to be > > supported. > > > > One thing to mention: this patch only applies to emulated IOAPIC. It > > does not affect kernel IOAPIC behavior. > > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Mark Cave-Ayland > --- > hw/intc/ioapic_internal.h | 3 +-- > hw/intc/ioapic.c | 18 ++---------------- > hw/intc/ioapic_common.c | 2 +- > 3 files changed, 4 insertions(+), 19 deletions(-) Reviewed-by: Zhao Liu