From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1993251783 for ; Tue, 29 Apr 2025 17:16:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946971; cv=none; b=heJFrF5qLOdJYsXTxG+65hoBlSwvvXfbLQkGn/Lu+IRwsZ/DxwibDiUNeMdseUhuo0Zix8y7iG2RybFmlS1UmuFo9mbdqB+2w5ADhUcl0wiLScGGP7Vt3ZCeTgw1aYV8sG5G3P3dIlFXt0CAVgT+ri7cBf/gQEjmAeUyb/N++oU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745946971; c=relaxed/simple; bh=7RreN82ADxQheU4kFlw/w2oqpyMciZ+CVjUxQ6PBPwM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=TVep+NfO50q6sRWgaLIdpCVAyR9hRtl3xSChhriL77VL+PPGmsc/JpIX+fba3tO6oiWnV7NNO4/7Psl0osvJSxiK0asWwvVcDX+Uao3brv0nhs+iv97mTNEno87M6r6mEcqh59qZ3LRynV5qjbaQc/RC+R3P6Mly/OSID7Lb2BU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bXu2MwBv; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bXu2MwBv" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-739525d4d7bso4608662b3a.2 for ; Tue, 29 Apr 2025 10:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1745946969; x=1746551769; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Rgg+yk6TbZkrf50JyHWvmpVTzHV3/+x6Tw/18oxSDfg=; b=bXu2MwBvNAlO8nBWeuN1zsR8XdKxHPAS6C4JsEKAfRG8mQZsVRB2ZvJQNFngWHiPwq 8f86r3A/fz04l1GZ+hapVDWQEmt6OYRqjI93ZWfmBo5mZafkTTyguzbMUMh6FEwSUVDA eqRZ/N+ZaBpljcdcw7+D0/pOvoBI9lSdmbOj1unt6azWF6zHVGyihAOOs0ZMQyeMS3VU aa9udOfB9etW1XjNq8Pfd2oGUIXW9T2gAfRL8iZ6Ork//pkjxlpWhPKyxOlJ8QHyrW// jHLuWYLJ3GreKCV6b+WDvPT+KjUaGOvDWeMorKwUnl8XYpjSJCIJL6nLQbJ+loEn5Eqk 5qtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745946969; x=1746551769; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rgg+yk6TbZkrf50JyHWvmpVTzHV3/+x6Tw/18oxSDfg=; b=P6opbDbasBYOIhNHXdOzURj05cteFfsxXIxO3/q8IU7bkmlU+hIbEdk+jZ7DAc1ai+ XxX9lA850MUtOd6n2qZtSHqSN9e+c0Fm3RQOANqnK5fEL+AUqw4a4GeyEm50AGZoWzxN n5+/5W1iRrlOHzyOHOHMZfepQR7POJi8GHyVoEdSh7jgPynq6sOoMoyrWjkQiaphd2ti r/cxLrrEB0eAGolnNJtScyibviQLBSZOD9RBzMW7ggLdDAxahlMxONT/cfDJ6Nd9ZzVE UCwh0Q/a4q1HBjrUJ/gySbCQH9S+8Z5e5qcEE5NO9Ov9taRI1s8Bsk60g+n5WvL3HbfV JFKw== X-Forwarded-Encrypted: i=1; AJvYcCUaMfZoa0GBtI/NYJ44SCunfckBQVjf7W/g+TH7MJMAnkpy0GtQWpB+dDzHm8o7Ixjjh5c=@vger.kernel.org X-Gm-Message-State: AOJu0YzCaw3l0ciRmYJ5IMx1nld+/SkNjqiXprSo/fEHC1F9JDix2XpC QXM4xjqdsluX154+hEEUsjYs3yEuxTb0DnglA2cCt5gw+odD7FPd7iLWvZq5EThVpOSqzVTfsZV +nA== X-Google-Smtp-Source: AGHT+IHnBsjJ2lHlGsUa7wfkhDlYoD1/JVsa8FRjr2Yl8wXuoJ1y4aqVn3VINpRePPFLsbZG8fx/ncC1Rgo= X-Received: from pfbkq14.prod.google.com ([2002:a05:6a00:4b0e:b0:73e:1925:b94b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:1814:b0:736:5f75:4a44 with SMTP id d2e1a72fcca58-74038abcf18mr88925b3a.22.1745946969011; Tue, 29 Apr 2025 10:16:09 -0700 (PDT) Date: Tue, 29 Apr 2025 10:16:07 -0700 In-Reply-To: <20250429144631.GI4198@noisy.programming.kicks-ass.net> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250414113754.172767741@infradead.org> <7vfbchsyhlsvdl4hszdtmapdghw32nrj2qd652f3pjzg3yb6vn@po3bsa54b6ta> <20250415074421.GI5600@noisy.programming.kicks-ass.net> <20250416083859.GH4031@noisy.programming.kicks-ass.net> <20250426100134.GB4198@noisy.programming.kicks-ass.net> <20250429100919.GH4198@noisy.programming.kicks-ass.net> <20250429144631.GI4198@noisy.programming.kicks-ass.net> Message-ID: Subject: Re: [PATCH 3/6] x86/kvm/emulate: Avoid RET for fastops From: Sean Christopherson To: Peter Zijlstra Cc: Josh Poimboeuf , x86@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, pawan.kumar.gupta@linux.intel.com, pbonzini@redhat.com, ardb@kernel.org, kees@kernel.org, Arnd Bergmann , gregkh@linuxfoundation.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, samitolvanen@google.com, ojeda@kernel.org, shuah@kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Apr 29, 2025, Peter Zijlstra wrote: > On Tue, Apr 29, 2025 at 07:05:35AM -0700, Sean Christopherson wrote: > > On Tue, Apr 29, 2025, Peter Zijlstra wrote: > > > On Mon, Apr 28, 2025 at 10:13:31AM -0700, Sean Christopherson wrote: > > > > On Sat, Apr 26, 2025, Peter Zijlstra wrote: > > > > > On Wed, Apr 16, 2025 at 10:38:59AM +0200, Peter Zijlstra wrote: > > > > > > > > > > > Yeah, I finally got there. I'll go cook up something else. > > > > > > > > > > Sean, Paolo, can I once again ask how best to test this fastop crud? > > > > > > > > Apply the below, build KVM selftests, > > > > > > Patch applied, my own hackery applied, host kernel built and booted, > > > foce_emulation_prefix set, but now I'm stuck at this seemingly simple > > > step.. > > > > > > $ cd tools/testing/selftests/kvm/ > > > $ make > > > ... metric ton of fail ... > > > > > > Clearly I'm doing something wrong :/ > > > > Did you install headers in the top level directory? I.e. make headers_install. > > No, of course not :-) I don't use the top directory to build anything, > ever. > > All my builds are into build directories, using make O=foo. This allows > me to do parallel builds for multiple architectures etc. Also, much > easier to wipe a complete build directory than it is to clean out the > top level dir. FWIW, you can do the same with KVM selftests (and presumably others?), although the syntax is kinda weird (no idea why lib.mk uses OUTPUT instead of O). E.g. to build KVM selftests in $HOME/build/selftests/x86 make O=$HOME/build/selftests/x86 headers_install make OUTPUT=$HOME/build/selftests/x86