Re: [PATCH 4/5] vfio: Introduce vfio_device_ops.get_unmapped_area hook

Jason Gunthorpe
2025-06-17T23:00:35Z

On Tue, Jun 17, 2025 at 04:01:11PM -0400, Peter Xu wrote:

> > So what is VFIO doing that requires CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP?
>
> It's the fallback part for vfio device, not vfio_pci device. vfio_pci
> device doesn't need this special treatment after moving to the new helper
> because that hides everything. vfio_device still needs it.
>
> So, we have two ops that need to be touched to support this:
>
> vfio_device_fops
> vfio_pci_ops
>
> For the 1st one's vfio_device_fops.get_unmapped_area(), it'll need its own
> fallback which must be mm_get_unmapped_area() to keep the old behavior, and
> that was defined only if CONFIG_MMU.

OK, CONFIG_MMU makes a little bit of sense

> IOW, if one day file_operations.get_unmapped_area() would allow some other
> retval to be able to fallback to the default (mm_get_unmapped_area()), then
> we don't need this special ifdef. But now it's not ready for that..

That can't be fixed with a config, the logic in vfio_device_fops has
to be

if (!device->ops->get_unmapped_area()
return .. do_default thing..

return device->ops->get_unmapped()

Has nothing to do with CONFIG_ARCH_SUPPORTS_HUGE_PFNMAP, there are
more device->ops that just PCI.

If you do the API with an align/order argument then the default
behavior should happen when passing PAGE_SIZE.

Jason