From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7701018DF6E for ; Fri, 11 Jul 2025 08:52:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752223943; cv=none; b=fMm+RplecvZY3BlCQ+Aral5bI0SJF/x8mV+/agIXx4VnpxuY0uVkG+FvogMQCz2Nob4WO7GLlKgstWK0johPhTRfHl+ZbqFYhBYFKhKHGqLXtqin8j0lmUgLmLXCJfFc7O6yn23oj1sWDsz2wQ1DblNIklL9f/05yOCZmJub7zw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752223943; c=relaxed/simple; bh=vA5QebrlQcJNv1a91wNZgep7yhevRHrP9idpLiS40Xo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BBnej/Hm2t4jdZ0TiSde0R1XSvr0nL8qfhvMWAU/e2ED/BqgJvsyQw8gWwvy4NJzpMH3qrwEzef0Ebve0WgohEkAQr1BNl+jAWrEfv6hE90zxSxy5+zArRHMg7FCa1OZnlSTsDUGU2EbOz1Z4KuKFUOxt2tiWdn9FoG0To85GdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch; spf=none smtp.mailfrom=ffwll.ch; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b=WayrNgeu; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ffwll.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="WayrNgeu" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-454ac069223so15646035e9.1 for ; Fri, 11 Jul 2025 01:52:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1752223940; x=1752828740; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=8derBKGkrTEyUk4H7Vgf14bpDSTC61VSwEgs7ngR2I8=; b=WayrNgeuzVnNtLgoFyk68AfB/mWNap7Paw0374Cm3++7WYeX4EPQYhdnR496eBmDiX SSkBmSmcLpxomzISkEVzpjVGZUmxfsRGWghL6GBSxl5+wyKczrjxAxF/uOOrqfZuWZcm hkJOeOqTQlfrJsIs4acWlMqb2eSdrRykMmF2k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752223940; x=1752828740; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8derBKGkrTEyUk4H7Vgf14bpDSTC61VSwEgs7ngR2I8=; b=jZW4j07TuWIYK8aN2JXyMoec0z6XHUXHKEaq4QZqFE1MNlzwh6t7eAwF4NrwkuXVzo zBlXHxvOAj5uk+oHjRxQ04scWjjX2uLJNK8l5/aR738CWDOK2crdKo1ExBkFIplPX6PI Jdjh4Zw49gY0UhDCFggUf4Lxffgx8opW3MAeoRJqu5Pa7gQRzFHeQSNy+02tNjIaAeZs QqFD1sCllMwlRHSHLi2LI2TesUcg8aLUHPJHLKS1LV4LO+TkqSSr78aEZjJVr4wtNqrb PlXnyEVB6s24yJ1cn9wjRKbVKwwJYv2A0lQYHWac+EnR67eAEiH/1aAUwmfQxQukXkcK rXgQ== X-Forwarded-Encrypted: i=1; AJvYcCWzhW3v0/0AVrwlzxbU9t7Sa+lRoPHfEhGeVmdJoNWMpYu2cCCr/ebHN4a7pnG2KTNqgcc=@vger.kernel.org X-Gm-Message-State: AOJu0YzfoR4f1veXPh7AHJI8cWNCuJFbY2GZ7PdrFpqBKz+XkOnN4XiZ KBOvu02bB8THpkijFEm6BKWn2T4UhTjA8oG3Y8HvdbhwwZhpkAQtK8sqrpPDNxFcQ7M= X-Gm-Gg: ASbGncs/vgNfWPmQBXlTwRea6tN50STbJ+8DI1mlr3Ylzy4s/X6lM1wI5qnAUCZyMER 2a+KzTJxPN5j8M9vc3A0KoVGpnKMLInlGUYN4QAakYahoOFcdia9B7ioAAtqPvtj/k1DTwNyb2y z3odc5A7lN8mmyQ5+o/d33Uu70t1JcCdyHwwASkXYsF0y/CsK/QT08TYKfrGGGiKBgXa87ovhIk fMlQGO6kzXrOiMqJ6AYUIh+jSPBYuDxS1kISOXYHF43+eW+0RxPFWaG2nh+rSBi8f2sgJ/NBDQP DIhCnsRDBd9At0nuRgusmy7ZwlSA/G2WjOEIe8VScUSSz4Hcm+jLnh+N6nlOKK1wjmIieuLfqBR biJ53tm2izozW+ie5jxFXQ84rKMuoE1xgKvsaa8WwduE8 X-Google-Smtp-Source: AGHT+IHb717NClqAG1xifIUSeLJK08Q/iqQmZrgvVQp+OyvdWt/usHRp8NPbh9G8VPNNxhojCPLDSQ== X-Received: by 2002:a05:600c:8207:b0:43b:c857:e9d7 with SMTP id 5b1f17b1804b1-454e2addac7mr22372895e9.5.1752223939638; Fri, 11 Jul 2025 01:52:19 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:5485:d4b2:c087:b497]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454dd540b52sm40898565e9.28.2025.07.11.01.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 01:52:19 -0700 (PDT) Date: Fri, 11 Jul 2025 10:52:17 +0200 From: Simona Vetter To: Sean Christopherson Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Paolo Bonzini , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Kevin Loughlin , Tom Lendacky , Kai Huang , Ingo Molnar , Zheyun Shen , Mingwei Zhang , Francesco Lavra Subject: Re: [PATCH v3 1/8] drm/gpu: Remove dead checks on wbinvd_on_all_cpus()'s return value Message-ID: Mail-Followup-To: Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Paolo Bonzini , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Kevin Loughlin , Tom Lendacky , Kai Huang , Ingo Molnar , Zheyun Shen , Mingwei Zhang , Francesco Lavra References: <20250522233733.3176144-1-seanjc@google.com> <20250522233733.3176144-2-seanjc@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250522233733.3176144-2-seanjc@google.com> X-Operating-System: Linux phenom 6.12.30-amd64 On Thu, May 22, 2025 at 04:37:25PM -0700, Sean Christopherson wrote: > Remove the checks and associated pr_err() on wbinvd_on_all_cpus() failure, > as the helper has unconditionally returned 0/success since commit > caa759323c73 ("smp: Remove smp_call_function() and on_each_cpu() return > values"). > > Signed-off-by: Sean Christopherson I guess this'll all land through x86 trees, for that on this and the patch from Peter to adjust the module exports to include drm and i915: Acked-by: Simona Vetter Cheers, Sima > --- > drivers/gpu/drm/drm_cache.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c > index 7051c9c909c2..ea1d2d5d2c66 100644 > --- a/drivers/gpu/drm/drm_cache.c > +++ b/drivers/gpu/drm/drm_cache.c > @@ -93,8 +93,7 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages) > return; > } > > - if (wbinvd_on_all_cpus()) > - pr_err("Timed out waiting for cache flush\n"); > + wbinvd_on_all_cpus(); > > #elif defined(__powerpc__) > unsigned long i; > @@ -139,8 +138,7 @@ drm_clflush_sg(struct sg_table *st) > return; > } > > - if (wbinvd_on_all_cpus()) > - pr_err("Timed out waiting for cache flush\n"); > + wbinvd_on_all_cpus(); > #else > WARN_ONCE(1, "Architecture has no drm_cache.c support\n"); > #endif > @@ -172,8 +170,7 @@ drm_clflush_virt_range(void *addr, unsigned long length) > return; > } > > - if (wbinvd_on_all_cpus()) > - pr_err("Timed out waiting for cache flush\n"); > + wbinvd_on_all_cpus(); > #else > WARN_ONCE(1, "Architecture has no drm_cache.c support\n"); > #endif > -- > 2.49.0.1151.ga128411c76-goog > -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch