[PATCH] treewide: Fix typo "notifer"

[PATCH] treewide: Fix typo "notifer"

[WangYuli]

There are some spelling mistakes of 'notifer' in comments which
should be 'notifier'.

Fix them and add it to scripts/spelling.txt.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/x86/kvm/i8254.c                                        | 4 ++--
 drivers/cxl/core/mce.h                                      | 2 +-
 drivers/gpu/drm/xe/xe_vm_types.h                            | 2 +-
 drivers/net/ethernet/marvell/mvneta.c                       | 2 +-
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
 drivers/tty/serial/8250/8250_dw.c                           | 2 +-
 include/xen/xenbus.h                                        | 2 +-
 scripts/spelling.txt                                        | 1 +
 8 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 739aa6c0d0c3..9ff55112900a 100644
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
@@ -641,7 +641,7 @@ static void kvm_pit_reset(struct kvm_pit *pit)
 	kvm_pit_reset_reinject(pit);
 }
 
-static void pit_mask_notifer(struct kvm_irq_mask_notifier *kimn, bool mask)
+static void pit_mask_notifier(struct kvm_irq_mask_notifier *kimn, bool mask)
 {
 	struct kvm_pit *pit = container_of(kimn, struct kvm_pit, mask_notifier);
 
@@ -694,7 +694,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 
 	pit_state->irq_ack_notifier.gsi = 0;
 	pit_state->irq_ack_notifier.irq_acked = kvm_pit_ack_irq;
-	pit->mask_notifier.func = pit_mask_notifer;
+	pit->mask_notifier.func = pit_mask_notifier;
 
 	kvm_pit_reset(pit);
 
diff --git a/drivers/cxl/core/mce.h b/drivers/cxl/core/mce.h
index ace73424eeb6..ca272e8db6c7 100644
--- a/drivers/cxl/core/mce.h
+++ b/drivers/cxl/core/mce.h
@@ -7,7 +7,7 @@
 
 #ifdef CONFIG_CXL_MCE
 int devm_cxl_register_mce_notifier(struct device *dev,
-				   struct notifier_block *mce_notifer);
+				   struct notifier_block *mce_notifier);
 #else
 static inline int
 devm_cxl_register_mce_notifier(struct device *dev,
diff --git a/drivers/gpu/drm/xe/xe_vm_types.h b/drivers/gpu/drm/xe/xe_vm_types.h
index 1979e9bdbdf3..0ca27579fd1f 100644
--- a/drivers/gpu/drm/xe/xe_vm_types.h
+++ b/drivers/gpu/drm/xe/xe_vm_types.h
@@ -259,7 +259,7 @@ struct xe_vm {
 		 * up for revalidation. Protected from access with the
 		 * @invalidated_lock. Removing items from the list
 		 * additionally requires @lock in write mode, and adding
-		 * items to the list requires either the @userptr.notifer_lock in
+		 * items to the list requires either the @userptr.notifier_lock in
 		 * write mode, OR @lock in write mode.
 		 */
 		struct list_head invalidated;
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 147571fdada3..ee4696600146 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -4610,7 +4610,7 @@ static int mvneta_stop(struct net_device *dev)
 		/* Inform that we are stopping so we don't want to setup the
 		 * driver for new CPUs in the notifiers. The code of the
 		 * notifier for CPU online is protected by the same spinlock,
-		 * so when we get the lock, the notifer work is done.
+		 * so when we get the lock, the notifier work is done.
 		 */
 		spin_lock(&pp->lock);
 		pp->is_stopped = true;
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index b94c3619526c..bcd56c7c4e42 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -8313,7 +8313,7 @@ struct brcmf_cfg80211_info *brcmf_cfg80211_attach(struct brcmf_pub *drvr,
 	cfg->d11inf.io_type = (u8)io_type;
 	brcmu_d11_attach(&cfg->d11inf);
 
-	/* regulatory notifer below needs access to cfg so
+	/* regulatory notifier below needs access to cfg so
 	 * assign it now.
 	 */
 	drvr->config = cfg;
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 1902f29444a1..6d9af6417620 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -392,7 +392,7 @@ static void dw8250_set_termios(struct uart_port *p, struct ktermios *termios,
 	rate = clk_round_rate(d->clk, newrate);
 	if (rate > 0) {
 		/*
-		 * Note that any clock-notifer worker will block in
+		 * Note that any clock-notifier worker will block in
 		 * serial8250_update_uartclk() until we are done.
 		 */
 		ret = clk_set_rate(d->clk, newrate);
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index 3f90bdd387b6..00b84f2e402b 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -180,7 +180,7 @@ int xenbus_printf(struct xenbus_transaction t,
  * sprintf-style type string, and pointer. Returns 0 or errno.*/
 int xenbus_gather(struct xenbus_transaction t, const char *dir, ...);
 
-/* notifer routines for when the xenstore comes up */
+/* notifier routines for when the xenstore comes up */
 extern int xenstored_ready;
 int register_xenstore_notifier(struct notifier_block *nb);
 void unregister_xenstore_notifier(struct notifier_block *nb);
diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index c9a6df5be281..d824c4b17390 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -1099,6 +1099,7 @@ notication||notification
 notications||notifications
 notifcations||notifications
 notifed||notified
+notifer||notifier
 notity||notify
 notfify||notify
 nubmer||number
-- 
2.50.0

Re: [PATCH] treewide: Fix typo "notifer"

[Greg KH]

On Tue, Jul 15, 2025 at 03:12:45PM +0800, WangYuli wrote:
> There are some spelling mistakes of 'notifer' in comments which
> should be 'notifier'.
> 
> Fix them and add it to scripts/spelling.txt.
> 
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/x86/kvm/i8254.c                                        | 4 ++--
>  drivers/cxl/core/mce.h                                      | 2 +-
>  drivers/gpu/drm/xe/xe_vm_types.h                            | 2 +-
>  drivers/net/ethernet/marvell/mvneta.c                       | 2 +-
>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
>  drivers/tty/serial/8250/8250_dw.c                           | 2 +-
>  include/xen/xenbus.h                                        | 2 +-
>  scripts/spelling.txt                                        | 1 +
>  8 files changed, 9 insertions(+), 8 deletions(-)

Please break this up into one-patch-per-subsystem, like is required for
things like this.

thanks,

greg k-h

Re: [PATCH] treewide: Fix typo "notifer"

[WangYuli]

[-- Attachment #1.1.1: Type: text/plain, Size: 1037 bytes --]

Hi greg k-h,

On 2025/7/15 15:22, Greg KH wrote:
> Please break this up into one-patch-per-subsystem, like is required for
> things like this.
>
> thanks,
>
> greg k-h
>
Honestly, I've always been quite unsure how to handle situations like this.

It seems every subsystem maintainer has different preferences. I've 
previously encountered some maintainers who suggested I split such 
patches by subsystem so each maintainer could merge them into their tree 
without contention. However, other ones have argued that fixing spelling 
errors isn't worth multiple commits, claiming it would create chaos.

Since I genuinely discover these spelling errors by chance each time, 
and to avoid giving the impression I'm "spamming" the kernel tree for 
some ulterior motive, I've opted to squash them into a single commit.

That said, I personally don't have any strong feelings or preferences on 
this matter. Since you've requested it, I'll go ahead and split it up 
and send a v2 patchset.

Thanks,

-- 
WangYuli

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 645 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

Re: [PATCH] treewide: Fix typo "notifer"

[Andy Shevchenko]

On Tue, Jul 15, 2025 at 03:53:18PM +0800, WangYuli wrote:
> On 2025/7/15 15:22, Greg KH wrote:
> > Please break this up into one-patch-per-subsystem, like is required for
> > things like this.

> Honestly, I've always been quite unsure how to handle situations like this.
> 
> It seems every subsystem maintainer has different preferences.

True, but at least if you see the specific driver in the MAINTAINERS, split for
that driver. For instance, 8250_dw in this patch is exactly the case.

> I've previously encountered some maintainers who suggested I split such
> patches by subsystem so each maintainer could merge them into their tree
> without contention. However, other ones have argued that fixing spelling
> errors isn't worth multiple commits, claiming it would create chaos.

> Since I genuinely discover these spelling errors by chance each time, and to
> avoid giving the impression I'm "spamming" the kernel tree for some ulterior
> motive, I've opted to squash them into a single commit.
> 
> That said, I personally don't have any strong feelings or preferences on
> this matter. Since you've requested it, I'll go ahead and split it up and
> send a v2 patchset.

-- 
With Best Regards,
Andy Shevchenko