From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6F2523A99E for ; Thu, 24 Jul 2025 22:35:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753396514; cv=none; b=rxCzeOxlmUXCn3Os2DYiF0Wcl4OuQe+xZfJlH4RgFZ31RhoYLnb18HiqmMZOzoAFzOKuHM+QFVeuKCM/meP5puAaQ3BQh5meK7vxxwUzElEsoImgwffQqjluMq+RXiVli87w6fGvuvoLbdxu5vMXtlJ7rfGcVAr2Mk+lkSUBkK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753396514; c=relaxed/simple; bh=r5SzxM2o3YDT3MM6mgAjKy7bmQnwJvTgu0zUuOAYsqk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=dIq+1+GEOswgpNkmu8u6XceAMXreotQ6dSYfUxeOaGL4LZtiUfDczEoVWf/L24LHONhE5dnnjSbUr73X2szV8LCOsHyN0MgTW7GENgutRLTAi8AN+xDgdb2PHwdIz+2Z4fw/CxhnkGObPOaSWq8WV6xLQXwgqAOhXXNy8gqNcD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sIiQ3nzq; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sIiQ3nzq" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-313c3915345so2174421a91.3 for ; Thu, 24 Jul 2025 15:35:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753396512; x=1754001312; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=PFqcIXETNfo8GzEn6hB6Ya7g4JGq3t1ggKMLi3jyaSw=; b=sIiQ3nzqahZJBdJcoBBuhDt5ZLMFJokPPT1WsQ7kl/6WE3atgZD9D2TspEBYmVtsCt +XuYU4ZvwJVaXCSFufs/fosO6Syv+fVqkepM2fuzQe/gF5DO51lChg9O9qBsxG6Wuw9f QARv9PnzKPpbErLpJLmcvfvkggnl0OtGvunnXM0OEgZwKtWIr7DSeJld/mk3mdsZc8nd FPXsceFEGoLNhNjd4lBJmTVnAY1z6NlZ+XfzGrqDKv3McNciYjHedouL3TB0ayn4tJGr esewq65DmPBQN2QtZ9RJjH80S1tCLyVpOmNyjif7QYLUQ+uvxskShOv0AU/yxpe78TuM SDqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753396512; x=1754001312; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PFqcIXETNfo8GzEn6hB6Ya7g4JGq3t1ggKMLi3jyaSw=; b=PFA3m1dWg+7KHBdiUi5RFJ52r/KZEoxW6NTOAHta3k+I2ufDhwPm0phKyRWGZTJi0G K6arfCtncBCq5Hs9biagkJ+VCDcRp1YBBKsg/aT6Xem8uoEKrnpDAhAacttUYNQDfZ54 C/KgJiYH+SNbWl+3LA+tMhj+U3zxEzaLUjIFuOJvw85tx3LPdpXARw9MRrVU3yqEYBE1 9d3QGLxY3irFmE5Uv4OoWsf/YeU4Enk+/6RPMpvppwh72/3viPP0/iSlTxFey9H6rZ/z yvH5zG/7ZWTT4UfC2vUublAklIbml3R95ZCe4GIsIPsvK/jcbb2fFrxzwZ5yfasByn9L izkA== X-Forwarded-Encrypted: i=1; AJvYcCXD6SX0t/yfMeDol2kwlzPdj0kXJoXGRE1l878Y0mstLBTuBF5qGjUl58h0HApgkanpVec=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1iHhRt2mgZs+LPrSaP6NysRl9gdlrf6wLBl9/aLOYKE99/pNm ATZVACTMc2On3J8Bwe4M+Xi0IC44jeO44pXc1A/MScu0QX2eBRRnH5zVviNnCra3nRLi/E7Msjw wbRBaRQ== X-Google-Smtp-Source: AGHT+IHuVeukYr6lWMjvsRkjvN6oFU8CQPzldpvdB/N9yisxOdKopu5kObxNBBArWTOrC8zyhULTFJAICEM= X-Received: from pjbsu16.prod.google.com ([2002:a17:90b:5350:b0:301:1bf5:2f07]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3809:b0:308:7270:d6ea with SMTP id 98e67ed59e1d1-31e50855de1mr10081085a91.30.1753396511877; Thu, 24 Jul 2025 15:35:11 -0700 (PDT) Date: Thu, 24 Jul 2025 15:35:10 -0700 In-Reply-To: <3f337306-e79f-4ac7-bb86-60b88b262e88@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250723104714.1674617-1-tabba@google.com> <20250723104714.1674617-5-tabba@google.com> <3f337306-e79f-4ac7-bb86-60b88b262e88@intel.com> Message-ID: Subject: Re: [PATCH v16 04/22] KVM: x86: Select TDX's KVM_GENERIC_xxx dependencies iff CONFIG_KVM_INTEL_TDX=y From: Sean Christopherson To: Xiaoyao Li Cc: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="us-ascii" On Wed, Jul 23, 2025, Xiaoyao Li wrote: > On 7/23/2025 6:46 PM, Fuad Tabba wrote: > > From: Sean Christopherson > > > > Select KVM_GENERIC_PRIVATE_MEM and KVM_GENERIC_MEMORY_ATTRIBUTES directly > > from KVM_INTEL_TDX, i.e. if and only if TDX support is fully enabled in > > KVM. There is no need to enable KVM's private memory support just because > > the core kernel's INTEL_TDX_HOST is enabled. > > > > Signed-off-by: Sean Christopherson > > Signed-off-by: Fuad Tabba > > Reviewed-by: Xiaoyao Li > > > --- > > arch/x86/kvm/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig > > index 402ba00fdf45..13ab7265b505 100644 > > --- a/arch/x86/kvm/Kconfig > > +++ b/arch/x86/kvm/Kconfig > > @@ -95,8 +95,6 @@ config KVM_SW_PROTECTED_VM > > config KVM_INTEL > > tristate "KVM for Intel (and compatible) processors support" > > depends on KVM && IA32_FEAT_CTL > > - select KVM_GENERIC_PRIVATE_MEM if INTEL_TDX_HOST > > - select KVM_GENERIC_MEMORY_ATTRIBUTES if INTEL_TDX_HOST > > help > > Provides support for KVM on processors equipped with Intel's VT > > extensions, a.k.a. Virtual Machine Extensions (VMX). > > @@ -135,6 +133,8 @@ config KVM_INTEL_TDX > > bool "Intel Trust Domain Extensions (TDX) support" > > default y > > depends on INTEL_TDX_HOST > > + select KVM_GENERIC_PRIVATE_MEM > > + select KVM_GENERIC_MEMORY_ATTRIBUTES > > I had a similar patch internally, while my version doesn't select > KVM_GENERIC_MEMORY_ATTRIBUTES here since it's selected by > KVM_GENERIC_PRIVATE_MEM. > > Anyway, next patch clean it up as well. Yeah, I saw this oddity when writing this patch, and decided it'd be easier to just deal with it in the next patch.