kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Matlack <dmatlack@google.com>
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, kvm@vger.kernel.org,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [awilliam-vfio:next 5/37] tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
Date: Thu, 28 Aug 2025 16:43:48 +0000	[thread overview]
Message-ID: <aLCHRCKsPTFQfTOD@google.com> (raw)
In-Reply-To: <202508280918.rFRyiLEU-lkp@intel.com>

On 2025-08-28 09:18 AM, kernel test robot wrote:
> tree:   https://github.com/awilliam/linux-vfio.git next
> head:   9f3acb3d9a1872e2fa36af068ca2e93a8a864089
> commit: 292e9ee22b0adad49c9a6f63708988e32c007da6 [5/37] selftests: Create tools/testing/selftests/vfio
> config: i386-buildonly-randconfig-001-20250828 (https://download.01.org/0day-ci/archive/20250828/202508280918.rFRyiLEU-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250828/202508280918.rFRyiLEU-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508280918.rFRyiLEU-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files
> >> tools/testing/selftests/vfio/Makefile: warning: ignored by one of the .gitignore files

The warning is that tools/testing/selftests/vfio/.gitignore and
tools/testing/selftests/vfio/Makefile are both ignored by an existing
.gitignore file. That .gitignore file is
tools/testing/selftests/vfio/.gitignore:

  $ cat tools/testing/selftests/vfio/.gitignore
  # SPDX-License-Identifier: GPL-2.0-only
  *
  !/**/
  !*.c
  !*.h
  !*.S
  !*.sh

This .gitignore is designed to ignore everything but directories, .c,
.h. .S, and .sh files. One-off files can be added with git add --force
and then git will track any changes to those files automatically going
forward (even though they technically match the .gitignore file).

I stole this approach from the KVM selftests but it looks like they hit
the same warning and decided to add their one-off files to their
.gitignore file to squash the warnings [1].

I will send a similar patch to fix squash this warning for VFIO selftests.

e.g.

diff --git a/tools/testing/selftests/vfio/.gitignore b/tools/testing/selftests/vfio/.gitignore
index 6d9381d60172..7fadc19d3bca 100644
--- a/tools/testing/selftests/vfio/.gitignore
+++ b/tools/testing/selftests/vfio/.gitignore
@@ -5,3 +5,6 @@
 !*.h
 !*.S
 !*.sh
+!*.mk
+!.gitignore
+!Makefile

[1] https://lore.kernel.org/kvm/20240828215800.737042-1-seanjc@google.com/

      reply	other threads:[~2025-08-28 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28  1:18 [awilliam-vfio:next 5/37] tools/testing/selftests/vfio/.gitignore: warning: ignored by one of the .gitignore files kernel test robot
2025-08-28 16:43 ` David Matlack [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLCHRCKsPTFQfTOD@google.com \
    --to=dmatlack@google.com \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).