From: Tony Lindgren <tony.lindgren@linux.intel.com>
To: "Huang, Kai" <kai.huang@intel.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"seanjc@google.com" <seanjc@google.com>,
"Li, Xiaoyao" <xiaoyao.li@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"dan.carpenter@linaro.org" <dan.carpenter@linaro.org>,
"binbin.wu@linux.intel.com" <binbin.wu@linux.intel.com>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>
Subject: Re: [PATCH 1/1] KVM: TDX: Fix uninitialized error code for __tdx_bringup()
Date: Tue, 9 Sep 2025 14:05:41 +0300 [thread overview]
Message-ID: <aMAKBUAD-fdJBhOD@tlindgre-MOBL1> (raw)
In-Reply-To: <20e22c04918a34268c6aa93efc2950b2c9d3b377.camel@intel.com>
On Tue, Sep 09, 2025 at 10:55:18AM +0000, Huang, Kai wrote:
> How about we just initialize r to -EINVAL once before tdx_get_sysinfo() so
> that all 'r = -EINVAL;' can be removed? I think in this way the code
> would be simpler (see below diff [*])?
>
> The "Fixes" tag would be hard to identify, though, because the diff
> touches the code introduced multiple commits. But I am not sure whether
> this is a true issue since AFAICT we can use multiple "Fixes" tags.
Your diff looks fine to me, however my personal preference would be to do
the fix first then clean-up :)
Regards,
Tony
next prev parent reply other threads:[~2025-09-09 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 10:16 [PATCH 1/1] KVM: TDX: Fix uninitialized error code for __tdx_bringup() Tony Lindgren
2025-09-09 10:55 ` Huang, Kai
2025-09-09 11:05 ` Tony Lindgren [this message]
2025-09-09 13:45 ` Sean Christopherson
2025-09-09 22:19 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMAKBUAD-fdJBhOD@tlindgre-MOBL1 \
--to=tony.lindgren@linux.intel.com \
--cc=binbin.wu@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox