From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 018812750E1 for ; Tue, 16 Sep 2025 17:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758045398; cv=none; b=DK51yhymv/GK2VYPZ7dKOPiYyyXZHakTvcIDhC7b+r1k4HNY7ldyrx6CshZm0NLIp6qUMnaC3Vi+Cu0QR511FT82M3BWTA6t750JftrMGm1Z2ZbAteVryld5KZA7uJdnjrONXVlR0lhknB4QDcM9vfZRPou6C91yxX6COI2j0Lw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758045398; c=relaxed/simple; bh=MSicL3mF2LDPj9K1Dr5cIfPilYm5d1g/0kAnPclSKn4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IAeKE2jTyrnhtKG4ljaK+y8MXRZGLey8tZSepDpZzE+juHzfneE1Hsh0uErUR2n6EKKWFJJOS0Y12h1BI6MwkPKcE34QtnkhJv8JruznRPJkqkXv0Rrexmmwhsjsj98naSJMY1X0vegGbunwqOCm5QQcuKN/048w9FvUSz/MDdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DYjTiYHR; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DYjTiYHR" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2641084fb5aso30553315ad.0 for ; Tue, 16 Sep 2025 10:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758045396; x=1758650196; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=T8se0Qtiueaxkhq1BXHRNd0a/VQqDJMZQCkyk1YyNA8=; b=DYjTiYHRoIam6SNbmhqy3xJpy57sCL3HpOUt/uxPTzycIlPqQkEz03Iiki2Cn2px3z QR+dIYJCh0S5RsGsY4X0v36d0DZysD5nWUzPrDp5cJL5y8042oyBanQKO/rlPP+fcHJr MF0WfG6JVImQzRuf27LbnN2HZjdM8ihbWABX6nGxaZWkBWVGCsMtBGMOiGO0cUjQO194 6RFLOkD4eFsOXfd2n5sK1VcysXBHSNJA5QC9WxgVNQ9aU3jU8dEycz4+s1f5naUtSLjP 6ztAmr1vP78AAeDOgmGd0hEjEYq7Dg59RsanUmhNQGrHxYulg6CFHYnZNyZ/asYfmQQj ZjtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758045396; x=1758650196; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T8se0Qtiueaxkhq1BXHRNd0a/VQqDJMZQCkyk1YyNA8=; b=Oxej1Ym7hemS6eAcw23HqmzOscR1rfZjZ2JLnVYECJmzYZFcH4zhoO89MJX9GAGTFE H1dxx9hzAoNe2ddx/nUjozL3lvLk5VnZ8sOMH7zr8hICLie1oHrPUrWNcWRg89frDaC2 r/Tmx6AtTeLIft1V+9Mi8HlIyZA3RPfdaqmw4rZWzcEHIF8ncZS5PqSOgWUbZC0dyYLd JFB6++/DhrSpgINFoXZKYvb8DmLzZ9I1g1BFfIywh7p2KzAZurJou6ZzuOP3B7Yymfz5 osAxyIKdBYaeUlDWz0Q+M+qt89GF7JkYb/x2yzHoSWbugccehuVfcx/Bgq2ZxucRPhhm JoKw== X-Forwarded-Encrypted: i=1; AJvYcCUWklmqUPypvoFCF6rScivIVB0cZglIGug8RrKwc+E5QNUNQhRkUY0xxAT+FjwQIctIpfs=@vger.kernel.org X-Gm-Message-State: AOJu0YyryoP/FaIBWdybgSslYuqJO/GFaG400kv1TsKcqOtdqKo+Qeur N3s6ymKdf194CkYDQauRn87bTuy779QZBow2B+A14fFXYItRzTJVfNfcz/4wHbVOA1ytN/T3fLU M14r6wA== X-Google-Smtp-Source: AGHT+IHX97aKh/O5efbD/RijuE1Ev8nPZtcrQ+o4OPDVMwfBtYOs0+ySd/jGWF3rPylA60gNXsyN3zspzrA= X-Received: from pjbst15.prod.google.com ([2002:a17:90b:1fcf:b0:327:b430:11ad]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3d0e:b0:267:9aa5:f6a6 with SMTP id d9443c01a7336-2679aa61619mr92516245ad.19.1758045396152; Tue, 16 Sep 2025 10:56:36 -0700 (PDT) Date: Tue, 16 Sep 2025 10:56:34 -0700 In-Reply-To: <20250909182828.1542362-6-xin@zytor.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250909182828.1542362-1-xin@zytor.com> <20250909182828.1542362-6-xin@zytor.com> Message-ID: Subject: Re: [RFC PATCH v1 5/5] KVM: Remove kvm_rebooting and its references From: Sean Christopherson To: "Xin Li (Intel)" Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-pm@vger.kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, rafael@kernel.org, pavel@kernel.org, brgerst@gmail.com, david.kaplan@amd.com, peterz@infradead.org, andrew.cooper3@citrix.com, kprateek.nayak@amd.com, arjan@linux.intel.com, chao.gao@intel.com, rick.p.edgecombe@intel.com, dan.j.williams@intel.com Content-Type: text/plain; charset="us-ascii" On Tue, Sep 09, 2025, Xin Li (Intel) wrote: > Drop kvm_rebooting and all related uses. Virtualization is now disabled > immediately before a CPU shuts down, eliminating any chance of executing > virtualization instructions during reboot. Wrong. KVM clears EFER.SVME in reponse to kvm_shutdown(), and thus can trip #UDs on e.g. VMRUN.