From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63161304985 for ; Thu, 18 Sep 2025 16:04:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758211453; cv=none; b=VP8zuX/ci+DcvVhbn04eS4AGjvVyBncEzX2Vw0TExbxbWey9lfYIhhZuQxKEgavAdn9B3BBZVNHGOTaKZpCVfY0dAxJPbtYQO86HdZnZuhgv8RA1kfp5GASJ7DDDOjQNoQGxwZYtoYBiyq+2S8UixWs0a509SJ6NvN2YbTB3rFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758211453; c=relaxed/simple; bh=Z5B5dt6wI87+KOD3sTN8FRIoAj7TBjgpAUwP/aqCmqQ=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=MnmkVHdonmaTBG9zwRBkjMJfN+T2rm8yQ3VhEQu7imXmpwXddmyUttog2moEkGABL1LEQ7QDX6JzkuOijtVsvQhjC1DEdFwsJIPSxtxE6wo408sYWa7EhrytamESszz58OcvjdsySVknx0FqZOYqv2jkVbFLH5kEGZ3NrccD/yE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=VOr72Oha; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VOr72Oha" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32ecab3865dso1540663a91.1 for ; Thu, 18 Sep 2025 09:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758211449; x=1758816249; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tqabNObTrUIXb/BYAEPfcGgxscP8Gw2Vuj2oVftkStA=; b=VOr72OhaMYpzapuIs580oRqi7i5QW15pQ9M7wpE19Y140mgSmxSlSVReqFLOdc+dEJ TNey1BMN6NnoMxNbUCB6x7YhYkHnduajq+EtrEbB4RPOCSqhq6RxkIP52vIQ94Oxpj9n wgd5FY7+hHyR2ZAi9W6K8Fh3rcnD7DvjNqx+s8Ox7BzmO9bSWKRNAAdeaoUZ9OAnWrtq UGKNxq2qcV7Xy2dSdlpMgMs0wXSQ0N0G983D8i9Z2DkJQD6pTjRwSh9ujtkhg+2p0e4z GsxHpfYUP/U/iqEP2WuxUDFFHEB0FM972laqIV+9ueYEzkZ6PvV0xIMG4/HF34G1cagy bS1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758211449; x=1758816249; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tqabNObTrUIXb/BYAEPfcGgxscP8Gw2Vuj2oVftkStA=; b=CJfdzVqlBV494BpSlhrWm0pp5i8jkx7NC9FUVOl4bYw0UP+b4NtEHwldnHLaLy14+B jFm4HcxORiHin+XgyyuiOlh/WkQ+hx+JpkuvyQaf9Q90uUBffCqeZkC3rYisqqMv0tIO GETE+lXGBzbgWMTjs+HVE2ct82EJLIrZEj51oBJ3ZuLXNYTM6zElvo+jV7aim1Szgj/6 6zMSobaV6kdC9zM8/IwbVlcvxVx9JaBY2g4xO7v5kbssjTECqdTc78IpzNu5Q/rzQbdH zEU/W62u09ZvrLrb9LvfnoJo9Zxrj9PqNqGoXLRB1z14sYPoVPVVJz6OldgNaTtojevG zf3A== X-Forwarded-Encrypted: i=1; AJvYcCVNogDRvOgygkWuf7VSaLH86z94oA95LT45qBz2ds2Z3EW4ylDL6fuFbVYPYBJ4i+5LQYk=@vger.kernel.org X-Gm-Message-State: AOJu0Yym9Wd5W7M5ylSjbQZqPadXZjS5fYXbhEHERdv/vRrwQcU1DMtc rQ4Hghht8R6i5uIPqk/vso/EScgHjCMWb28EwOFSB1ctkZd5gGE6nlZVApP/dVLoEqSncFNjtrX whBqGFQ== X-Google-Smtp-Source: AGHT+IGkmbYJfZP5nllHSP5gPnF6lwqm76wSLahcIX1/RcNPCgiykqnALzGjrifpViIQLPrzkR7sDPMdXBM= X-Received: from pjp16.prod.google.com ([2002:a17:90b:55d0:b0:329:ec3d:72ad]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3f4b:b0:32e:9281:7c7b with SMTP id 98e67ed59e1d1-32ee3ebb1e1mr8451052a91.3.1758211448798; Thu, 18 Sep 2025 09:04:08 -0700 (PDT) Date: Thu, 18 Sep 2025 09:04:07 -0700 In-Reply-To: <20250918154826.oUc0cW0Y@linutronix.de> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250827194107.4142164-1-seanjc@google.com> <20250827201059.EmmdDFB_@linutronix.de> <20250918110828-mutt-send-email-mst@kernel.org> <20250918154826.oUc0cW0Y@linutronix.de> Message-ID: Subject: Re: [PATCH v2 0/3] vhost_task: Fix a bug where KVM wakes an exited task From: Sean Christopherson To: Sebastian Andrzej Siewior Cc: "Michael S. Tsirkin" , Paolo Bonzini , Jason Wang , kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Sep 18, 2025, Sebastian Andrzej Siewior wrote: > On 2025-09-18 11:09:05 [-0400], Michael S. Tsirkin wrote: > > So how about switching to this approach then? > > Instead of piling up fixes like we seem to do now ... I don't have a strong preference for 6.17, beyond landing a fix of some kind. I think there are three options for 6.17, in order of "least like to break something": 1. Sebastian's get_task_struct() fix 2. This series, without the KILLED sanity check in __vhost_task_wake() 3. This series, with my fixup (with which syzbot was happy) Longer term, I'd still like to land everything though. > > Sean? > > Since I am in To: here. You want me to resent my diff as a proper patch? Ya, I think it makes sense to harden against UAF even if we fix the KVM bug more directly.