From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 998CE2F6198 for ; Tue, 23 Sep 2025 16:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758644101; cv=none; b=Krnkbew6kesG6MzleG+XRC0od8vQ44il9OHpcsZ1DivEHA6wRHbRbwq8vNk2mM9TwlHmU1Mz25igqLQss4YGjwZaj2eO6PcOLH/2Q9dIKoPsUilb0o0tX20QH9/MWyoStMSwXKizxqPeHctPUkwxwkNoHy88tJJeLEt326dTAmQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758644101; c=relaxed/simple; bh=7s+A5FPvgZVYp22XNXA9oi7XjByCFaSyUroyMAErrpU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oLeS8i2BI1HwBC8ctHLzblJQdCmL8gvkNCJYSib+V4Xm5ZEPG7VP2zLRmiI5SFFNv6QJWmr8FXdXZlYHWmN5f/6LKEuPcHmm8wYmq8djONQ+/EWxeHaaIjbfRdkrGPIGaghDnNp74iOjbS23Pb3srOxWqny0cqmMt5vK2+l1hIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NucJjwky; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NucJjwky" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-77e5a77a25aso6046724b3a.3 for ; Tue, 23 Sep 2025 09:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1758644099; x=1759248899; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=+tYNF4K/77ITcUr0+JToP8xS2/zhcS2p8XYqUTK0ON8=; b=NucJjwkylAuvDAEFsW7gUGS+lQu/yXmK6Itc4cA0QQfjti/AJNAB7kZs2IyyA9A2AI Y654840YcTjRNhWiuLXtfrAzhx3dhHHdHx6zXS/9VTGgmEag2gXzZwUVIqXFhBKxPXVW MgxR1NIfHz/7e8cLzryvXEn1KqkzVZftX9w5mtHcqZo9MJprRsW/DMXIQMzmw3RJAjR/ EbJZbYuhvKjuFmUJ7TjpWF9oSjZQKMKHyEMKNU8T97vj6LgSUpVgqdBloCrl7Lw+od/W jWTnjA1xsww9n7XOzmnwUpEHkyBIIIcNH4FddR2s5OsRjQFBqnj/E2JzslG9iOn2yCsA ER1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758644099; x=1759248899; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+tYNF4K/77ITcUr0+JToP8xS2/zhcS2p8XYqUTK0ON8=; b=kyVarOcdBReErbjKleD0FxlFS02yN/4vrVnPaUYJcw7FYiXIBfJT2mDKdKifpMwju0 3gz7l+v52kNm6P54oWbAKiHYKm8EfQqo9+KGO+E/ZrAwLUBAD61V88fGVLltqqKU6Evs u2J/ptQqd9IQHI0CLg94FRCCoXV/oSo1LGzNc0sC9j9DbFD0GFG/i7PslzZaJ2ERZom3 ZBBg8n1uJQ5kV/2iQGOs6xwH8vtzE/nrEAIgXE9os4n6Z2h/bjoubQ8OPMTtfsRe3RV8 CSoR28m1pZ/hL7MwSnrKg/Fo+mqCoulG8iySQEzqBOdVRGwvvUK9y+9zbe4AG678XIWC Di1Q== X-Forwarded-Encrypted: i=1; AJvYcCV8wKtEM7KRpjao9/YGiFtOtM3ebCqj2cgkzYxB6rUSTt6XQIUWmdNf/X5Rh2yRJiahZkE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+2aN+P1fN2G3pFuhTPXU6jC8YyFVfZfJ/ZQ9odon2iNMmCNso 7bDQYFJmLR6Fkoat4BLb0DhEOzcGfuLsr6K+6Ruo8wy6OoauqEZr6NjggIjZmLOUrGWQaO0GC1M yre0f5Q== X-Google-Smtp-Source: AGHT+IHD7L+PryqMRcEAyMIWx5h8kZMzWZlsPrrV/X3n0qIL0f/pV9BpQBHe6p3E+N7zso99rGpKKIiD2i8= X-Received: from pfst22.prod.google.com ([2002:aa7:8f96:0:b0:77f:ad8:fbe9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:230c:b0:76e:2eff:7ae9 with SMTP id d2e1a72fcca58-77f539308b9mr3647087b3a.12.1758644098926; Tue, 23 Sep 2025 09:14:58 -0700 (PDT) Date: Tue, 23 Sep 2025 09:14:57 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250919213806.1582673-1-seanjc@google.com> <20250919213806.1582673-3-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 2/2] KVM: SVM: Re-load current, not host, TSC_AUX on #VMEXIT from SEV-ES guest From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Hou Wenlong , Lai Jiangshan Content-Type: text/plain; charset="us-ascii" On Tue, Sep 23, 2025, Xiaoyao Li wrote: > On 9/20/2025 5:38 AM, Sean Christopherson wrote: > > --- > > arch/x86/kvm/svm/sev.c | 14 +++++++++++++- > > arch/x86/kvm/svm/svm.c | 26 +++++++------------------- > > arch/x86/kvm/svm/svm.h | 4 +++- > > 3 files changed, 23 insertions(+), 21 deletions(-) > > > > diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c > > index cce48fff2e6c..95767b9d0d55 100644 > > --- a/arch/x86/kvm/svm/sev.c > > +++ b/arch/x86/kvm/svm/sev.c > > @@ -4664,7 +4664,9 @@ int sev_vcpu_create(struct kvm_vcpu *vcpu) > > return 0; > > } > > -void sev_es_prepare_switch_to_guest(struct vcpu_svm *svm, struct sev_es_save_area *hostsa) > > +void sev_es_prepare_switch_to_guest(struct vcpu_svm *svm, > > + struct sev_es_save_area *hostsa, > > + int tsc_aux_uret_slot) > > Passing the tsc_aux_uret_slot as paramter looks a bit ugly, how about > externing it? Yeah, looking at this again, I agree. I'll post a v3 (already did; forgot to hit "send" on this earlier, /facepalm).