From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 818A4239E63 for ; Tue, 14 Oct 2025 19:05:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760468731; cv=none; b=YM4l9WKTsEcevE4sHeMcIv4vmRNTnNKzGbjYE5e8J3r0f+7PUtOG1yC2xqShQBmIWVji88QK0pJ38vIwiy+Ozu1wqlXkvMwUZDYD9wCSREIBUKVQ0GGjnW18AfvxK79vZ0OvsY6d9ceNHKN0ozgi2t13IReKGfGqv1Wkcjs83B0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760468731; c=relaxed/simple; bh=k7sLOjS3mwqYX0wOEW1KBhtCAUTziTwPywv1CTVyHNc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=iEOfCCXI/qG5ulERqVdOdbyuGJf6vkXYYBQcz8rIZYbaacNycjEQDvNlyJ0rFgt86tVPVDYQ5KwYJjFQcznnExWDxc1UYxgiLP5zZ+vZKOj4PhQi2cU5ppvEysOVjvgMPSCax4l4bH21B3Uzu2XZSJUK8IHk+j2trT0Hw4fhK7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GHoRD3ed; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GHoRD3ed" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-32eb18b5500so15192849a91.2 for ; Tue, 14 Oct 2025 12:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760468730; x=1761073530; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=rc58PPiWOIscw4gzc1uP4pr7xQS6V7163kSeQz2T208=; b=GHoRD3edEz3z9KDv0wxm3cpnuV71pCBN2pVGiXcpab2AmZbA8KQXsLkObK8qRYC6cv TwNHkj3SiTIb9mnR4fuuVpP6HxwHiJv13/Cz3R1JMj5/f5fITSABR23DmXvhiHLBvkHX wJhzo0IZwkYcposzM9QG9m+uVWrlW4IBXalYCLRjJyzgMNargTVWrqxUfmIng4A+fOsF hm9hvTxb6TzookUAC0Jk5Itmy6d9dR1bCqAKjxTmbjj4txNJNVFTpb8XONf6Pq5pq1wW gLQsx+2BmAhYYn1Z73Gi7DCkJqJInSZac8mMYQePDi4q2C46KHxK6ZFou5Dbyb69y3Sj j1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760468730; x=1761073530; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rc58PPiWOIscw4gzc1uP4pr7xQS6V7163kSeQz2T208=; b=n8slx3pGFmIKy8H/32KHvdue7O91KmAkaP2ma6DwwUwl2ILRZZT8ExOMQbWCwfQxR8 BKhrdYtxzKpt/Z41dw+SWtXhzHxM0s/1IB7i4ti7apOofOXmFC/4UaGUtyeFw1FmSVHb Ou6aOb1OScOraG/yk4ZWAfnc90//8+xhcBwGyl9nRycJL6oloq/MBO2nsiZ/ZL0htSEk vnuqRVak0Qf9wZAjqdPjD6D0yS1wkZZcdR4wIxtLclU+cVt19SaBKLwCbrZW0x3QTfsn YxA2adFmi2CGG6W3g++4/pL2yktUeSQiknbJ+ft2CVP4/Ms6Z3A1Px8NEyKcurrDvWQf ePPw== X-Forwarded-Encrypted: i=1; AJvYcCWH+z41QziMRbL7B+UsXPrLEZQ2iBIB2wiWuKDMPScK/GRwuTnUFUyAk5hcWhzRl1sCmys=@vger.kernel.org X-Gm-Message-State: AOJu0YxH8X7HpPYelIz7vIXzNIL7MVXdpZmwdaEJXH0PgtWif3yaqhDA Z/bAHLbjJuxqXpD/PKy1zWB+A1D3iO7PFxukYkxz/tP1OvKzc0T2NErj4r9DQeTJZ2CWqlYC8if Z5Pxx+w== X-Google-Smtp-Source: AGHT+IFPeoJzDvTAF6xr4A7hQhLSCx/6X0JPH4z/3Z9BNtyzLqFJ4dyjiFG5gqILjbnBFdR2+iVHQHmVLHk= X-Received: from pjbga22.prod.google.com ([2002:a17:90b:396:b0:32f:46d:993b]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:224a:b0:336:9dcf:ed14 with SMTP id 98e67ed59e1d1-33b51375a05mr37471970a91.23.1760468729683; Tue, 14 Oct 2025 12:05:29 -0700 (PDT) Date: Tue, 14 Oct 2025 12:05:27 -0700 In-Reply-To: <68ee9bcf14fea_2f899100d2@dwillia2-mobl4.notmuch> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251010220403.987927-1-seanjc@google.com> <20251010220403.987927-4-seanjc@google.com> <68ee9bcf14fea_2f899100d2@dwillia2-mobl4.notmuch> Message-ID: Subject: Re: [RFC PATCH 3/4] KVM: x86/tdx: Do VMXON and TDX-Module initialization during tdx_init() From: Sean Christopherson To: dan.j.williams@intel.com Cc: Chao Gao , Rick P Edgecombe , "x86@kernel.org" , "kas@kernel.org" , "dave.hansen@linux.intel.com" , "mingo@redhat.com" , "tglx@linutronix.de" , "bp@alien8.de" , "pbonzini@redhat.com" , Kai Huang , "linux-kernel@vger.kernel.org" , Adrian Hunter , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , "xin@zytor.com" Content-Type: text/plain; charset="us-ascii" On Tue, Oct 14, 2025, dan.j.williams@intel.com wrote: > Chao Gao wrote: > > >> Also, can we name the two tdx_offline_cpu()'s differently? This one is all about > > >> keyid's being in use. tdx_hkid_offline_cpu()? > > > > > >Ya. And change the description to "kvm/cpu/tdx:hkid_packages"? Or something > > >like that. > > > > > > > Is it a good idea to consolidate the two tdx_offline_cpu() functions, i.e., > > integrate KVM's version into x86 core? > > This looks good to me, some additional cleanup opportunities below: +1. This crossed my mind as well, but for once I reeled myself in as I'm very susceptible to self-induced scope creep :-)