Re: [PATCH 2/2] x86/eventinj: Push SP to IRET frame

[Chao Gao <chao.gao@intel.com>]

>> ---
>>  x86/eventinj.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/x86/eventinj.c b/x86/eventinj.c
>> index ec8a5ef1..63ebbaab 100644
>> --- a/x86/eventinj.c
>> +++ b/x86/eventinj.c
>> @@ -153,6 +153,7 @@ asm("do_iret:"
>>  	"mov 8(%esp), %edx \n\t"	// virt_stack
>>  #endif
>>  	"xchg %"R "dx, %"R "sp \n\t"	// point to new stack
>> +	"push"W" %"R "sp \n\t"
>
>We should also push SS, for consistency reasons. Not that it would
>matter much for x64-64, but a NULL selector for SS still feels wrong.
>
>>  	"pushf"W" \n\t"
>>  	"mov %cs, %ecx \n\t"
>>  	"push"W" %"R "cx \n\t"
>
>The leading comment also needs an update and the 'extern bool
>no_test_device' can be dropped as well, as fwcfg.h gets included by
>eventinj.c.
>
>So, maybe something like this on top?:

Looks good to me. Thanks for your suggestion.