From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D27F01E49F for ; Mon, 27 Oct 2025 16:38:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761583134; cv=none; b=Utomm7ECkePFJd9/TFDLoQGUgL3JnRkx+6h1+wB6U/5/yFsdjZm/Azu+FFaJBc1yJizLCKG2PuwoEceN9rG6ePPSPBjrVsLVv56RxCMps8rBblXYK9lVPp0D3OMGuxcr2JzseyrSGWdcRtKyIsVmbkWuO5/xFk4VHcmnoWgHRcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761583134; c=relaxed/simple; bh=nAhmUlr/hO6AGJs14F5PTgWNTU6mEzb9QsSufy3So/Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZLdFE/msjNfVMgOE1/ZESClD6Bm6KaHLXDnsSMj0Yo8XuDZPcuMlBb5Lb1ghgFt7E2m6gGE7qWA9H4k6Gq1GOsm1fCJUSlNP2wIJjoZC6pZuv4dRrqOez2CPUoX5of71VDONoVhlK6LLB8Lq+ZS2mqmMhMFunUydYbUr0fODjZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=BSCrR+pG; arc=none smtp.client-ip=209.85.222.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="BSCrR+pG" Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-89ec3d9c773so521581285a.2 for ; Mon, 27 Oct 2025 09:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1761583132; x=1762187932; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f2HGwzd/4lzqDYF3XkN+FOghRP60HTqO9KJmTXVpNDU=; b=BSCrR+pG+Y7/saGJaQX20uzc1Qo1+qKSDQNhfe3Jq5mp2ZVIuA1AfXqrkKMasdFzmW 7Qx+hR79rqhMBQVyg3XVENRsHeiXAbOlGwuG8YjTI4x6f+K86y+AUpDV6/Dwg0/i7ua4 dtX3BNjxD8vykbbF2cTq0jAEukuu2uPSRi4AnTxPKyd/oeBEMaEjFTSYhZWoGLnpeRyS RilIGepkRXt83NIzS1lFthelm2vYj9pSCBbeq7bWvbUbmksj5tBICCrCnngGIpRRkGPd xDPc57+tG5kSN+8jOfsZ+gwtFsIILrsnYXvwMFI43BJ1Ux4gumpj4AIgWoy/kGuTDcHp lqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761583132; x=1762187932; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f2HGwzd/4lzqDYF3XkN+FOghRP60HTqO9KJmTXVpNDU=; b=jMA5RASk4eEyG+uIC+x/3Iw2jDGdhrCUuYRS2jDmBrKCN+ZamvU2zIm9TmdLZd0dQv I7v0rRbpBvbu7MQ9JBOp16tJifNqe+sFmvCHu9xlO+zHiFQ2pY13o4OBPUBdwTd6OkW9 KPHYhQPVKih9Tt8mYjFxveeouy0LBuT1Rq/0mo7c8rBaWB0ohALMsuiKe9aN3ADFdcgL TzGcoqFJx/cDcv5NEVQjC9PPlUnS66KaIFW0G9vH7qRr+RjPjU1RQII/UTTMLGqwOIRy 7uQxTOMdfVIWaH5gUHUCTdwXM0NuIFKhHEvPy8nZUfSC+GoZKmVvZF4GSDtagcD4VU2G 45Sg== X-Forwarded-Encrypted: i=1; AJvYcCWXf6i2wljOSJGaVr4YpHxGTs6WieMQU7Bs4anIj5Hh/UiYghc/CeITGOmx+EF0We5vNQo=@vger.kernel.org X-Gm-Message-State: AOJu0YyZWyBYp+asOaH4wdocQFlvO/GJ7Oq9TeUJhZVet2Ixy1o4Vg9j 4+HOHKDNFqZLvUEfowWgFMNNJ9NxJnBCMC/vhuXGjxIjhI9+jHany5o24MuprM961E8= X-Gm-Gg: ASbGncv0DuOKyBLo1/FOv/DZ+Znfua8COglhcHrGObndU73CQf6gcKiFyWDnn1GxejJ OMsMZc+L8sxT5BdWwAs9Oh72Lkj/YeKP+HpeM+2GerkxHcepEraUXZXKdlzmlzJTNhS/YQwQZnE yaTE3Z6EE82LGRKOsKz2aWgz+b3QsR+Pyr4hmR9n1qMKrSQJOyLhXeThg9heoyz9PlBWtyv2cQM uoMvl929GxS+Sr7+iKSpoaqKN/w6eLqUSUyOXlPnz1QmX31wj8eLM276V8hBljUojP1FIwOEzIe zAtl5w8Asm7ArrOY3TKPwkBLw52d9hm4Uxjg0oJtl6fY64oeUpx59A/bgdmk2mQ5+BLhognvXmX s3BVSv2ldgW8QZgSRl/lmvwGyo3hW6BHp9HuNs3z/4JC0g7HuFJ0apyP+0F+OSXp5AUhkmzTsGx 0Hp2qfj01Oli2fldWplROwPReAImtWSB2VJ/2tYMCARh8ni78E0lWtMAnZhJyHmLteAO7YTQ== X-Google-Smtp-Source: AGHT+IE8OFT35MTx0jxBdZigqHGpIP25NqCfl0+l6c8fCefLdIH0hfSup7UdNhOGnYzqPJc4qxyLmA== X-Received: by 2002:a05:620a:711c:b0:892:636a:5675 with SMTP id af79cd13be357-8a6f704a25amr58519385a.58.1761583131221; Mon, 27 Oct 2025 09:38:51 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-89f25798afesm626595985a.37.2025.10.27.09.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Oct 2025 09:38:50 -0700 (PDT) Date: Mon, 27 Oct 2025 12:38:48 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Jason Gunthorpe , Andrew Morton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Kemeng Shi , Kairui Song , Nhat Pham , Baoquan He , Chris Li , Peter Xu , Matthew Wilcox , Leon Romanovsky , Muchun Song , Oscar Salvador , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Pedro Falcato , Pasha Tatashin , Rik van Riel , Harry Yoo , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH 05/12] fs/proc/task_mmu: refactor pagemap_pmd_range() Message-ID: References: <2ce1da8c64bf2f831938d711b047b2eba0fa9f32.1761288179.git.lorenzo.stoakes@oracle.com> <76348b1f-2626-4010-8269-edd74a936982@lucifer.local> <3f3e5582-d707-41d0-99a7-4e9c25f1224d@lucifer.local> <20251027161146.GG760669@ziepe.ca> <27a5ea4e-155c-40d1-87d7-e27e98b4871d@lucifer.local> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27a5ea4e-155c-40d1-87d7-e27e98b4871d@lucifer.local> On Mon, Oct 27, 2025 at 04:26:54PM +0000, Lorenzo Stoakes wrote: > On Mon, Oct 27, 2025 at 01:11:46PM -0300, Jason Gunthorpe wrote: > > On Fri, Oct 24, 2025 at 04:37:18PM -0400, Gregory Price wrote: > > > On Fri, Oct 24, 2025 at 09:15:59PM +0100, Lorenzo Stoakes wrote: > > > > On Fri, Oct 24, 2025 at 03:12:08PM -0400, Gregory Price wrote: > > > > > > > > So maybe actually that isn't too bad of an idea... > > > > > > > > Could also be > > > > > > > > nonpresent_or_swap_t but that's kinda icky... > > > > > > clearly we need: > > > > > > union { > > > swp_entry_t swap; > > > nonpresent_entry_t np; > > > pony_entry_t pony; > > > plum_emtry_t beer; > > > } leaf_entry_t; > > I think Greg meant this as a joke [correct me if wrong] :) that was my > impression anyway (see original end of email...) > > I like leaf_entry_t name-wise. > > I don't love the union. > The union was definitely a joke - see `plum_entry_t beer` There definitely shouldn't be enough extensions to warrant a union here, that seems like negative value. leaf_entry_t naming replacing swp_entry_t seems reasonable since that's basically all swp_entry_t is in its current form - even according to the this set's cover letter: ``` There's an established convention in the kernel that we treat leaf page tables (so far at the PTE, PMD level) as containing 'swap entries' should they be neither empty (i.e. p**_none() evaluating true) nor present (i.e. p**_present() evaluating true). ``` ~Gregory