From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA495354AC3 for ; Fri, 17 Oct 2025 22:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760739446; cv=none; b=F5U2QRRQNACEJ8OGiSSi8EP50yXrf9TiXjX6tWDQT5s7t1GydLmZoPKDSGoYJwoXm2ImmwpDPdborwmYHQ4Nny1hEbwiQ9OMaCWqAQDzm36fLk9jXepBlG5AT2//NGEBdj5ZIB6xPJCJqgI5U4ZVih0SW+DvJXIu7WHk7LSNZwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760739446; c=relaxed/simple; bh=CIzxIN2I2K9yucRq6MizmW6QG3zXD+tMMvjx7wAP1N4=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=M/0/mMICwasROXVIh27i3QC20fI584zeCciEv7hLFxZY7v8gPYhQdVi4O9QfU1JmPsajcix7DVyzg/TSqNqJKWI14wfW6iRWe0U/7+BJiODltimQBJWtuEz8l6SSNFramXB03UIURHsK8+V3X2PHvLPt1bxAQ8BLBcyRaPwJ06s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pcVCMmmT; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pcVCMmmT" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-32eddb7e714so2094316a91.1 for ; Fri, 17 Oct 2025 15:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760739444; x=1761344244; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jBW9JeEw0rbC3waNIsvF3E2h5Mpei0jyfelXeZ/F0jE=; b=pcVCMmmTDH1/TJlIGoIg5GptiRRz4f7/eFP3eHKOMAtfHVnwe4wAw6Sv2s56l1zBmn gKJ8t2abAqHe0EVExvEgKdbkC5fOIKxXZcCYTzi/IAoYLs9IVxqRIsGsJsyUV0UEuERI czlXPhWHOCM/y9Dar4cC/flVBc1kIdtj+g7SDuXARoMSwh33fTVib2LQFycyMfxX4T88 4ZyTbG0NnipXBYO4aO9u84vJrjUIMzCRaFdmUop7MBE/HtBczbVkD6FEH2l7Zj+4RGny d9tbWLRiySynjlBkIhbvcBK9G8EKEUqzPDpMVpniWrGn8rVDyRm3UaJQEcmo/sdQQEQw WBGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760739444; x=1761344244; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jBW9JeEw0rbC3waNIsvF3E2h5Mpei0jyfelXeZ/F0jE=; b=Kj95YOPV4NNgHeBIVP/QS2XbjrAhv6a8P04oWF19spSHllEBSATjDZd9R9IcIgYziW uCmNTeYyvVS9t3L73/JdEePSdb1BVo+1eKMVNlgXD8r7RJSAt4x5BjP3NKVwP6TBMZib 7VxVRUNW/qTgRkvNllY12Ps6UntUkzZaNmi0JiRIkpU6LwDpjGj5G3A02xq5C2hUyNFH z9Yt8DfF+mB5yDbBN4bDCVwLEWZSXwv0TcyHAuI744LiqvMny14i2/n4rLMuUz41ua/c HU0/gJwHlvXM/q4tXVtHr6IAwlYafguCiHtjPQO/otqml+4ar2yhXvkE5uqFeYmS6Fil E7Pg== X-Forwarded-Encrypted: i=1; AJvYcCU9W9TXQK5aZic+mM7pjsbNzEAtR1K7V+HO3xU1gLAgu2d6Lhfovdtykklppro1DzgaTno=@vger.kernel.org X-Gm-Message-State: AOJu0YxR4VmTiV8vDc21r5vNR504Wje6fOgWdb5//RIXMhiNuM9iDYxF RhcITcGOSFKyChAupXoSU71N4RUOP/p6K3FjknqmwiqiCyC3/KI05RiEsPsL4HqoPmdQMyJvofL 0rJ60nA== X-Google-Smtp-Source: AGHT+IEOUe7QczZRN3Q5VNQEDQ1NSmdvwFmMlqw/2h3dEW9CdY/W7wbLfkkO9C5oHj+q5GBBV+83UpDb3Co= X-Received: from pjbgx4.prod.google.com ([2002:a17:90b:1244:b0:33d:65b9:53fe]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d407:b0:33b:d74b:179 with SMTP id 98e67ed59e1d1-33bd74b025dmr5715700a91.27.1760739444079; Fri, 17 Oct 2025 15:17:24 -0700 (PDT) Date: Fri, 17 Oct 2025 15:17:22 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251007224515.374516-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH] KVM: selftests: Use "gpa" and "gva" for local variable names in pre-fault test From: Sean Christopherson To: Yan Zhao Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Oct 14, 2025, Yan Zhao wrote: > On Tue, Oct 07, 2025 at 03:45:15PM -0700, Sean Christopherson wrote: > > - guest_test_phys_mem = align_down(guest_test_phys_mem, alignment); > > - guest_test_virt_mem = guest_test_phys_mem & ((1ULL << (vm->va_bits - 1)) - 1); > > + gpa = align_down(gpa, alignment); > > + gva = gpa & ((1ULL << (vm->va_bits - 1)) - 1); > > > > - vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, > > - guest_test_phys_mem, TEST_SLOT, TEST_NPAGES, > > + vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, gpa, > Wrap at 80 characters? > > > + TEST_SLOT, TEST_NPAGES, Hmm, yeah. Probably this? vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, gpa, TEST_SLOT, TEST_NPAGES, private ? KVM_MEM_GUEST_MEMFD : 0); which I like more than: vm_userspace_mem_region_add(vm, VM_MEM_SRC_ANONYMOUS, gpa, TEST_SLOT, TEST_NPAGES, private ? KVM_MEM_GUEST_MEMFD : 0); > > private ? KVM_MEM_GUEST_MEMFD : 0); > > - virt_map(vm, guest_test_virt_mem, guest_test_phys_mem, TEST_NPAGES); > > + virt_map(vm, gva, gpa, TEST_NPAGES); > > > > if (private) > > - vm_mem_set_private(vm, guest_test_phys_mem, TEST_SIZE); > > + vm_mem_set_private(vm, gpa, TEST_SIZE); > > > > - pre_fault_memory(vcpu, guest_test_phys_mem, 0, SZ_2M, 0, private); > > - pre_fault_memory(vcpu, guest_test_phys_mem, SZ_2M, PAGE_SIZE * 2, PAGE_SIZE, private); > > - pre_fault_memory(vcpu, guest_test_phys_mem, TEST_SIZE, PAGE_SIZE, PAGE_SIZE, private); > > + pre_fault_memory(vcpu, gpa, 0, SZ_2M, 0, private); > > + pre_fault_memory(vcpu, gpa, SZ_2M, PAGE_SIZE * 2, PAGE_SIZE, private); > > + pre_fault_memory(vcpu, gpa, TEST_SIZE, PAGE_SIZE, PAGE_SIZE, private); > > > > - vcpu_args_set(vcpu, 1, guest_test_virt_mem); > > + vcpu_args_set(vcpu, 1, gva); > Should we cleanup guest_code() as below? > > -static void guest_code(uint64_t base_gpa) > +static void guest_code(uint64_t base_gva) > { > volatile uint64_t val __used; > int i; > > for (i = 0; i < TEST_NPAGES; i++) { > - uint64_t *src = (uint64_t *)(base_gpa + i * PAGE_SIZE); > + uint64_t *src = (uint64_t *)(base_gva + i * PAGE_SIZE); > > val = *src; > } Yah, no reason not to (lot's of tests assume GPA==GVA, but that's not a good reason to be deliberately confusing).