Re: [PATCH 05/12] vfio: selftests: Support multiple devices in the same container/iommufd

[Josh Hilke <jrhilke@google.com>]

On Mon, Oct 27, 2025 at 09:21:57AM -0700, David Matlack wrote:
> On Wed, Oct 8, 2025 at 4:26 PM David Matlack <dmatlack@google.com> wrote:
> 
> > For backwards compatibility with existing tests, and to keep
> > single-device tests simple, vfio_pci_device_init() and
> > vfio_pci_device_cleanup() remain unchanged.
> >
> > Multi-devices tests can now put multiple devices in the same
> > container/iommufd like so:
> >
> >   iommu = iommu_init(iommu_mode);
> >
> >   device1 = __vfio_pci_device_init(bdf1, iommu);
> >   device2 = __vfio_pci_device_init(bdf2, iommu);
> >   device3 = __vfio_pci_device_init(bdf3, iommu);
> 
> After using this code internally for a few months, I think it would be
> better to just require all tests to call iommu_init() and then
> vfio_pci_device_init(). It is not really that much new code to add to
> tests, and that will leave the function name __vfio_pci_device_init()
> available for other use-cases (like [1]).
> 
> [1] https://lore.kernel.org/kvm/20251018000713.677779-20-vipinsh@google.com/

I'm fine with that. I see what you're saying regarding [1].