From: David Matlack <dmatlack@google.com>
To: Alex Mastro <amastro@fb.com>
Cc: Alex Williamson <alex@shazbot.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Alejandro Jimenez <alejandro.j.jimenez@oracle.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/5] vfio: handle DMA map/unmap up to the addressable limit
Date: Fri, 7 Nov 2025 22:24:27 +0000 [thread overview]
Message-ID: <aQ5xmwPOAzG4b_vm@google.com> (raw)
In-Reply-To: <aQ1A_XQAyFqD5s77@google.com>
On 2025-11-07 12:44 AM, David Matlack wrote:
> On 2025-10-28 09:14 AM, Alex Mastro wrote:
>
> > This series spends the first couple commits making mechanical
> > preparations before the fix lands in the third commit. Selftests are
> > added in the last two commits.
>
> The new unmap_range and unmap_all selftests are failing for me. They all fail
> when attempting to map in region at the top of the IOVA address space.
>
> # RUN vfio_dma_map_limit_test.iommufd.unmap_range ...
> Driver found: dsa
> tools/testing/selftests/vfio/lib/include/vfio_util.h:219: Assertion Failure
>
> Expression: __vfio_pci_dma_map(device, region) == 0
> Observed: 0xffffffffffffffea == 0
> [errno: 22 - Invalid argument]
For type1, I tracked down -EINVAL as coming from
vfio_iommu_iova_dma_valid() returning false.
The system I tested on only supports IOVAs up through
0x00ffffffffffffff.
Do you know what systems supports up to 0xffffffffffffffff? I would like
to try to make sure I am getting test coverage there when running these
tests.
In the meantime, I sent out a fix to skip this test instead of failing:
https://lore.kernel.org/kvm/20251107222058.2009244-1-dmatlack@google.com/
next prev parent reply other threads:[~2025-11-07 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 16:14 [PATCH v6 0/5] vfio: handle DMA map/unmap up to the addressable limit Alex Mastro
2025-10-28 16:15 ` [PATCH v6 1/5] vfio/type1: sanitize for overflow using check_*_overflow() Alex Mastro
2025-10-28 16:15 ` [PATCH v6 2/5] vfio/type1: move iova increment to unmap_unpin_*() caller Alex Mastro
2025-10-28 16:15 ` [PATCH v6 3/5] vfio/type1: handle DMA map/unmap up to the addressable limit Alex Mastro
2025-10-28 16:15 ` [PATCH v6 4/5] vfio: selftests: update DMA map/unmap helpers to support more test kinds Alex Mastro
2025-10-28 16:15 ` [PATCH v6 5/5] vfio: selftests: add end of address space DMA map/unmap tests Alex Mastro
2025-10-28 23:01 ` [PATCH v6 0/5] vfio: handle DMA map/unmap up to the addressable limit Alex Williamson
2025-11-07 0:44 ` David Matlack
2025-11-07 22:24 ` David Matlack [this message]
2025-11-08 0:36 ` Alex Mastro
2025-11-11 19:15 ` David Matlack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ5xmwPOAzG4b_vm@google.com \
--to=dmatlack@google.com \
--cc=alejandro.j.jimenez@oracle.com \
--cc=alex@shazbot.org \
--cc=amastro@fb.com \
--cc=jgg@ziepe.ca \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox