From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9605E2F0661 for ; Fri, 31 Oct 2025 08:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761899245; cv=none; b=Z2xxGjssd6wYqgihh1r6ra5FkUE6DInKuW04zrLTTDlcb6MAo7bVLNK91DAlpODf8JcfWDeb52mlw+rQgNn75ixef+KN494Iebr7+3jRhNijkVibyVpY3sOQ7lwvSJIPX5eM7YfWhiGXTAyRj/LxnWr9IZQhfiwfLGwghFGl9KY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761899245; c=relaxed/simple; bh=lVQsmI/OgcGtefcLtFfLf1leQyCYm0kn4f7Js5h7gO0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YdxpKVxmX+7wa5YaJaWhSg3woQYsEA+A/potGvMCkv6yb6xkuyOZBdtVPwjHknqGV34HZfV/b2VsVBjPv8g/qtSlaj6OoxaWAWXwGLqIf39jRMZ9VkFcUW0gQUF90pKw/V35Wh8+PO4hj5U0eULmeqy9j5hNc4P4BXg98B8rIgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=TA+HBQ3k; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="TA+HBQ3k" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4283be7df63so964336f8f.1 for ; Fri, 31 Oct 2025 01:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1761899242; x=1762504042; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=i/fYaZtBikFS6oNzHl/Bdj60BD7iQqSjLDzNr7ZdDK4=; b=TA+HBQ3kNS+7xiiif6xKFcAkfcAzM88y0Sf58DeYTRQoQGJdQPXMGZyHs6lTbBCxZP lbhMmmkg1R1ADgijncgEzu2XrFXDcIInDZbeY5ULZdx8d8NlK2sos//XKSNgSRRAWvvi yNb6AyLC+OKnkGfefh2/Ef6qd6S27sBkqjzWP1Jz9k2PMq18ukyoY7Yp/Srt4WOdbsOf xQCJ6oJ43kLilMjK2QHuETkDtYl3eu7z0Va2N6JTTiFbd7hiEbYrnqE0x1ckURea6zzL e2hu0CpGvSb3luhJ4HFxzuxB1SKaffBjTBbmLFoUg0asMJBQ1IYDH5V2ZsnPsHjNUI+E 0T/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761899242; x=1762504042; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i/fYaZtBikFS6oNzHl/Bdj60BD7iQqSjLDzNr7ZdDK4=; b=YI11RdECXkBXzM5qdsojbe/WpQJ8HhL9LMCqdokVL4udx1Edk9of8ni+WmyOIX+tTI 0xrByqEZhSnbV4pSF5MQDBnercTrPZG3jIN0mnUKq8Yz7NvRt14ZDrlctVZd2l1Yz0YY iFHkLu4EjJa91FDIGJOcKMSp5JfLlLsTesFFaCoQtZR6osSsZ+A3CaEuEhkbhMGOK4z2 0WLu3qpaJB26auiG3eYgfnopwS6pjg6NRBHHJcv8KASbixIN6925QDxYsofGMiFHKjqQ utDWqP48F7Dy2QYar5HEudmxylTXt/vKvq3bj1gs+eKDSEC+eoqHVJ4B9A9q3DEZm41k OVPQ== X-Forwarded-Encrypted: i=1; AJvYcCU4GXK4pRuKw0IUn9lMi8sXMRkbbn3vcCmocqGsNN9zwwMgyDN87715G6A+L3bc51IdCGo=@vger.kernel.org X-Gm-Message-State: AOJu0YxVuuSo8ohgfJ+szfiNOI3l6kI9+lUoN4wspg4MqJ8ja+YpjBZP FevaKOhFsltDATWeVrU0mOORuRbqe1pqdlTJ31H6zVJfL8mtuP8p9h2TuB0s7Zpnm00= X-Gm-Gg: ASbGnctclwlyIf15stSp+EhcfRJmQCAUQ5toCnCzORFMuV2zdZn5cCA64Rcx+MBT7p2 xS0cltxpyY94F+L9eV6gseer4sIGq6YcpKyzehrLyTCTE4r6LOzjIiolYF0aGou0fnSt2+N8GNh WMeMhbu8deQAlK/X+Z8xoL6X8Mk6vVWVyimy7XaJjTB2UkDbgg/xF6pmZMYJgVCuSVGnt5GXF1q 487z/0wG2m4EK9cx1Kyr4S9n6inD8vsVr8BJ+k8cHRSvjA8kNCy6EBMCmV1noZ1m/EIpWIIMUOZ 5Q3/VTAwEFPsdtdl7B4UAS2V4fMMJLORxdcKinPAsJKBDpYMD8n2G3P9LGXDza78bjRkpiIX/Fc YGU1qeELKqQO6Bn84FF6MtOvYxVRCetGMFKgMmGKSHlu0bJu45BVfEIxHygeJAOEmRQJEtNsXp1 qyRHHlaGy5EwWZH4kXqt1/EDRx X-Google-Smtp-Source: AGHT+IFSgi5NgEp0bWNzIHDj0wUEorxSLRV/wRdPuexvpAZjr+shE6+j17OmyoRsqSiC8CijMQFTMA== X-Received: by 2002:a05:6000:26c5:b0:427:580:99a7 with SMTP id ffacd0b85a97d-429bd6b222dmr2082292f8f.59.1761899241764; Fri, 31 Oct 2025 01:27:21 -0700 (PDT) Received: from localhost (109-81-31-109.rct.o2.cz. [109.81.31.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c1142e7dsm2242752f8f.17.2025.10.31.01.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 01:27:21 -0700 (PDT) Date: Fri, 31 Oct 2025 09:27:14 +0100 From: Michal Hocko To: Ankit Agrawal Cc: Andrew Morton , Aniket Agashe , Vikram Sethi , Jason Gunthorpe , Matt Ochs , Shameer Kolothum , "linmiaohe@huawei.com" , "nao.horiguchi@gmail.com" , "david@redhat.com" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "tony.luck@intel.com" , "bp@alien8.de" , "rafael@kernel.org" , "guohanjun@huawei.com" , "mchehab@kernel.org" , "lenb@kernel.org" , "kevin.tian@intel.com" , "alex@shazbot.org" , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Zhi Wang , Dheeraj Nigam , Krishnakant Jaju , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-edac@vger.kernel.org" , "Jonathan.Cameron@huawei.com" , "ira.weiny@intel.com" , "Smita.KoralahalliChannabasappa@amd.com" , "u.kleine-koenig@baylibre.com" , "peterz@infradead.org" , "linux-acpi@vger.kernel.org" , "kvm@vger.kernel.org" Subject: Re: [PATCH v4 2/3] mm: handle poisoning of pfn without struct pages Message-ID: References: <20251026141919.2261-1-ankita@nvidia.com> <20251026141919.2261-3-ankita@nvidia.com> <20251027172620.d764b8e0eab34abd427d7945@linux-foundation.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed 29-10-25 03:15:08, Ankit Agrawal wrote: > >> +static void add_to_kill_pfn(struct task_struct *tsk, > >> +                         struct vm_area_struct *vma, > >> +                         struct list_head *to_kill, > >> +                         unsigned long pfn) > >> +{ > >> +     struct to_kill *tk; > >> + > >> +     tk = kmalloc(sizeof(*tk), GFP_ATOMIC); > >> +     if (!tk) > >> +             return; > > > > This is unfortunate.  GFP_ATOMIC is unreliable and we silently behave > > as if it worked OK. > > Got it. I'll mark this as a failure case. why do you need to batch all processes and kill them at once? Can you just kill one by one? -- Michal Hocko SUSE Labs