From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BF0328031C for ; Tue, 4 Nov 2025 17:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762279134; cv=none; b=FYEZoYdqo5XAioIsA0JnBh0t9aurvm6i1J9unaZZW4mKwfCwS5HY2BfKyG1e5oDEppwO3iVzs+/zIRa7BjnPK5ywCLuKkc2DPBfWYpjSa7xWVo76BhpTQuf5izB+NefuMgKxzLShodCWUNoWS/zRe5NvmyP2LYzmJjl2BDDtMRg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762279134; c=relaxed/simple; bh=M8hteS49kDBBnmC972KvrKrHthGw8+MuUqHN8fekdI0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=rGkLZrI1xE7YAafoPoYNMXljjri13hb8Ck/DCIT78XvwODJGEb2F0Y2boY5NojVgQJuMvwK00JMZ/PH5lkw8+5QheHkP0rdn2Z8lNogOOmdQMH1ai9rX0fPyKVEckfbueO1rPxZCuvpgRRDWHm66a73soMMXV5LGYI5MaFv7hmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=g2kNi4TS; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g2kNi4TS" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-294ecd3fdd4so69810785ad.3 for ; Tue, 04 Nov 2025 09:58:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762279133; x=1762883933; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=sTsoW0ur76ePtMo7HcuL4NYZdCCENhkyANXlSBYjqrA=; b=g2kNi4TS0fhFySox+vfyeebQMICDYfFWWT16X4bYfp/CkS5n94JN6/0S7IOoRkQk06 qgRwW+mxLsg0bmaMSvvpxawCzdNLpQZY7nwFXNdCTapkuBKVn1k+nzQu6XgcknhTeVIe mAky9pOZHG76ics0INdEgmUiKSspTqqo+vVnVE0QJ7amB4CRut6Wr3YD5SVesImRX/OZ oh8S9lQkG8QvWhtKBLOVDt56/xX9buqOypkdNm7/wb4UX8ygiM3maiAKI2nx6oLYsl2Q KCW6qoL0fyocQ3UO+vq8Q8eyJE+IM2mPIr/iDdDs8lQ2kOxwr75sPeEZQKpQGAe86ZZu 3yfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762279133; x=1762883933; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sTsoW0ur76ePtMo7HcuL4NYZdCCENhkyANXlSBYjqrA=; b=BTuP2TxLHiYDApcSK5tPefs0kZ4UhYnOcual10qN8PDoUHT7BbmpT2WX27srxFRybK GshJKStpko5zjgqr79FLFV/BkAC6wEUwK6g9NUQG463Gu5ZM4VMhV+6IrosvN2Zz0fdT u0LAEXQuzkc0OF1G45dEleBDqOb5IIsnBidDh8ZxNoEv975KjTkZ6rd3UaJf90LEBRLr ePkQk9rHtrGt+kYcDE68HYc38I+Vw+fbq9Xp001vdRGfJp2ITMClqlUslgQaw8VOd/RG 3wPFE1mBtH/gW+Nu7fFvdsZZaeumLsgkGnfx8mr1FAhgAtRB41MiXGj2avYnBIg6cDvB SlVQ== X-Forwarded-Encrypted: i=1; AJvYcCXwLuhxb4YHFwdraRWMQxY9piE1La5mVtxmtM6UXeX6RNToJWI1B+0X48dBtG1xQU5x7+g=@vger.kernel.org X-Gm-Message-State: AOJu0YzWZM0tX5Sw4VV1vkD2scR5IQ4sWChqLt7A2zvpB/BHOQkoh0t+ YF/HjK3Fh3/gp9xbe/JD8sGLFsBFltjhH2EnNX5KPKc2PQdktX4fa3D1UhZLyvKhcoYr1ul3kgq Lm7vtGw== X-Google-Smtp-Source: AGHT+IHo6/KH4EkXGXP40ZLufzSsgW7yh9/qU70MiYfxQR70XqX2CyQgg6697l1DVe5Ug6vhYlNvwdh/uJA= X-Received: from plok6.prod.google.com ([2002:a17:903:3bc6:b0:269:8ca7:6998]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f609:b0:295:4d97:84dd with SMTP id d9443c01a7336-2962adb8f9cmr4243385ad.51.1762279132506; Tue, 04 Nov 2025 09:58:52 -0800 (PST) Date: Tue, 4 Nov 2025 09:58:48 -0800 In-Reply-To: <725c68f2607ad2d4f742fd749ea517a98d669384.camel@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251030200951.3402865-1-seanjc@google.com> <725c68f2607ad2d4f742fd749ea517a98d669384.camel@intel.com> Message-ID: Subject: Re: [PATCH v4 00/28] KVM: x86/mmu: TDX post-populate cleanups From: Sean Christopherson To: Rick P Edgecombe Cc: "chenhuacai@kernel.org" , "frankja@linux.ibm.com" , "maz@kernel.org" , "borntraeger@linux.ibm.com" , "pjw@kernel.org" , "aou@eecs.berkeley.edu" , "kas@kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "maddy@linux.ibm.com" , "palmer@dabbelt.com" , "imbrenda@linux.ibm.com" , "zhaotianrui@loongson.cn" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "kvm@vger.kernel.org" , "linux-coco@lists.linux.dev" , Kai Huang , Yan Y Zhao , "michael.roth@amd.com" , "binbin.wu@linux.intel.com" , Ira Weiny , "loongarch@lists.linux.dev" , "ackerleytng@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kvm-riscv@lists.infradead.org" , Vishal Annapurve , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "x86@kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 31, 2025, Rick P Edgecombe wrote: > On Thu, 2025-10-30 at 13:09 -0700, Sean Christopherson wrote: > > v4: > > =C2=A0- Collect reviews/acks. > > =C2=A0- Add a lockdep assertion in kvm_tdp_mmu_map_private_pfn(). [Yan] > > =C2=A0- Wrap kvm_tdp_mmu_map_private_pfn() with CONFIG_KVM_GUEST_MEMFD= =3Dy. [test bot] > > =C2=A0- Improve (or add) comments. [Kai, and probably others] > > =C2=A0- s/spte/mirror_spte to make it clear what's being passed in > > =C2=A0- Update set_external_spte() to take @mirror_spte as well. [Yan] > > =C2=A0- Move the KVM_BUG_ON() on tdh_mr_extend() failure to the end. [R= ick] > > =C2=A0- Take "all" the locks in tdx_vm_ioctl(). [Kai] > > =C2=A0- WARN if KVM attempts to map SPTEs into an invalid root. [Yan] > > =C2=A0- Use tdx_flush_vp_on_cpu() instead of tdx_disassociate_vp() when= freeing > > =C2=A0=C2=A0 a vCPU in VCPU_TD_STATE_UNINITIALIZED state. [Yan] >=20 > Do you want someone to follow up with a v2 of this after the series lands= ? (with > Binbin's verbiage comments incorporated) Feel free to send a v2 now. Or just reply to Binbin's mail with the update= d comment. > https://lore.kernel.org/kvm/20251028002824.1470939-1-rick.p.edgecombe@int= el.com/#t