From: Chao Gao <chao.gao@intel.com>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Allocate/free user_return_msrs at kvm.ko (un)loading time
Date: Mon, 10 Nov 2025 15:05:31 +0800 [thread overview]
Message-ID: <aRGOu3eJoRnsaV+n@intel.com> (raw)
In-Reply-To: <20251108013601.902918-1-seanjc@google.com>
>-static int kvm_init_user_return_msrs(void)
>+static void kvm_destroy_user_return_msrs(void)
> {
>- user_return_msrs = alloc_percpu(struct kvm_user_return_msrs);
>- if (!user_return_msrs) {
>- pr_err("failed to allocate percpu user_return_msrs\n");
>- return -ENOMEM;
>- }
>+ int cpu;
>+
>+ for_each_possible_cpu(cpu)
>+ WARN_ON_ONCE(per_cpu(user_return_msrs, cpu).registered);
Could this warning be triggered if the forced shutdown path didn't
unregister the user return callback (i.e., with the patch [*] applied),
and then vendor modules got unloaded immediately after the forced shutdown
(before the CPU exits to the userspace)?
[*]: https://lore.kernel.org/kvm/20251030191528.3380553-4-seanjc@google.com/
next prev parent reply other threads:[~2025-11-10 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-08 1:36 [PATCH] KVM: x86: Allocate/free user_return_msrs at kvm.ko (un)loading time Sean Christopherson
2025-11-10 7:05 ` Chao Gao [this message]
2025-11-13 21:02 ` Sean Christopherson
2025-11-21 18:55 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRGOu3eJoRnsaV+n@intel.com \
--to=chao.gao@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox