Re: [PATCH 02/12] vfio: selftests: Allow passing multiple BDFs on the command line

[David Matlack <dmatlack@google.com>]

On 2025-11-10 09:15 AM, Raghavendra Rao Ananta wrote:
> On Thu, Oct 9, 2025 at 4:56 AM David Matlack <dmatlack@google.com> wrote:
> > -const char *vfio_selftests_get_bdf(int *argc, char *argv[])
> > +static char **vfio_selftests_get_bdfs_cmdline(int *argc, char *argv[], int *nr_bdfs)
> >  {
> > -       char *bdf;
> > +       int i;
> > +
> > +       for (i = *argc - 1; i > 0 && is_bdf(argv[i]); i--)
> > +               continue;
> > +
> > +       i++;
> > +       *nr_bdfs = *argc - i;
> > +       *argc -= *nr_bdfs;
> Just curious, why update 'argc' (I know we had this before as well)?

The idea is to parse out the BDFs from the command line, and then let
the test parse the rest of the command line. So we modify argc to remove
the BDFs from the command line, so the test doesn't try to use them for
something else.

> > +static char **vfio_selftests_get_bdfs_env(int *argc, char *argv[], int *nr_bdfs)
> > +{
> > +       static char *bdf;
> >
> >         bdf = getenv("VFIO_SELFTESTS_BDF");
> > -       if (bdf) {
> > -               VFIO_ASSERT_TRUE(is_bdf(bdf), "Invalid BDF: %s\n", bdf);
> > -               return bdf;
> > -       }
> > +       if (!bdf)
> > +               return NULL;
> > +
> > +       *nr_bdfs = 1;
> > +       VFIO_ASSERT_TRUE(is_bdf(bdf), "Invalid BDF: %s\n", bdf);
> > +
> > +       return &bdf;
> > +}
> nit: Since vfio_selftests_get_bdfs_env() still returns a single BDF,
> perhaps add a comment, as it contradicts the plurality in the
> function's name?

Good point. I'll drop the plurality and make this function only return a
single BDF.