Re: [PATCH v2 4/5] guest_memfd: add support for userfaultfd minor mode

Nikita Kalyazin
2025-11-27T11:20:02Z

On 27/11/2025 10:36, Mike Rapoport wrote:
> On Wed, Nov 26, 2025 at 04:49:31PM +0000, Nikita Kalyazin wrote:
>> On 25/11/2025 18:38, Mike Rapoport wrote:
>>> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>>>
>>> +#ifdef CONFIG_USERFAULTFD
>>> +static struct folio *kvm_gmem_get_folio(struct inode *inode, pgoff_t pgoff)
>>
>> We have to name it differently, otherwise it clashes with the existing one
>> in this file.
>
> It's all David's fault! ;-P
> How about kvm_gmem_get_prepared_folio() ?

I'm afraid it may not be ideal due to preparedness tracking being
removed from guest_memfd at some point [1]. Would it be too bad to add
an indication to userfaultfd in the name somehow given that it's already
guarded by the config?

[1]
https://lore.kernel.org/linux-coco/20251113230759.1562024-1-michael.roth@amd.com

>
> --
> Sincerely yours,
> Mike.