Re: [PATCH v2 5/5] KVM: selftests: test userfaultfd minor for guest_memfd

Mike Rapoport
2025-11-27T10:39:08Z

On Wed, Nov 26, 2025 at 04:49:46PM +0000, Nikita Kalyazin wrote:
> On 25/11/2025 18:38, Mike Rapoport wrote:
> > From: Nikita Kalyazin <kalyazin@amazon.com>
> >
> > +static void test_uffd_minor(int fd, size_t total_size)
> > +{
> > + struct uffdio_api uffdio_api = {
> > + .api = UFFD_API,
> > + .features = UFFD_FEATURE_MINOR_GENERIC,
>
> Should it be UFFD_FEATURE_MINOR_SHMEM instead? UFFD_FEATURE_MINOR_GENERIC
> was removed in the v1.

I'll drop .features completely, the checks in UFFDIO_REGISTER are
sufficient.

--
Sincerely yours,
Mike.