Re: [PATCH v2 5/7] x86/virt/tdx: KVM: Consolidate TDX CPU hotplug handling

dan.j.williams
2025-12-09T04:19:11Z

Sean Christopherson wrote:
> From: Chao Gao <chao.gao@intel.com>
>
> The core kernel registers a CPU hotplug callback to do VMX and TDX init
> and deinit while KVM registers a separate CPU offline callback to block
> offlining the last online CPU in a socket.
>
> Splitting TDX-related CPU hotplug handling across two components is odd
> and adds unnecessary complexity.
>
> Consolidate TDX-related CPU hotplug handling by integrating KVM's
> tdx_offline_cpu() to the one in the core kernel.
>
> Also move nr_configured_hkid to the core kernel because tdx_offline_cpu()
> references it. Since HKID allocation and free are handled in the core
> kernel, it's more natural to track used HKIDs there.

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>