From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9EDB230BEC for ; Thu, 8 Jan 2026 14:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767882447; cv=none; b=GmZ0HlYKKUDzBi5wcsMVdZM4R42FQ0FeEB798We787c19KzkEWTQ3dzoXJuVWcDzSnKFaNRlHEiE4OPhXJt0HMfCajBggR0o291/axAxWIEHY6k2YG5Gkt4RZVLB5NHTFutZMk5o4DYF1PFnxKX2snTo6a7U7gyhen+qhNnhQT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767882447; c=relaxed/simple; bh=9NRW4Rdf/VUGYmBYvief2R2tb60IwahWPnIEBIYe7so=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZnnzHKXbfi4D9omYCFRm2vEjtUHINly1UMI5N7btSPwJbN3yPxlhLrCJxY7NkgOuG+TIq7FJLZ98o7kqcUH9hk6grQqP3b4+b9lwk3A+IleyDwrEOrgoTHTsdPdrctdDGnr+4XR0gkaFUM6QTp/R3O5EXdOzfzoHTBaO+MokBdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=IS1K2Jn3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=kLJttVFj; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IS1K2Jn3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="kLJttVFj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767882444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MYUfQokxCybKNz25/1oiXAmTT63P9X7nVn3prJ03xRo=; b=IS1K2Jn3TKMrz9zbN6S62Kef1nQn2nsxZGhdfqoQtIv8MYmdkvSJ7tKCoQdVf4238nY1+k Mp0UFEGpxegiRWtLO9xDJkEu1wwKOaJVE4VkSJz9GVyV/zn58MQhZqXRwU+7w/j81nD6sp M/dYbYao6JOV/sFxy44afCe0RPF98Kc= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-pFWjogJUPvqWr2gmvhZ_Ow-1; Thu, 08 Jan 2026 09:27:23 -0500 X-MC-Unique: pFWjogJUPvqWr2gmvhZ_Ow-1 X-Mimecast-MFC-AGG-ID: pFWjogJUPvqWr2gmvhZ_Ow_1767882442 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-b7d282ac8aaso473778366b.2 for ; Thu, 08 Jan 2026 06:27:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767882442; x=1768487242; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=MYUfQokxCybKNz25/1oiXAmTT63P9X7nVn3prJ03xRo=; b=kLJttVFjBCRCqGB9ulYsC/FXY1K+0vqWMPqMeAps2axByIovBiVsupp+B3KlPsVRbp jehbEE7TzZhznJTj3jvy7oimwNgV/vgaTruulZa9jeJfjWSnUlCI1nqg4aSRwpmW8p23 fGUy80BBWKb7q96iV1a7NrGJNe8gzCFE2W3+j0o7kWRZ47lqcfyAmvx1v+Bpogd0KjKc EQLLQM+LHHvTUZAF9vlEytZebFi/6NEQ1itwV2/oIaTbqWoCM2iMIJ8aveEFzWjcb70G igRjHQdX4Yr8/ejMIK8vCQ6vAuAcTulf/gN7lhUxk/7VgFvHRQV2DoeTKfct1nqDa27r g1nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767882442; x=1768487242; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MYUfQokxCybKNz25/1oiXAmTT63P9X7nVn3prJ03xRo=; b=tdXuWfZwGlhRpB5mOE+6rgoW9RGRXsGh2Vd/gzOssJRnNLKfuX2y+L9lYCf/IKuhkS C5sKp2jk1ovR89t9PRrDAgahZn0u5LXP4GiUQBE6dpKntqMOg/qWz3aMO8JTFurvH6mE 75eotEHJ3TS8mlpP+xDDTsGy3ebruLMlXdzO4oDiu0FiZUqVQ7br+xX43LKWySRnsU9U iig/6MRvyZalblQCUb5vMOfCW9u8FVL2SnzrgnrL8PNWiiakqDF4ehbMZBG5wxMdbN9v MTrQYZQpfQJUoXJjgT2UA6ig9hP3oCdkad/ve/LtAdf3eC/1HZV8hrN4iiSWnoqBgiCs t0jg== X-Forwarded-Encrypted: i=1; AJvYcCVjpFefPBlG60WqBR+5GHmAjL9dxXiee680gPd2ZyDBFYVd9MYdSJ27uvpIG7JqLpJCrwY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywiy9EDk6HDRNkOUg0nX27zYHsP7YmYRZfppaQVLmJJiSRCsMJg iBk7V8wXSsh6z6anf2DtduhI5Rd2D7H+iX1tbGbWn4qIInhhVwtF8/244wn9nTev+CbvD9m+Ovg xFxP/0PQLowFjwo8/lsJdzDIGYlC4Z2TwbxEDQNAZDfCcHyoiRj/Qkg== X-Gm-Gg: AY/fxX7Y7hM5IDOwDVknHnSCiQDIFLcchFA41jYv1Re/AxBHw/6UnhAP3zSMp8vpf9S sjAbLNNutycw4Ry0YB0lThLNGBDGkYmJ1GluMa6G+0l/Vr5zYMJ/stG8G2c3G7E1iRcpBsyQb6u G6sgarwGxq/XFjtQuiBPgYZ0SE532AFcSyXLekVk9DjDryP8GkrrdvQkv/hv9OExDpYy60fZ0e/ J92QunNH59kpdUgPcoYxQ9Jnrfzneenuva2LEIBxflIUrx/Im2L8rkahdS1qZZqifZglGOwYm/T 7lvqcVZnhMFF9FNT4OHUO9fEBLMD3kFlqmRwxsRewB1oKeS9ne0Fp1rRVYTYNneBPWLXlDfKU3/ Nc2rAFWtAPeI/BrGc X-Received: by 2002:a17:907:1c09:b0:b79:eaf6:8f44 with SMTP id a640c23a62f3a-b8444f4f056mr726210766b.40.1767882441990; Thu, 08 Jan 2026 06:27:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IEJ6L4DqIanAXgw2ktUhRyngdJSX+H/rkKSIqtNQ9+qAgBUByhlaCVegL7JEtxsi+D3mXwYrw== X-Received: by 2002:a17:907:1c09:b0:b79:eaf6:8f44 with SMTP id a640c23a62f3a-b8444f4f056mr726205266b.40.1767882441415; Thu, 08 Jan 2026 06:27:21 -0800 (PST) Received: from sgarzare-redhat ([193.207.223.215]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4cfd97sm787982066b.36.2026.01.08.06.27.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jan 2026 06:27:20 -0800 (PST) Date: Thu, 8 Jan 2026 15:27:04 +0100 From: Stefano Garzarella To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 13/15] vsock/virtio: reorder fields to reduce padding Message-ID: References: <20260108091514-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20260108091514-mutt-send-email-mst@kernel.org> On Thu, Jan 08, 2026 at 09:17:49AM -0500, Michael S. Tsirkin wrote: >On Thu, Jan 08, 2026 at 03:11:36PM +0100, Stefano Garzarella wrote: >> On Mon, Jan 05, 2026 at 03:23:41AM -0500, Michael S. Tsirkin wrote: >> > Reorder struct virtio_vsock fields to place the DMA buffer (event_list) >> > last. This eliminates the padding from aligning the struct size on >> > ARCH_DMA_MINALIGN. >> > >> > Signed-off-by: Michael S. Tsirkin >> > --- >> > net/vmw_vsock/virtio_transport.c | 8 +++++--- >> > 1 file changed, 5 insertions(+), 3 deletions(-) >> > >> > diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c >> > index ef983c36cb66..964d25e11858 100644 >> > --- a/net/vmw_vsock/virtio_transport.c >> > +++ b/net/vmw_vsock/virtio_transport.c >> > @@ -60,9 +60,7 @@ struct virtio_vsock { >> > */ >> > struct mutex event_lock; >> > bool event_run; >> > - __dma_from_device_group_begin(); >> > - struct virtio_vsock_event event_list[8]; >> > - __dma_from_device_group_end(); >> > + >> > u32 guest_cid; >> > bool seqpacket_allow; >> > >> > @@ -76,6 +74,10 @@ struct virtio_vsock { >> > */ >> > struct scatterlist *out_sgs[MAX_SKB_FRAGS + 1]; >> > struct scatterlist out_bufs[MAX_SKB_FRAGS + 1]; >> > + >> >> IIUC we would like to have these fields always on the bottom of this struct, >> so would be better to add a comment here to make sure we will not add other >> fields in the future after this? > >not necessarily - you can add fields after, too - it's just that >__dma_from_device_group_begin already adds a bunch of padding, so adding >fields in this padding is cheaper. > Okay, I see. > >do we really need to add comments to teach people about the art of >struct packing? I can do it later if you prefer, I don't want to block this work, but yes, I'd prefer to have a comment because otherwise I'll have to ask every time to avoid, especially for new contributors xD > >> Maybe we should also add a comment about the `ev`nt_lock` requirement >> we >> have in the section above. >> >> Thanks, >> Stefano > >hmm which requirement do you mean? That `event_list` must be accessed with `event_lock`. So maybe we can move also `event_lock` and `event_run`, so we can just move that comment. I mean something like this: @@ -74,6 +67,15 @@ struct virtio_vsock { */ struct scatterlist *out_sgs[MAX_SKB_FRAGS + 1]; struct scatterlist out_bufs[MAX_SKB_FRAGS + 1]; + + /* The following fields are protected by event_lock. + * vqs[VSOCK_VQ_EVENT] must be accessed with event_lock held. + */ + struct mutex event_lock; + bool event_run; + __dma_from_device_group_begin(); + struct virtio_vsock_event event_list[8]; + __dma_from_device_group_end(); }; static u32 virtio_transport_get_local_cid(void) Thanks, Stefano