From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1085343D7D for ; Mon, 12 Jan 2026 23:21:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768260074; cv=none; b=Ag820Sv5clH7vrsvmXHLYa1zaG+2s29DaS+Q47Kd7Qrg2KAtSk0sbQDTdbsUomcjY282GSGAiBgf1STW+p15u0wEpVTjUL6ORDAnJix0pA9vTXrKksM7PJLtmrj3yREpkzuUkruiMNPJ163cZgFn6r1gpAE+IPCAvfNcP04IHB0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768260074; c=relaxed/simple; bh=7L4AuwoQwpFDKJ+QfvB8n+UzDOCrhQdo2yK39qUc8cI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SQLvuG1LzmuRi5ukZSAcIZ9n6bTfrou+q+1xOVmgNQD+YQXHNwO6svtI9VfHaVhowtYcJ9Ftf3T2RXk2q8DD7QgliVdPn6gDeblXWZ9n5xSQunezLKvGQr4kQnOjoheG/vUZ8XC/qd/bgpLxoZPMlom64Ig1+njG2FpDHt5LqwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bnwgFz9v; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bnwgFz9v" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-6467b7c3853so4754256d50.0 for ; Mon, 12 Jan 2026 15:21:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768260072; x=1768864872; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jtoLeYJaY/2ODhxZmDU22B5G0cJLjLhdpG7Ly3b1Aek=; b=bnwgFz9vs89U9SsRGckgS2XN4MyfrbVDR1dCDH2HClRdZmlUE/XHYWgUfKlFFk7trh J6XZTAZzoGBhvbI4xJTxV1ZlAMe+gZD9TUlsc8FDEJ2e3lcvL9OJUz77cb2dS3dm08lk u2qddLyeSNf5u8ER8dCX9RfiSxdfKnFtX6LXWI7j8N7Ip7FzH0EzzstIx9pBLXXLaat8 CwVf2+Tygfn26guy/NAElPnU5Tm1t/yJV0FtgnTQZkSP1AA0vKKOyoiEpcxQL7ci4jjb r8vFDHLO21Kg9zpMwL6+pmEgfPFF0R8ICp5V8V0pN0p4BaEx7BisktOLUi7hv8LBlYKq HO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768260072; x=1768864872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jtoLeYJaY/2ODhxZmDU22B5G0cJLjLhdpG7Ly3b1Aek=; b=S9nMPfgO68VJBrD6aUyaF/Fbr7rgX4RZ9yBQ+pZz6gYjJoktzdr2xW3yFvR8sXjog9 MyYHCRaHtKtY1SOczlYdJSPCdC3BEMB94P5MctG6N6M+Au+rrsv02fYxO+/lVjiGXb7m w9sC7epYJMDc+YhgNKoTGCHHsfyAR0fKkZneTIDREJXYRBvGyNLJShea23Zz+KbfktEd ZgwPQVUdZDCgbWoDOZUpCL0Wnm/xBRBH4Ov+X2XvXoubAVyqptvRUbFSawovvWoQ1Shf QDtNqCZdGxTzJkzYG+aqhcIeKEQqqK99OLOhE+veN5KwitFUxOy1NIa/lETFeeZpg0P0 3dsw== X-Forwarded-Encrypted: i=1; AJvYcCU7AG9hDPlIVeLcHD09Lgg2N2wwfJGuZkcSS+d2jFzif5Wbb+fwNSQwVshwi92IKXj/q3c=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk+v+OqmkuIUOLZArvcxLs34i9wnVyjWHKvrkE4ZRQ9SmceLkP 211uX20Q9PK3V5LU+Er+wr3Nzyq5WA7OZStOdGbPg3hQ0bPQceUI1ilK X-Gm-Gg: AY/fxX7BlNgTcOYoo5A4+VxjQrGVGGCYNLrZ1qN0MZDOJqFM5uPtrvlqwLSEM0Gmglt Z3ifrvlUPlv4JxtJbO4J2d+tBbNqQVkIhIMS4A0FCOFO30h95rjZgav+xlKh6y5D7vEQTBG5I1g S1L3acGZDlsJ/swlY2eBA+CxjfdxlVCp+pDWwCBfHvdf1iz8fwMXWmxIsyv6XzXJZKljwHaow2k qFGJihMMeUl6WwfaseTDcEyGvJ8OGji8quYIQTDX9I6gePh/m1wu5eE5xR+Pm3783AmCwjvIakL E0tNna68yMednpHg95eLqJTuKzryDqyfrU0MXE/pFl4DyIFoDg6izh+ci4vjUJAW/wz/gGK0zk1 cwHzkhLsZ8oj39GnIFiQoJM2FXaeQDXdmOTaIekNqEN7ryd3GHuhNe/TdZNKoqdfRQq+vM4kn23 o5mPipAi5VFXNUY4ZtNMnES0NxvecVn/MW9g== X-Google-Smtp-Source: AGHT+IGPR3yHTofTNuLsmIGRF/vxUZuNpadx2Jh/erk6LsyOgtC+kyjO5yp6nCVt3XNr+Y0sCRmwIQ== X-Received: by 2002:a05:690e:4085:b0:645:5297:3e65 with SMTP id 956f58d0204a3-64716b35ea6mr16989024d50.11.1768260071815; Mon, 12 Jan 2026 15:21:11 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:2::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-790aa6e12ffsm74065287b3.53.2026.01.12.15.21.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jan 2026 15:21:11 -0800 (PST) Date: Mon, 12 Jan 2026 15:21:09 -0800 From: Bobby Eshleman To: "Michael S. Tsirkin" Cc: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Stefan Hajnoczi , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , Bobby Eshleman Subject: Re: [PATCH RFC net-next v13 03/13] virtio: set skb owner of virtio_transport_reset_no_sock() reply Message-ID: References: <20251223-vsock-vmtest-v13-0-9d6db8e7c80b@meta.com> <20251223-vsock-vmtest-v13-3-9d6db8e7c80b@meta.com> <20260111014500-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260111014500-mutt-send-email-mst@kernel.org> On Sun, Jan 11, 2026 at 01:46:43AM -0500, Michael S. Tsirkin wrote: > On Tue, Dec 23, 2025 at 04:28:37PM -0800, Bobby Eshleman wrote: > > From: Bobby Eshleman > > > > Associate reply packets with the sending socket. When vsock must reply > > with an RST packet and there exists a sending socket (e.g., for > > loopback), setting the skb owner to the socket correctly handles > > reference counting between the skb and sk (i.e., the sk stays alive > > until the skb is freed). > > > > This allows the net namespace to be used for socket lookups for the > > duration of the reply skb's lifetime, preventing race conditions between > > the namespace lifecycle and vsock socket search using the namespace > > pointer. > > > > Reviewed-by: Stefano Garzarella > > Signed-off-by: Bobby Eshleman > > --- > > Changes in v11: > > - move before adding to netns support (Stefano) > > can you explain about the revert please? > I looked at feedback from Stefano and all he said > aparently was not to break bisect. The patch that brings support into vsock_loopback depends on this one to avoid a introducing a race condition, so it should come before that one. Best, Bobby