From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"Shuah Khan" <shuah@kernel.org>, "Joerg Roedel" <joro@8bytes.org>,
"Avi Kivity" <avi@redhat.com>, "Alexander Graf" <agraf@suse.de>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"David Hildenbrand" <david@kernel.org>,
"Cathy Avery" <cavery@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 04/10] KVM: x86: nSVM: Restore L1's PAT on emulated #VMEXIT from L2 to L1
Date: Wed, 14 Jan 2026 13:26:02 -0800 [thread overview]
Message-ID: <aWgJ6qDGJA9L71g8@google.com> (raw)
In-Reply-To: <20260113003016.3511895-5-jmattson@google.com>
On Mon, Jan 12, 2026, Jim Mattson wrote:
> KVM doesn't implement a separate G_PAT register to hold the guest's
> PAT in guest mode with nested NPT enabled. Consequently, L1's IA32_PAT
> MSR must be restored on emulated #VMEXIT from L2 to L1.
>
> Note: if L2 uses shadow paging, L1 and L2 share the same IA32_PAT MSR.
>
> Signed-off-by: Jim Mattson <jmattson@google.com>
> ---
> arch/x86/kvm/svm/nested.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/x86/kvm/svm/nested.c b/arch/x86/kvm/svm/nested.c
> index c751be470364..9aec836ac04c 100644
> --- a/arch/x86/kvm/svm/nested.c
> +++ b/arch/x86/kvm/svm/nested.c
> @@ -1292,6 +1292,16 @@ int nested_svm_vmexit(struct vcpu_svm *svm)
> kvm_rsp_write(vcpu, vmcb01->save.rsp);
> kvm_rip_write(vcpu, vmcb01->save.rip);
>
> + /*
> + * KVM doesn't implement a separate guest PAT
> + * register. Instead, the guest PAT lives in vcpu->arch.pat
> + * while in guest mode with nested NPT enabled. Hence, the
> + * IA32_PAT MSR has to be restored from the vmcb01 g_pat at
> + * #VMEXIT.
Wrap closer to 80 chars.
> + */
> + if (nested_npt_enabled(svm))
> + vcpu->arch.pat = vmcb01->save.g_pat;
> +
> svm->vcpu.arch.dr7 = DR7_FIXED_1;
> kvm_update_dr7(&svm->vcpu);
>
> --
> 2.52.0.457.g6b5491de43-goog
>
next prev parent reply other threads:[~2026-01-14 21:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 0:29 [PATCH 00/10] KVM: x86: nSVM: Improve PAT virtualization Jim Mattson
2026-01-13 0:29 ` [PATCH 01/10] KVM: x86: nSVM: Add g_pat to fields copied by svm_copy_vmrun_state() Jim Mattson
2026-01-13 0:29 ` [PATCH 02/10] KVM: x86: nSVM: Add VALID_GPAT flag to kvm_svm_nested_state_hdr Jim Mattson
2026-01-14 21:25 ` Sean Christopherson
2026-01-13 0:29 ` [PATCH 03/10] KVM: x86: nSVM: Handle legacy SVM nested state in SET_NESTED_STATE Jim Mattson
2026-01-13 0:29 ` [PATCH 04/10] KVM: x86: nSVM: Restore L1's PAT on emulated #VMEXIT from L2 to L1 Jim Mattson
2026-01-14 21:26 ` Sean Christopherson [this message]
2026-01-13 0:30 ` [PATCH 05/10] KVM: x86: nSVM: Cache g_pat in vmcb_save_area_cached Jim Mattson
2026-01-13 0:30 ` [PATCH 06/10] KVM: x86: nSVM: Add validity check for VMCB12 g_pat Jim Mattson
2026-01-13 0:30 ` [PATCH 07/10] KVM: x86: nSVM: Set vmcb02.g_pat correctly for nested NPT Jim Mattson
2026-01-13 0:30 ` [PATCH 08/10] KVM: x86: nSVM: Save gPAT to vmcb12.g_pat on emulated #VMEXIT from L2 to L1 Jim Mattson
2026-01-13 0:30 ` [PATCH 09/10] KVM: x86: nSVM: Fix assignment to IA32_PAT from L2 Jim Mattson
2026-01-13 0:30 ` [PATCH 10/10] KVM: selftests: nSVM: Add svm_nested_pat test Jim Mattson
2026-01-14 0:31 ` [PATCH 00/10] KVM: x86: nSVM: Improve PAT virtualization Jim Mattson
2026-01-14 21:28 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aWgJ6qDGJA9L71g8@google.com \
--to=seanjc@google.com \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=bp@alien8.de \
--cc=cavery@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox