From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 671B72DCBF4 for ; Wed, 21 Jan 2026 07:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768979418; cv=none; b=d/BbmtrBwA2xy234W0YLrVfKzwNVw4uq98WEkb+iElSPnK6seAwZkZD0QZSy50mzD9c/DuidwMcG7nqN7KQ7R4Ov2j+2fguudX0sSL7AMufMUyETXWbb2WuZ5Tm4tssuj2i2Z7EEcxV/H1jKqywor3x+ZPSBbKKt669L8+BhYhk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768979418; c=relaxed/simple; bh=BjEonW32c5YOMq0hqq7Xvkwknsp7bLBK5sRV2QqHoDQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eJ1oarnWGiM6Lmiuo904bB8biC243tSFm6lQM/ggn3BjX7me3ijh+keLNPYGDopUkPZ5B+Vy+aUyv1PqUOK5lOlWsL/UNGniaLasmvBfBm9COI1De/t4Rrq2qNMokRZp4uI+k5FZoXlkq9ncy3yYJLhRbsj0cFm5w3AleypZe+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NlRsW1kb; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NlRsW1kb" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-50150bc7731so93824431cf.1 for ; Tue, 20 Jan 2026 23:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768979415; x=1769584215; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dr4ikofTW2/lOylz+wqvxKyTxo3lmrOIQRlztmAAggk=; b=NlRsW1kbHyH/Jv0g8eJ81NgtPMnJY+hj8B38WcVail7bOM8BPbvG1z7rCfFtx1LoyT 0mtKifV31PvURdD57hK4toj7jsmT5dcHTUuBlKJpADaMaFdoDDkR5XHXcPQ+yT2BsUUy Ung3l7MpkH85wQc4O/9tI8DOeUFj4lOSUq7WaaNZ6dc+Sromd25ZFEH18Iy3S5e0FtRY sc0NXEs1Lr7sPQ7Tbw2bnOGunPJU3OOtrCzGbyTx6OiHMpFL+NV/Sh9NQ+WVdrohgGT/ TIuhZC3e6t4chbPEn038bo01tYCtIaqkmLbQNKRC35yM4H3m220lgDRN7/mGcOWUgm3Q jJAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768979415; x=1769584215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dr4ikofTW2/lOylz+wqvxKyTxo3lmrOIQRlztmAAggk=; b=E0sVChlOEjBcpYhxt+ylcxms/ekaVAqO5S9l4sU1W3vqfD14qnU0uVchgwusOK9jTF evHBgw2gLz8B3MYrM9vTS5zwlOsItM0zrhkBwQQnHKYtAWK9l+An77D2wprMRt+alGVK pPC+k4Msad6CIAJWjvIGpXsV6sqAvFurnCC6A3MDsUTCTzwe/9agKISzabV7F3rtiCN5 tj69Q+jWGL5u/ZPL7wiaE7YIaY2egm9UTmcGPViXVTJkJil54bd6AcwTO+UoRFBh0Otu vHTPzHikn4+14+mCLHQgaVgGTcl+r9hMlIMFnV1D/8w+XihxsbYu69vXRKO73KtjssrT sxSw== X-Forwarded-Encrypted: i=1; AJvYcCVegVNU6Gf0XmqEJ+0C1oLf1DFOMaZ+rWxe2FYdaeZdBXcUXX59gDIZRzJi03ZNyxPgDwU=@vger.kernel.org X-Gm-Message-State: AOJu0YwOMhwneUibmTegSd5CHpwYt4vJVg9sFLtX7j7IlPPIb/Ke2Ri0 vbCCRXede9HplwnM85kYxTIfp4QPUc0rc/pFiZmXrEU/lYsXRo7yAdQ7qUQq4A== X-Gm-Gg: AZuq6aKKSPQE914YVyX2s8F3SWLPh0mYgKufEMpWyHQikLzzkPZjPYYAYH//j5wz5Gq zCxM4Hz10rlGW3ZPbo9qpl9/uaj+osE/iXj0zJaeE/hpd9FRJ1H0ASlXQP46TdMWk725za43zMM DZMQBfI+pDKifrBJ88qFRJfwQaigvIpIh3LHkjPxbip5mxbdtqRRNVSQzFXhYULKMVxB6DnGcxn 0asripZK5Z4nIm4tIh2dyBUzTm9i8AkBembU5D2vvN2sNr5R/eLqOPbr8asXKPl1fnSXxSN8VgB 0kK+GjcbzEc3HbXHKJB02uSnmXYabFt9xmeQNYmuutIz0oKJHP8OdZB3TPzl2cIk3JNHyOvc4DR b9TC3Q086RfEWIHUhQamYl/GoWuklb3CbjzdzOmsWJ3KR6uT2fNNImkg0yT4gjPIQ+LbyA1WeQ2 CLDY6UKLTN3JjtEwLv3efbDTFd/fAUef9KT4BljoBdQa8e0Q== X-Received: by 2002:a05:690c:ec4:b0:788:1086:8843 with SMTP id 00721157ae682-793c66b7cd1mr130884437b3.2.1768972588159; Tue, 20 Jan 2026 21:16:28 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:74::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-793c6888b83sm60922327b3.48.2026.01.20.21.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jan 2026 21:16:27 -0800 (PST) Date: Tue, 20 Jan 2026 21:16:26 -0800 From: Bobby Eshleman To: Jakub Kicinski Cc: sgarzare@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mst@redhat.com, horms@kernel.org, bobbyeshleman@meta.com, corbet@lwn.net, xuanzhuo@linux.alibaba.com, haiyangz@microsoft.com, jasowang@redhat.com, linux-hyperv@vger.kernel.org, pabeni@redhat.com, kys@microsoft.com, vishnu.dasa@broadcom.com, longli@microsoft.com, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, stefanha@redhat.com, berrange@redhat.com, decui@microsoft.com, bryan-bt.tan@broadcom.com, eperezma@redhat.com, wei.liu@kernel.org, davem@davemloft.net, shuah@kernel.org, bcm-kernel-feedback-list@broadcom.com, edumazet@google.com, virtualization@lists.linux.dev, sargun@sargun.me Subject: Re: [net-next,v15,06/12] selftests/vsock: prepare vm management helpers for namespaces Message-ID: References: <20260116-vsock-vmtest-v15-6-bbfd1a668548@meta.com> <20260121025420.1999992-2-kuba@kernel.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260121025420.1999992-2-kuba@kernel.org> On Tue, Jan 20, 2026 at 06:54:21PM -0800, Jakub Kicinski wrote: > In case you need to respin.. > > This is an AI-generated review of your patch. > For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html > --- > selftests/vsock: prepare vm management helpers for namespaces > > This commit adds namespace support to VM management helpers and wrapper > functions, requiring callers to explicitly pass "init_ns" for the init > namespace. The commit message states "No functional changes for existing > tests. All have been updated to pass 'init_ns' explicitly." > > > diff --git a/tools/testing/selftests/vsock/vmtest.sh b/tools/testing/selftests/vsock/vmtest.sh > > index c2bdc293b94c..1d03acb62347 100755 > > --- a/tools/testing/selftests/vsock/vmtest.sh > > +++ b/tools/testing/selftests/vsock/vmtest.sh > > @@ -135,7 +135,18 @@ del_namespaces() { > > } > > > > vm_ssh() { > > - ssh -q -o UserKnownHostsFile=/dev/null -p ${SSH_HOST_PORT} localhost "$@" > > + local ns_exec > > + > > + if [[ "${1}" == init_ns ]]; then > > + ns_exec="" > > + else > > + ns_exec="ip netns exec ${1}" > > + fi > > + > > + shift > > + > > + ${ns_exec} ssh -q -o UserKnownHostsFile=/dev/null -p "${SSH_HOST_PORT}" localhost "$@" > > + > > return $? > > } > > The vm_ssh() function now expects a namespace as its first argument, but > run_shared_vm_test() still calls vm_ssh without this parameter: > > vm_oops_cnt_before=$(vm_ssh -- dmesg | grep -c -i 'Oops') > vm_warn_cnt_before=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock') > vm_oops_cnt_after=$(vm_ssh -- dmesg | grep -i 'Oops' | wc -l) > vm_warn_cnt_after=$(vm_ssh -- dmesg --level=warn | grep -c -i 'vsock') > > When called as "vm_ssh -- dmesg", the "--" is interpreted as the namespace > argument. Since "--" does not equal "init_ns", the function sets > ns_exec="ip netns exec --" which is invalid. The shift then consumes "--" > and the command becomes "ip netns exec -- ssh ... dmesg" which will fail. > > Interestingly, the v9 version of this patch on lore correctly updated these > calls to pass "init_ns", but this change appears to have been lost between > v9 and v15. The fix for this regression is present later in the series in > commit 3ae984505e00 ("selftests/vsock: add vm_dmesg_{warn,oops}_count() > helpers"). > > [ ... ] Got it, thank you. Best, Bobby