From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906C0397ADA for ; Wed, 21 Jan 2026 17:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769017015; cv=none; b=NBq2JGGsa1EQPax4EqwdWWRJNvnfntvDN7iK4WNAgvHUsecy60g7N9SouoPyLlIEVQZNzAi+2eAV1NksmCC1wpt/Wn1LjMeo0AHshCCi759Xz8lMtV+pEWKsyYfAMuyefx4ppd9CmRRmKehg1UDQCeTlSeGta4chR88dc6JpR3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769017015; c=relaxed/simple; bh=tpGlhPJQhs6K29z4KKdexPB885DZk84UD04BRE7PW+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d309CyZ/KwBfl7TxEkhkViYF2W3yE8oVvQHWCNz25a+DR2KsxOMkM77nkxSfzSrpe+iKSFcw1GCT7h8HgI44ux8lPcareSIV1dYKZ40SWa36JdKQEJOwoZJQ8S3E/QD7fIUSR1Spmn2CjZBm8sMr/Yo/kFzS1TVirh2LR18T1B0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cCCGwsSn; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cCCGwsSn" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-6446d7a8eadso162000d50.0 for ; Wed, 21 Jan 2026 09:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769017010; x=1769621810; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TzQpPNktFvNOdBi7+gsCZqhpBpuEURHyo6CUuqA6z7E=; b=cCCGwsSnRtmoCkAf/NTQtmaBasIN2I58Q15Ljxb++/KX+GhSiZ/IiKr6dn6nIzF/Qz N1/VL2O9l4io6YRGd/QZx2JxTaoe3km0Ux9s5s0uFOVmfZ4DrdIx5tHlEfnGjWlwVbgD Mm0CVcdR9PjNS5Pqba2TWoKXbXQ3hTnsxAta+gcYwXnQvRWGmReuuAxfXK+WVJ42w7xP HHZznvsa4G9/Z1WE3+wi4VZWZxLvSN6FCnjetTk2698CYz0oek0L0+RMSYU9Bj7R0gsa sGeyyBgemZDSTFqHIlYSpvicCd74Ff+j7gr8yCi2LKY2g7AL4vOu1gPNXxgOiG2iYlT6 ijSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769017010; x=1769621810; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TzQpPNktFvNOdBi7+gsCZqhpBpuEURHyo6CUuqA6z7E=; b=jHjGMUx+bK+v2bMrfs5L2V1wXB1emj3lRaOGaWNnG9XevpBwcsQDHx7S2qVO4a8VDB jpruFJS95fG9U84Iel36zpHc7urCHZTDHqb5e/l9jDLkgOpEoX9lfjkNrM8aTdIDF1l0 O2PlCfO0uMIxL9jPeLCbOBrLyyVQHQs2OAejqwJ3WIkLOIsiHKEgT7QpdhoYLMActNrW o6kEyfCIl20CGa4JfC5ZAIK+UvW1SHJ9es6mmQK3Wr8vHJ2rLSBygVNvqkt4cGBv9DLf NPHW+YU7sPNj9/+yONtNzvNjVM3l+G/BXE345jRC/be2uKz8NcXRndxQAJRbfGIdNQ9B GdRg== X-Forwarded-Encrypted: i=1; AJvYcCVcuFs3xYVTAFvPOjYvQ3DIyJg5UPJqPUbDw4MvMpv6JMBx6aZXP5mn6nGE6Cd4EOBBJA8=@vger.kernel.org X-Gm-Message-State: AOJu0YwWns5MgEtduILTw9BSNHy+9oGLVIpkf7wjkWfUm69Ut8LTMFMt H2XuHYTmZN7i0/QRvBXOkc0K9WTdQd1JGGaIqm5tR60fx0l7H9mGxpcF X-Gm-Gg: AZuq6aLOL88H1fS/CBFGpGJ8IXkeJGwj1zSwH6cc6Aevz9k9uFRnPbfioX1LwMHqcwz y8LCj0YttsK92GSSXsa9AYb6oLI3t4Xl9JWiVAq/mcXZveEuZP3mcxj6dPdiCXuOBUj1LNvPEUR kQPGslTqf0am8iQnhXKsqPLJNO5Yax1IeltIyYLL95Fxg9bJDp0aWItpwzYF3W583StKacF6xdT Zhfe4/or+KqMwAZPatv4otW45sQvLOj5k69pJqN5kNIqkzhFyumZxJHRWzSCb+KiO/3rOIdnieN /PSxfbhf2tntorPnF+v6ViIxkpxgk8xc+RyHPhZwsFvGbrKIkI65johu1cY3G5yjb5X5n4jr3A3 N6LVScjQRyLNOykIjxd04ZcdmkVJ6ScYTGHlqMSSl62Lg04J4/wpWxrbsWImXDeSL+VXY6zBV+9 1ONAcQmJFQK1aKXL0GaaJbOVFoQbuXICy/sAEALXLNxqG4 X-Received: by 2002:a05:690e:1c1c:b0:644:60d9:864d with SMTP id 956f58d0204a3-6493c872baemr4135180d50.92.1769017010185; Wed, 21 Jan 2026 09:36:50 -0800 (PST) Received: from devvm11784.nha0.facebook.com ([2a03:2880:25ff:d::]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-649170adf11sm8096311d50.16.2026.01.21.09.36.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 09:36:49 -0800 (PST) Date: Wed, 21 Jan 2026 09:36:48 -0800 From: Bobby Eshleman To: Paolo Abeni Cc: Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Xuan Zhuo , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Bryan Tan , Vishnu Dasa , Broadcom internal kernel review list , Shuah Khan , Long Li , Jonathan Corbet , linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kselftest@vger.kernel.org, berrange@redhat.com, Sargun Dhillon , linux-doc@vger.kernel.org, Bobby Eshleman Subject: Re: [PATCH net-next v15 01/12] vsock: add netns to vsock core Message-ID: References: <20260116-vsock-vmtest-v15-0-bbfd1a668548@meta.com> <20260116-vsock-vmtest-v15-1-bbfd1a668548@meta.com> <4997118e-471c-45fe-bc1f-8f6140199db5@redhat.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4997118e-471c-45fe-bc1f-8f6140199db5@redhat.com> On Wed, Jan 21, 2026 at 05:32:34PM +0100, Paolo Abeni wrote: > On 1/21/26 3:48 PM, Stefano Garzarella wrote: > >> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt > >> index a8d0afde7f85..b6e3bfe365a1 100644 > >> --- a/Documentation/admin-guide/kernel-parameters.txt > >> +++ b/Documentation/admin-guide/kernel-parameters.txt > >> @@ -8253,6 +8253,20 @@ Kernel parameters > >> them quite hard to use for exploits but > >> might break your system. > >> > >> + vsock_init_ns_mode= > >> + [KNL,NET] Set the vsock namespace mode for the init > >> + (root) network namespace. > >> + > >> + global [default] The init namespace operates in > >> + global mode where CIDs are system-wide and > >> + sockets can communicate across global > >> + namespaces. > >> + > >> + local The init namespace operates in local mode > >> + where CIDs are private to the namespace and > >> + sockets can only communicate within the same > >> + namespace. > >> + > > > > My comment on v14 was more to start a discussion :-) sorry to not be > > clear. > > > > I briefly discussed it with Paolo in chat to better understand our > > policy between cmdline parameters and module parameters, and it seems > > that both are discouraged. > > Double checking the git log it looks like __setup() usage is less > constrained/restricted than what I thought. > > > So he asked me if we have a use case for this, and thinking about it, I > > don't have one at the moment. Also, if a user decides to set all netns > > to local, whether init_net is local or global doesn't really matter, > > right? > > > > So perhaps before adding this, we should have a real use case. > > Perhaps more than this feature, I would add a way to change the default > > of all netns (including init_net) from global to local. But we can do > > that later, since all netns have a way to understand what mode they are > > in, so we don't break anything and the user has to explicitly change it, > > knowing that they are breaking compatibility with pre-netns support.\ > > Lacking a clear use-case for vsock_init_ns_mode I tend to think it would > be better to postpone its introduction. It should be easier to add it > later than vice-versa. > > If there is a clear/well defined/known use-case, I guess the series can > go as-is. > > /P > Our use case also does not need the ability to set the init ns mode, so I'll revert this bit. Thanks, Bobby