From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD54C3002DC; Mon, 26 Jan 2026 11:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769425643; cv=none; b=T73jI6+6VUsy518zCbv0JxBpF3G7TDk+JI+ljRXKcYKLzdtlV4Q1m0QTFfJkmusfaNNd4RTf0/PUm48FYHkP7VDsAV5e8PjIueP5OKYazBtoeXBH2lLPJeOk+NH0biCp47KhwbWGolDhQ2GtB62KEeBUNz2oRCEel0sGLTH6GWA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769425643; c=relaxed/simple; bh=13264qrMCQhOYJJ+Yi610FF7PBiCw3G7fVvwcjzIa1Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rVyjXmT4p93dINXN7eT5SB87xz2cvoc42pukZagVnrNALec3U5ZK6EIL489rDVObQccxk1BKqbNNO7EnUnmzInlnUeAFQMYNgYqMsrIVqNK+3HKo6uZIN9Z7a0wDNXlV6lloBAfHYbE/0EHbI8bP+6qiOiTd8L5o/p7lOjQsZz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ixdnJZmR; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ixdnJZmR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769425642; x=1800961642; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=13264qrMCQhOYJJ+Yi610FF7PBiCw3G7fVvwcjzIa1Y=; b=ixdnJZmRh6gRgXQ5/hGU2ozv5xliwNdQZ+u61sezCs0o3/KBYEEy9PEt 0d6gCzyW1i0ERpQ9myafwQEwU+fd66QNk/kLc3JvFBEx3fwZCecO/mrOg H95GtaVxcYrKd/05QwTtzb5MshFdMHE3NQ/6tsxqlYUB1su83sogRYPRK grLg2rPafqnR5aNKmZzXEFOz4rgdNHOXZeakEco2AAy7Q2gxE4EchfzbY pIYYYlQhX1DucG1Z7cN3XnwtKJlAEdmImfOtIfSaZstwvGFX8TXWj49wy WQtvbrPdhMlb+tS3yJmFg5GWMmkpD9OsVp/EnJJ4Bz43uSVRoTg9k3EPP g==; X-CSE-ConnectionGUID: xTbjUo4dRsK9QKwLBGD4yQ== X-CSE-MsgGUID: iTg5OQ3BTP60NFTlWCtlOQ== X-IronPort-AV: E=McAfee;i="6800,10657,11682"; a="70505057" X-IronPort-AV: E=Sophos;i="6.21,255,1763452800"; d="scan'208";a="70505057" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 03:07:21 -0800 X-CSE-ConnectionGUID: D41W+9cySa2zhutrrohEgw== X-CSE-MsgGUID: hKAdt33ISCCHUCojOMLibw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,255,1763452800"; d="scan'208";a="207711821" Received: from krybak-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.55]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2026 03:07:13 -0800 Date: Mon, 26 Jan 2026 13:07:10 +0200 From: Tony Lindgren To: Chao Gao Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org, reinette.chatre@intel.com, ira.weiny@intel.com, kai.huang@intel.com, dan.j.williams@intel.com, yilun.xu@linux.intel.com, sagis@google.com, vannapurve@google.com, paulmck@kernel.org, nik.borisov@suse.com, zhenzhong.duan@intel.com, seanjc@google.com, rick.p.edgecombe@intel.com, kas@kernel.org, dave.hansen@linux.intel.com, vishal.l.verma@intel.com, Farrah Chen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH v3 22/26] x86/virt/tdx: Update tdx_sysinfo and check features post-update Message-ID: References: <20260123145645.90444-1-chao.gao@intel.com> <20260123145645.90444-23-chao.gao@intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123145645.90444-23-chao.gao@intel.com> On Fri, Jan 23, 2026 at 06:55:30AM -0800, Chao Gao wrote: > +int tdx_module_post_update(struct tdx_sys_info *info) > +{ ... > + /* > + * Blindly refreshing the entire tdx_sysinfo could disrupt running > + * software, as it may subtly rely on the previous state unless > + * proven otherwise. > + * > + * Only refresh version information (including handoff version) > + * that does not affect functionality, and ignore all other > + * changes. > + */ > + tdx_sysinfo.version = info->version; > + tdx_sysinfo.handoff = info->handoff; > + > + if (!memcmp(&tdx_sysinfo, info, sizeof(*info))) > + return 0; > + > + pr_info("TDX module features have changed after updates, but might not take effect.\n"); > + pr_info("Please consider updating your BIOS to install the TDX Module.\n"); > + return 0; > +} To me it seems that a Linux a TDX module loader recommending a BIOS module loader is not very user friendly :) Anyways that more stuff for future so: Reviewed-by: Tony Lindgren