public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Fred Griffoul <griffoul@gmail.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com,
	linux-kernel@vger.kernel.org,
	 Fred Griffoul <fgriffo@amazon.co.uk>
Subject: Re: [PATCH] KVM: nVMX: Track vmx emulation errors
Date: Wed, 25 Feb 2026 12:18:37 -0800	[thread overview]
Message-ID: <aZ9ZHTGFCh_TGeUm@google.com> (raw)
In-Reply-To: <20260120144550.1083396-1-griffoul@gmail.com>

On Tue, Jan 20, 2026, Fred Griffoul wrote:
> From: Fred Griffoul <fgriffo@amazon.co.uk>
> 
> Add a new kvm_stat vcpu counter called "nested_errors" to track the
> number of errors returned to an L1 hypervisor when emulated VMX
> instructions fail.

This is too broad/vague, and very imperfect.  E.g. if a guest is tripping on a
specific VMREAD for whatever reason, it will pollute the count and make it hard
to detect more serious issues like VM-Entry failures.  And if VMCS shadowing is
in use, KVM could easily underreport meaningful errors.

I also dislike implementing this for nVMX but not nSVM.  nSVM doesn't have the
same ISA surface and so many of the errors simply don't exist, but at the very
least VMRUN failures should be accounted.

And counting VM-Fail but not faults is rather odd if the goal is to monitor L1
hypervisor health.

> This counter should help monitor nVMX health and troubleshoot issues
> with L1 hypervisors.

There are lots of ways to monitor the health of L1 hypervisors, it's not clear to
me why we need a KVM-provide stat for VM-Fail.

      reply	other threads:[~2026-02-25 20:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-20 14:45 [PATCH] KVM: nVMX: Track vmx emulation errors Fred Griffoul
2026-02-25 20:18 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZ9ZHTGFCh_TGeUm@google.com \
    --to=seanjc@google.com \
    --cc=fgriffo@amazon.co.uk \
    --cc=griffoul@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox