From: Peter Xu <peterx@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org, "Cédric Le Goater" <clg@redhat.com>,
kvm@vger.kernel.org, "Alex Williamson" <alex@shazbot.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Ben Chaney" <bchaney@akamai.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@kernel.org>,
"Fabiano Rosas" <farosas@suse.de>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mark Kanda" <mark.kanda@oracle.com>
Subject: Re: [PATCH 06/10] system/memory: split RamDiscardManager into source and manager
Date: Mon, 23 Feb 2026 12:37:28 -0500 [thread overview]
Message-ID: <aZyQWOQeKeT5yzIv@x1.local> (raw)
In-Reply-To: <CAMxuvax5uYVr0V3qKFV3t63BLkdqJco5thx23EKggH_dbKsAdQ@mail.gmail.com>
On Fri, Feb 20, 2026 at 09:28:23PM +0100, Marc-André Lureau wrote:
> Do you mean that we could drop replay_populated/replay_discarded from
> the source? I think we could. replay_by_populated_state() already
> handles the aggregation logic by using is_populated() alone. There
> isn't much gain in the above implementation narrowing the iteration
> from the first source replay.
Yes, then we can also get rid of special casing the first source (where we
may invoke other sources' hooks within the 1st source's cb functions), and
the skip_source logics.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2026-02-23 17:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 10:06 [PATCH 00/10] RFC: make RamDiscardManager work with multiple sources marcandre.lureau
2026-02-04 10:06 ` [PATCH 01/10] system/rba: use DIV_ROUND_UP marcandre.lureau
2026-02-04 11:01 ` Cédric Le Goater
2026-02-04 10:06 ` [PATCH 02/10] memory: drop RamDiscardListener::double_discard_supported marcandre.lureau
2026-02-04 11:01 ` Cédric Le Goater
2026-02-04 10:06 ` [PATCH 03/10] virtio-mem: use warn_report_err_once() marcandre.lureau
2026-02-04 11:01 ` Cédric Le Goater
2026-02-04 10:07 ` [PATCH 04/10] system/memory: minor doc fix marcandre.lureau
2026-02-04 11:01 ` Cédric Le Goater
2026-02-04 10:07 ` [PATCH 05/10] kvm: replace RamDicardManager by the RamBlockAttribute marcandre.lureau
2026-02-04 11:02 ` Cédric Le Goater
2026-02-04 10:07 ` [PATCH 06/10] system/memory: split RamDiscardManager into source and manager marcandre.lureau
2026-02-19 19:39 ` Peter Xu
2026-02-20 20:28 ` Marc-André Lureau
2026-02-23 17:37 ` Peter Xu [this message]
2026-02-04 10:07 ` [PATCH 07/10] system/memory: move RamDiscardManager to separate compilation unit marcandre.lureau
2026-02-04 10:07 ` [PATCH 08/10] system/memory: constify section arguments marcandre.lureau
2026-02-04 11:02 ` Cédric Le Goater
2026-02-04 10:07 ` [PATCH 09/10] memory: implement RamDiscardManager multi-source aggregation marcandre.lureau
2026-02-04 10:07 ` [PATCH 10/10] tests: add unit tests for " marcandre.lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aZyQWOQeKeT5yzIv@x1.local \
--to=peterx@redhat.com \
--cc=alex@shazbot.org \
--cc=bchaney@akamai.com \
--cc=clg@redhat.com \
--cc=david@kernel.org \
--cc=farosas@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=mark.kanda@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox