From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E36DC4332F for ; Wed, 2 Nov 2022 18:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231144AbiKBSRl (ORCPT ); Wed, 2 Nov 2022 14:17:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbiKBSRj (ORCPT ); Wed, 2 Nov 2022 14:17:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB9F023BC1 for ; Wed, 2 Nov 2022 11:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667413001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jw7b1n/ebpTUgcQG/rFiOjJ5EJAXbmzR8GTB2GXchZg=; b=XdY1HBWHDVo+fzXj8wpK0a1ecIRUDCUWEFLKHffANdN95sC3HmTkSWzTB5766j23HAYpjr CznTeYjUBPaTGHxOeiz0gLfvnQR56vm8iRQCgMwzfD6w1dse5ttegKZ5ADopcCoELjidKG TVouwA6YTF5feGBZ8c6Rplclc9POfKE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-380-CcyawTwdNxeEaciK6DpXLg-1; Wed, 02 Nov 2022 14:16:40 -0400 X-MC-Unique: CcyawTwdNxeEaciK6DpXLg-1 Received: by mail-ej1-f72.google.com with SMTP id xc12-20020a170907074c00b007416699ea14so10405849ejb.19 for ; Wed, 02 Nov 2022 11:16:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jw7b1n/ebpTUgcQG/rFiOjJ5EJAXbmzR8GTB2GXchZg=; b=FkNauq0pzvmAoA78iQTdD8hMGB2H90HfhrBOyQkjFnsdkFS14CqHHwlUIDm3xNA89w gyfxmMQCjhOiM/WlCzebgUuDVY7Y+vzYuKgH1p4vo3YH5sndZNCHtFzSiln8NNL6NkYr dKDi8FaYMU3DYlyLix0xnKwS5OIpED8n3NC9IJVzbCIMWIwznG9e4xEjgS6Vln8T2stt LmylzM8jZm+DxFsusuerzsCZIdUcRD8B0viKDSgQW5RX1mAZoYsZnmzpmaL0XtVMYy/x 1L8K18xmBBOx7stGmvcryqKp7UHfhjYriJRgCkw4SEcizZaGP+QlsnO9Qmt8pZ8JrzrW YPqw== X-Gm-Message-State: ACrzQf34YUV+SbJDYQgeYTUr8pzh6bX8DHVYL6ptR8MhQ4DkYZwFa5/C VP/hxS/HDUSworgXtodJrvJlpwizW/sbSY7rSADb+ntxNcK7jDU/JI2CkVRLOJIS0bbnrHPOCjs K/8KlEvT7SuPG X-Received: by 2002:a05:6402:3510:b0:461:f781:6dfe with SMTP id b16-20020a056402351000b00461f7816dfemr25254372edd.272.1667412999732; Wed, 02 Nov 2022 11:16:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7UA6R8jQnjSfp5PyABI62YVAutDXQCVF5ugPNvKazAfZNC4L2rsedaZ5ctjKOqJgVSsGWNrA== X-Received: by 2002:a05:6402:3510:b0:461:f781:6dfe with SMTP id b16-20020a056402351000b00461f7816dfemr25254341edd.272.1667412999438; Wed, 02 Nov 2022 11:16:39 -0700 (PDT) Received: from ?IPV6:2001:b07:add:ec09:c399:bc87:7b6c:fb2a? ([2001:b07:add:ec09:c399:bc87:7b6c:fb2a]) by smtp.googlemail.com with ESMTPSA id qk4-20020a170906d9c400b007ad69e9d34dsm5756143ejb.54.2022.11.02.11.16.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 11:16:38 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 19:16:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 2/6] x86: KVM: Enable AMX-FP16 CPUID and expose it to guest Content-Language: en-US To: Dave Hansen , Jiaxi Chen , kvm@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, seanjc@google.com, ndesaulniers@google.com, alexandre.belloni@bootlin.com, peterz@infradead.org, jpoimboe@kernel.org, chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com, babu.moger@amd.com, jmattson@google.com, sandipan.das@amd.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, fenghua.yu@intel.com, keescook@chromium.org, jane.malalane@citrix.com, nathan@kernel.org, linux-kernel@vger.kernel.org References: <20221019084734.3590760-1-jiaxi.chen@linux.intel.com> <20221019084734.3590760-3-jiaxi.chen@linux.intel.com> <639c22a1-b0b0-9fb0-2a9a-060c53f9f540@intel.com> From: Paolo Bonzini In-Reply-To: <639c22a1-b0b0-9fb0-2a9a-060c53f9f540@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 11/2/22 19:14, Dave Hansen wrote: >> >> kvm_cpu_cap_mask(CPUID_7_1_EAX, >> - F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) >> + F(AVX_VNNI) | F(AVX512_BF16) | F(CMPCCXADD) | F(AMX_FP16) >> ); >> >> kvm_cpu_cap_mask(CPUID_D_1_EAX, > > KVM folks, is the idea that every feature that is enumerated to a guest > needs to be in one of these masks? Or is there something special about > the features in these masks? Yes, all features are vetted manually to see whether they require new MSRs and the like. Therefore, anything that userspace can set in the guest's CPUID must be in the list. Paolo