From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C6F9328611 for ; Wed, 9 Sep 2026 04:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788928167; cv=none; b=soDBT9y3hNIjMlZ5zmARcvzpVtgY1/w0nua/5Z4rmNYgM7l/e/ogpTn3Gs2Nu7R5YynLL6AflwWK+GNfy8Zeo4Q/g5f4fzvd7HYQyoPDgTC2oOh4xyDkAZHpw2EN3beaUMLfS35/JxMB+7ZW1/ri3nGVobeYotSrxequQ4VBDxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788928167; c=relaxed/simple; bh=WTn05/4QycXhxqRWks5EqAjlR8e86BCzz+vfMc6TDRE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nW8ENDhWlpcb9Myem9YAI+h+Khju2eKpqSePDBoktnbSn+yVU4rKsMy6VWdCdOT1HtW5iHaGBjdy4c/rnhS1okux7uu17GhW1rvhomWwslntfUlcUWGdk+6TAL+Ft4UgoufPnTagXVqgFlXFm0thITmO+M4f+eqO8qExXBMpCEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LGUi96nV; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=EmPFeAu5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LGUi96nV"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="EmPFeAu5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788928163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nh6M4VZCYgC4q2LdczwdgMA5ELYVwccRqILicmGF2f4=; b=LGUi96nVVP5ewTjOaQk1h7clWnXbVLTE6Wnzm1CS76i3AATFVCPI9brEI3jny+hL4fwGNs KMuAnmHtQXEcG4zxcSMKPWSaUYM8VXPq4Cm/LZ45eRK5eD+o2goVDYpon3QlivOoUYiain fz/fL1+RztXS+a9SVnLI5LQIyd26Z8g= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-qoXjDYRhN4a-Myn4kc4aRw-1; Wed, 09 Sep 2026 00:29:22 -0400 X-MC-Unique: qoXjDYRhN4a-Myn4kc4aRw-1 X-Mimecast-MFC-AGG-ID: qoXjDYRhN4a-Myn4kc4aRw_1788928161 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-398ba5404d2so1057070a91.1 for ; Tue, 08 Sep 2026 21:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1788928161; x=1789532961; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Nh6M4VZCYgC4q2LdczwdgMA5ELYVwccRqILicmGF2f4=; b=EmPFeAu50xW5vOqAf3VuxXMCtwy7CYeoLd+ZDi1oQHUoRRFivygD9WsIQugNaAR0LO p3jC1NDB1ADEEFkULyI0o4DiJVJ7JRf+HZhYl2BGoLEh/63JjG/a30E+FmqTappLkKS2 EEj3b9J30qiOtSuKIb7+qHwLH80hiEEhW9UPgSWfvPQiAqQ6yJLCp/xlPbkvlgBwNx5h IJf1C6gZ/Kb9lY9Lmcrygv/BMYQ73+SKYKpKqLyuGqOVWUrXyeXr2i4VZGvKqDu/4Kaq Ey2QFWAkLCKYR6xqXKxzf4r9g6GVSK2kyIT0abkxB3hUmhnIeiv6whpzicPikpaXGvkw Oizw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788928161; x=1789532961; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nh6M4VZCYgC4q2LdczwdgMA5ELYVwccRqILicmGF2f4=; b=UVXGZkMF2xJg8iDR+FTxTl+szKqgz4OkW61ElTHg/LdQP7FUO3aOZ9lx9v8GUIPfMp rOu8qsmMQxJmjb+7J0HagenF1QQMF3cZ8ZB8C1jZiJ0LgLqReErd3zvdL6d0Fe86j6U5 ezw+KTASlFKhtrLA8xGeQHMbbEbIlRGvWpkVCjfsZS0eg7JjCX9j7stTLGDk0Uf5qQeo 4VRquH8BmTH0Os4shtX8OBnRos6KKKzVHuh1U3+2GsAUKZlLHgBV8/Q+r9wMO5IQ6Cd9 d3LvHEKsBuvenOTwurmyvGUYaSSt3rUGr/QNAvjT5qeo1U0o5hQuAmiM0hlV2O4kt/6B fkog== X-Forwarded-Encrypted: i=1; AKwUvBwEJ59tC5zEd+QLnJFzB3Ldp5rK1hLxAoMczgPBf8ZpMYot7SMfCBBBO3q5Zk325S+x9co=@vger.kernel.org X-Gm-Message-State: AFuF++lGWXwLSG/GBm1bOKUCgg4uLUlL70lGdf9HKk54ie1dKdQcmZsO VXN5KAH1ykjccCIwCyAdrIuPFfH4vWbExDQHq+RTh7911C9fxA1lA52x8iYuCgYz214D2jVzGQZ M+doIo2AtD8bzv4pzQHF3M8NHoZUOy/sPYdTnXLNDhNui6LllvElTqQ== X-Gm-Gg: AYBFou2dMrq+HEKRnK2nHmp5bMpzUmmcajJhl3TFveX2XrasOklHQVMTavOKiZLQInM wwAXijetxncgyhGoo92SszgZE9SKJoVChxAXA+lJADA065dEgKl4lLfSzK3kRKpYESXl6dZekdf 3P+mzo37gOOn3gJ2VavJ5WJ+6C8KGnLQVaAquQHiwQxKjPphDf9eLpUdNbDxrArH8EeK768Latu 5m132ZukbASmUoXX83YReWt/lEpQIu/9Kt595hfOzDsomaR6vRFzZKdXaXZYNCZhduUxpctrR2z PW7hNnKySWNsS5rDnp6V2yeat128T+oTRld3Kv+1oC2efZKDOjFULVKHOnRS+9yFY0GtJWHdZe1 Krp1YuWTo/pCfT39sfyzcVGe3Lb9Ryje9XAxxVi9Ruw== X-Received: by 2002:a17:90b:564c:b0:37f:e326:6557 with SMTP id 98e67ed59e1d1-39b2612338dmr54737953a91.4.1788928160886; Tue, 08 Sep 2026 21:29:20 -0700 (PDT) X-Received: by 2002:a17:90b:564c:b0:37f:e326:6557 with SMTP id 98e67ed59e1d1-39b2612338dmr54737906a91.4.1788928160430; Tue, 08 Sep 2026 21:29:20 -0700 (PDT) Received: from [192.168.68.52] (n175-34-8-244.mrk21.qld.optusnet.com.au. [175.34.8.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39ba0a7b2c3sm5544813a91.0.2026.09.08.21.29.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Sep 2026 21:29:19 -0700 (PDT) Message-ID: Date: Wed, 9 Sep 2026 14:29:08 +1000 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v17 5/7] firmware: arm_rmm: Activate the RMM To: Suzuki K Poulose , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: maz@kernel.org, will@kernel.org, catalin.marinas@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steven.price@arm.com, aneesh.kumar@kernel.org, oupton@kernel.org, joey.gouly@arm.com, tabba@google.com, yuzenghui@huawei.com, linux-coco@lists.linux.dev, gankulkarni@os.amperecomputing.com, sdonthineni@nvidia.com, alpergun@google.com, fj0570is@fujitsu.com, WeiLin.Chang@arm.com, lpieralisi@kernel.org, enju.kohei@fujitsu.com References: <20260907095942.1140734-1-suzuki.poulose@arm.com> <20260907095942.1140734-6-suzuki.poulose@arm.com> Content-Language: en-US From: Gavin Shan In-Reply-To: <20260907095942.1140734-6-suzuki.poulose@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Suzuki, On 9/7/26 7:59 PM, Suzuki K Poulose wrote: > From: Steven Price > > Activate the RMM after the basic configuration. This is a memory transferring, > stateful operation. > > Signed-off-by: Steven Price > Signed-off-by: Suzuki K Poulose > --- > Changes since v16: > * Split into a new patch > --- > drivers/firmware/arm_rmm/rmi.c | 17 +++++++++++++++-- > include/linux/arm-rmi-cmds.h | 11 +++++++++++ > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/arm_rmm/rmi.c b/drivers/firmware/arm_rmm/rmi.c > index 42c973c3a98bb..d969c8738efde 100644 > --- a/drivers/firmware/arm_rmm/rmi.c > +++ b/drivers/firmware/arm_rmm/rmi.c > @@ -641,7 +641,8 @@ static int rmi_configure(void) > > static int __init arm64_init_rmi(void) > { > - int ret; > + int ret = 0; > + struct rmi_sro_state *sro = NULL; Why we need to initialize those local variables ('ret' and 'sro')? :-) Also, we can use the scope-based cleanup function supported by cleanup.h for @sro. struct smi_sro_state *sro __free(kfree) = NULL; With the scope-based cleanup in place, we needn't explict 'kfree(sro)' at end of this function. > > /* Continue without realm support if we can't agree on a version */ > ret = rmi_check_version(); > @@ -656,7 +657,19 @@ static int __init arm64_init_rmi(void) > if (ret) > return ret; > > - return 0; > + /* Activate the RMM */ > + sro = kmalloc_obj(*sro); > + if (!sro) > + return -ENOMEM; if (!sro) { pr_err("Unable to alloc SRO object for RMM activation\n"); return -ENOMEM; } > + > + ret = rmi_rmm_activate(sro); > + if (ret) { > + pr_err("RMM activate failed\n"); > + ret = ret < 0 ? ret : -ENXIO; > + } > + > + kfree(sro); > + return ret; > } > > /* > diff --git a/include/linux/arm-rmi-cmds.h b/include/linux/arm-rmi-cmds.h > index fed0f3421895d..dea7c7004d35f 100644 > --- a/include/linux/arm-rmi-cmds.h > +++ b/include/linux/arm-rmi-cmds.h > @@ -64,6 +64,17 @@ static inline int rmi_rmm_config_set(unsigned long cfg_ptr) > return res.a0; > } > > +/** > + * rmi_rmm_activate() - Activate the RMM > + * @sro: Preallocated SRO context to be used > + * > + * Return: 0 on success, positive RMI result code or negative Linux error code > + */ > +static inline long rmi_rmm_activate(struct rmi_sro_state *sro) > +{ > + return rmi_sro_memxfer_cmd(sro, GFP_KERNEL, SMC_RMI_RMM_ACTIVATE); > +} > + rmi_rmm_acvivate() would be used for once by rmi.c::arm64_init_rmi(). Lets not expose the function by combining the logic to rmi.c::arm64_init_rmi(). > /** > * rmi_features() - Read feature register > * @index: Feature register index Thanks, Gavin