From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4B8C3E1229 for ; Thu, 5 Mar 2026 17:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772731177; cv=none; b=FyTVO8EE9tOk32ePLhBj8yVpG15gFar1zO7GIAnloaBOpcwtPh9z+3xvkuk29tBtOTyJXwK3jY51jrU9gGMre6oYEaw06BstBFz6RSywnTfir9KY+Sl2HdVVQR8/+2VQK6S+W0VOkq7N3ZSUF3n5nv6AYBmvaDP93Lj5M7pHygM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772731177; c=relaxed/simple; bh=44DsyPZjR3+ZY9GszCDwqZ3g/HaaKmi7IKLakzXhb6E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=u0J7V227nH5Gd6gAG26Dv9W7BecOQ73/9Xypn2ZcFLFmxWgEa8dO6cadbfFfxy+7BtiHPmZhUEPsftC5u11cdmjSI3ypF2Toy2t32ypqk2GVXbyX4OdC+4kYbls/nFbxcnpxVrn50fZYZ08Wr4GZ8Wjh0KalVzcRFIl+H0XtGHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=GCMhfHi0; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GCMhfHi0" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-824af3c6c0cso3550427b3a.3 for ; Thu, 05 Mar 2026 09:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772731176; x=1773335976; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=GCMhfHi039z0xYJI1g53I6vSeQvWegx9IdH6BuHB9ae1dJye7XciAjY25sZ+R7h03a +8xOBbjkbQoXMXG2cuGv+Y2veFW/RDj1y5hIQ9arJaumsbt+DD7s9fQ+Fxo5EtQ6D/9Y lZrJBwy5awiuOgDpLGBPR+qIV+c1a0WI30zX5FlKfodjoW4dwpf7FyC3VVQYUhHFRJQK CyAfo0+LLQxxp5Cw2s0jPVWcxoohsAGoZyFLsp+ZycJHUleAdsbezYwtecTBDmRC+rzE RtcKuYsOKaNzN3NiWSZryIC3JA6h4NJD2Fxpdc4//BsRKlClUn+3qC9Gh5EdT5inx4Pu G25A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772731176; x=1773335976; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jvL7QI7vtAV/elV7wuwJjb0ouQ5MS/0W571Ri2ejdh8=; b=WOZTXqepll+alIRrx2OgxYYvfZkVWMG3t/NhtZPHcnUoYmsCHZ8NAvdTfeG4V3HEHQ KHLgNVWjcc0bCL7pEbSgxbfbYg/i4jqZ0jsxF7ZZXiPZDr8FlkSxX7cyl6cVbhn5INv9 CNfWloMxpQREFcElM8mzWVF6VVC+92KhpjbSIFkvrZt8QFx/u85OpfWdwTdEj5qKnDCe V0zoemBsSbnbVS0CHIhut03kmZXFBloUqyoX2tRAFf+uJlMTF60ROqo2Ba9Nmf3gRjDL mwDP4jVi5LkQlF6QryN0RHArtBZAiWkkHCetxQpMNEr9gXFLYSPIncQmgJb5Pej3UKUj QNKg== X-Forwarded-Encrypted: i=1; AJvYcCUdSHvkvLybq1UTQUTrmMLtXR7pXhHCDb1N/BoT1Gyfg29CQfeBV/2J69KERPcEOCRRB7o=@vger.kernel.org X-Gm-Message-State: AOJu0YyI4Q7eOykL8lUPXyEhC+kgIQLbiFCuqBPhAPauK9yGTDUbIs+n 5Z90GXHMLjrMFOxBdl1FnghDCvpKCT7sH6ztsk+G65SeuqWRoTgMzqtHSLRGt2x3u/GEJyIqHp0 BXZhX6g== X-Received: from pfcp25.prod.google.com ([2002:a05:6a00:a259:b0:829:808f:cb8d]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:4295:b0:81b:d5d9:a83a with SMTP id d2e1a72fcca58-8299ae60809mr419972b3a.61.1772731175885; Thu, 05 Mar 2026 09:19:35 -0800 (PST) Date: Thu, 5 Mar 2026 09:19:34 -0800 In-Reply-To: <20260220004223.4168331-5-dmatlack@google.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260220004223.4168331-1-dmatlack@google.com> <20260220004223.4168331-5-dmatlack@google.com> Message-ID: Subject: Re: [PATCH v2 04/10] KVM: selftests: Use u64 instead of uint64_t From: Sean Christopherson To: David Matlack Cc: Paolo Bonzini , Ackerley Tng , Albert Ou , Alexandre Ghiti , Andrew Jones , Anup Patel , Atish Patra , Bibo Mao , Christian Borntraeger , Claudio Imbrenda , Colin Ian King , David Hildenbrand , Fuad Tabba , Huacai Chen , James Houghton , Janosch Frank , Joey Gouly , kvmarm@lists.linux.dev, kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Lisa Wang , loongarch@lists.linux.dev, Marc Zyngier , Maxim Levitsky , Nutty Liu , Oliver Upton , Palmer Dabbelt , Paul Walmsley , "Pratik R. Sampat" , Rahul Kumar , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Wu Fei , Yosry Ahmed , Zenghui Yu Content-Type: text/plain; charset="us-ascii" On Fri, Feb 20, 2026, David Matlack wrote: > -static uint64_t pread_uint64(int fd, const char *filename, uint64_t index) > +static u64 pread_uint64(int fd, const char *filename, u64 index) I think it's also worth converting the function to pread_u64(). > { > - uint64_t value; > + u64 value; > off_t offset = index * sizeof(value); > > TEST_ASSERT(pread(fd, &value, sizeof(value), offset) == sizeof(value),