Re: [PATCH 07 of 19] Move kvm_create_phys_mem to libkvm-x86.c

Avi Kivity
2007-11-06T09:10:22Z

Jerone Young wrote:
> On Sun, 2007-11-04 at 09:29 +0200, Avi Kivity wrote:
>
>> Jerone Young wrote:
>>
>>> # HG changeset patch
>>> # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>> # Date 1194027872 18000
>>> # Node ID 8e77064ea82d0b7fbd8bb77429bbfd62f99c00f6
>>> # Parent 02f38e54018070bafd501df846147f4ae7661109
>>> Move kvm_create_phys_mem to libkvm-x86.c
>>>
>>> This patch moves kvm_create_phys_mem to libkvm-x86.c
>>>
>>>
>>>
>> Creating physical memory isn't arch specific (though a few details
>> are). Why is this made arch specific?
>>
>
> So these can be kept in the common place.

No, you're moving the whole thing!

> But the fact is that x86 will
> be the only one to use them.

What's "them" in this context?

> But technically anyone can potentially use
> it.

And "it"?

--
error compiling committee.c: too many arguments to function