From: Ted Logan <tedlogan@fb.com>
To: Matt Evans <mattev@meta.com>
Cc: David Matlack <dmatlack@google.com>,
Alex Williamson <alex@shazbot.org>, Shuah Khan <shuah@kernel.org>,
<kvm@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] vfio: selftests: only build tests on arm64 and x86_64
Date: Tue, 17 Mar 2026 12:05:47 -0700 [thread overview]
Message-ID: <abmmC0DUZ9gBDjui@devvm6375.cco0.facebook.com> (raw)
In-Reply-To: <e51b4ff2-13c4-47d4-b781-3dcbd740d274@meta.com>
On Tue, Mar 17, 2026 at 01:55:17PM +0000, Matt Evans wrote:
> On 03/02/2026 01:23, Ted Logan wrote:
> > diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile
> > index ead27892ab65..8e90e409e91d 100644
> > --- a/tools/testing/selftests/vfio/Makefile
> > +++ b/tools/testing/selftests/vfio/Makefile
> > @@ -1,3 +1,10 @@
> > +ARCH ?= $(shell uname -m)
> > +
> > +ifeq (,$(filter $(ARCH),arm64 x86_64))
>
> This fails to build (i.e. elides the build) on my local arm64 machine,
> because uname -m returns 'aarch64', not 'arm64'.
>
> Are you seeing an arm64 (Linux! [1]) machine where uname -m is 'arm64'...?
>
> This patch needs some translation, of the sort in
> tools/testing/selftests/mm/Makefile:15
>
>
> -Matt
>
> [1] Note on macOS/M-Mac, uname -m is indeed 'arm64', but not so on Linux.
I didn't have an aarch64 system handy to test when I sent my first
patch, so I went with David's comment in an earlier thread that x86_64
and arm64 are supported. I did just fire up a Linux VM on my Mac and I
see it does indeed report the arch as aarch64, and that it builds the
self-tests without warnings. I'll mail a patch to translate the
architecture as you suggest.
- Ted
prev parent reply other threads:[~2026-03-17 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 1:23 [PATCH v2] vfio: selftests: only build tests on arm64 and x86_64 Ted Logan
2026-02-06 17:54 ` David Matlack
2026-02-06 22:05 ` Alex Williamson
2026-03-17 13:55 ` Matt Evans
2026-03-17 19:05 ` Ted Logan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abmmC0DUZ9gBDjui@devvm6375.cco0.facebook.com \
--to=tedlogan@fb.com \
--cc=alex@shazbot.org \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mattev@meta.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox